[FFmpeg-devel] [PATCH] Move Kaiser-Bessel Derived window to mdct.c

[Robert Swain]

Hello,

On 11/01/2008, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Fri, Jan 11, 2008 at 11:02:05PM +0000, Robert Swain wrote:
> > On 11/01/2008, Michael Niedermayer <michaelni at gmx.at> wrote:
> > > On Fri, Jan 11, 2008 at 12:53:10PM +0000, Robert Swain wrote:

[...]

> @param window    pointer to half window

Done. I agree this is clear. I will use this nomenclature style for
the 'n' variable as well.

> > > > + * @param iter      iterations for Bessel I0 approximation
> > > >   */
> > > > -void ff_kbd_window_init(float *window)
> > > > +void ff_kbd_window_init(float *window, float alpha, int n, int iter)
> > > >  {
> > >
> > > iam for hardcoding the iterations
> >
> > I suppose I should test how many iterations are required to achieve
> > the maximum precision of float, right?
>
> thats an option

OK, will do.

> and patch looks ok

The attached patch has the Doxygen comment change but is otherwise the
same, so apply this one, not the previous one.

Thanks,
Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20080111-kaiser_move.1.diff
Type: text/x-diff
Size: 2670 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080112/3cffc066/attachment.diff>