[FFmpeg-devel] Behaviour of liba52 decoder

[Michael Niedermayer]

On Thu, Jan 10, 2008 at 01:36:31PM -0500, Rich Felker wrote:
> On Thu, Jan 10, 2008 at 06:28:52PM +0000, M?ns Rullg?rd wrote:
> > Rich Felker <dalias at aerifal.cx> writes:
> > 
> > > On Thu, Jan 10, 2008 at 12:57:33PM +0100, Thorsten Jordan wrote:
> > >> Michael Niedermayer schrieb:
> > >> > Hi
> > >> > 
> > >> >> any comments?
> > >> > 
> > >> > a52_decode_frame() looks buggy yes ...
> > >> > i suggest you rewrite it ...
> > >> > 
> > >> > it should roughly look like
> > >> > 
> > >> > read header
> > >> > for(all 6 block)
> > >> >     decode block
> > >> this would be ok if one could demand that full frames are given always.
> > >
> > > All lavc decoders are entitled to assume this.
> > 
> > I'm surprised nobody has mentioned the fact that we now have a native
> > AC3 decoder, so there is no longer any need for the liba52 wrapper.
> > Is there some reason I'm missing why it's still there?
> 
> Good question. I'd be happy to see it removed.

if ours is faster sure remove liba52 support ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080110/e1d389a1/attachment.pgp>