[FFmpeg-devel] [PATCH] Fix a few warnings in libavutil test programs

[Michael Niedermayer]

On Thu, Jan 10, 2008 at 11:32:31AM +0100, Diego Biurrun wrote:
> On Wed, Jan 09, 2008 at 04:24:18AM +0100, Michael Niedermayer wrote:
> > On Wed, Jan 09, 2008 at 01:33:47AM +0000, M?ns Rullg?rd wrote:
> > > Michael Niedermayer <michaelni at gmx.at> writes:
> > > 
> > > > On Wed, Jan 09, 2008 at 12:14:19AM +0100, Diego Biurrun wrote:
> > > >> Here is a patch that takes FFmpeg one step closer to a C programming
> > > >> textbook ;-)
> > > >> 
> > > >> Diego
> > > >> 
> > > >> P.S.: Yes, I can add Makefile rules for all test programs if wanted.
> > > >
> > > > You may apply this if and only if you write a fully working regression test
> > > > for them so that make test, does run them and checks that they suceeded.
> > > 
> > > WTF?  Please read my previous email again.
> > 
> > previous? your? No, i dont see a relation between your previous mail and this
> > thread. A thread in which i try to convince diego to do something usefull
> > instead of fixing commented out code.
> 
> I stumbled over that stuff while reviewing a patch from Diego#2, so I
> thought I might as well make it usable.  How is that not useful?

it worked fine without that change, so no you dont make anything useable
its 99.9% nitpickery. That is fixing theoretic undefined behavior in
code not compiled at all. And as said it did and does work for the
puprose of testing without that change.
There is nothing wrong with fixing it but it doesnt make a difference
ffmpeg, libav* will be byte per byte identical, and none of the outcommenetd
tests which failed before work now.

If OTOH you would make them part of make test that would be usefull and
could prevent actual bugs.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080110/f8896789/attachment.pgp>