[FFmpeg-devel] [RFC] Always set extradata, not only if CODEC_FLAG_GLOBAL_HEADER is set?

[Michael Niedermayer]

Hi

Currently several encoders set extradata only if CODEC_FLAG_GLOBAL_HEADER
is set.
CODEC_FLAG_GLOBAL_HEADER besides this also prevents the global headers from
being placed before each keyframe.

maybe we should always set extradata, this would be somewhat simpler and
more consistant as many encoders use extradata without looking at
CODEC_FLAG_GLOBAL_HEADER and shouldnt do any harm. (no change for muxers which
dont support extradata)
CODEC_FLAG_GLOBAL_HEADER would still be used to avoid global headers before
keyframes.
The encoders affected are faac, x264, xvid and mpeg4

Is there any case where setting extradata does harm?


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080108/5aad023e/attachment.pgp>