[FFmpeg-devel] [PATCH] Make AVRtpPayloadTypes static and constant

[Luca Abeni]

Hi Michael,

Michael Niedermayer wrote:
[...]
>>> Needed by what?
>> Right now, it's only needed by ffserver.c. But ffserver.c also includes
>> config.h, so it is not a reason for installing rtp.h.
>> Maybe some applications might need rtp_get_local_port() (and/or
>> rtp_get_file_handles()?), but I am not sure...
> 
> Applications using ANY rtp specific function from rtp.h are broken

this is why I said that I am not sure ;-)


>> So, I'd like to remove rtp.h from the installed headers. BTW, I committed the
>> patch, and Aurelien replied saying that the commit is breaking API and ABI.
> 
> your change of AVRtpPayloadTypes -> static broke the ABI if one assumes
> everything in rtp.h to be part of the public API/ABI
> removing rtp.h from the installed headers cannot break the ABI
> but as said rtp.h should never have been installed, i do not know why it
> was added to the installed headers ...

Maybe for some historical reason that everyone forgot. Anyway, I'd like to
remove it from installed headers. I'll send a new email with a proper subject,
in a new thread, so that noone can miss it.


			Thanks,
				Luca