[FFmpeg-devel] [PATCH] Realmedia / RTSP (RDT)

[Michael Niedermayer]

On Fri, Jan 04, 2008 at 09:06:48AM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Jan 2, 2008 11:04 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > On Tue, Jan 01, 2008 at 02:36:35PM -0500, Ronald S. Bultje wrote:
> > > Index: ffmpeg/libavformat/rtp_internal.h
> > > ===================================================================
> > > --- ffmpeg.orig/libavformat/rtp_internal.h    2007-11-24 22:36:
> > 33.000000000 -0500
> > > +++ ffmpeg/libavformat/rtp_internal.h 2007-12-27 17:27:23.000000000-0500
> > > @@ -46,7 +46,7 @@
> > >                                                  AVPacket * pkt,
> > >                                                  uint32_t *timestamp,
> > >                                                  const uint8_t * buf,
> > > -                                                int len);
> > > +                                                int len, int flags);
> > >
> > >  typedef struct RTPDynamicProtocolHandler_s {
> > >      // fields from AVRtpDynamicPayloadType_s
> >
> > could you please document per doxygen comment (in a .h file) what flags is
> > good for (yes i really have forgotton, i just remember it was needed for
> > subsequent patches)
> 
> 
> New version with doxy comment for DynamicPayloadPachetHandlerProc attached.
> In RDT, I use flags (in RTP_FLAG_*) to parse the "keyframe" flag from the
> RTP packet header and forward it to the RDT packet parsing function and from
> there to the rmdec.c packet parsing function (in normal .rm files, the flags
> are in the first few bytes of each packet in the file, but those fields are
> stripped in case of RDT because the RTP header already contains those fields
> instead, so you have to read them from the RTP pachet header).

probably ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080105/e55d59d5/attachment.pgp>