[FFmpeg-devel] [PATCH] Make AVRtpPayloadTypes static and constant

Luca Abeni lucabe72
Sat Jan 5 14:38:34 CET 2008


On Sat, 2008-01-05 at 14:19 +0100, Luca Abeni wrote:
> On Sat, 2008-01-05 at 13:34 +0100, Diego 'Flameeyes' Petten? wrote:
> > The attached patch changes the way AVRtpPayloadTypes is defined.
> [...]
> 
> I'm all in favour of this change

Double thinking about it, I have some doubts about the "const" part. I
agree that right now AVRtpPayloadTypes is not modified by ffmpeg's code,
but I suspect that if rtp_get_payload_type() does not find a PT and a
dynamic PT is used, then the corresponding entry in AVRtpPayloadTypes
should be modified... Otherwise, there is no point in having the entries
> 35 in the table.

So, your change is currently ok, but we might want to remove the const
in the future.


			Thanks,
				Luca





More information about the ffmpeg-devel mailing list