[FFmpeg-devel] [PATCH] Make pp_help a constant array of characters

[Michael Niedermayer]

On Thu, Jan 03, 2008 at 01:25:01PM -0500, Rich Felker wrote:
> On Thu, Jan 03, 2008 at 07:06:48PM +0100, Michael Niedermayer wrote:
> > On Thu, Jan 03, 2008 at 03:43:58PM +0100, Diego 'Flameeyes' Petten? wrote:
> > > Michael Niedermayer <michaelni at gmx.at> writes:
> > > 
> > > > breaks ABI
> > > 
> > > Afraid so, attached patch should maintain ABI and still move pp_help to
> > > .rodata (or .rodata+.data.rel.ro for PIC code).
> > 
> > ok
> 
> Why not put an #if based on the version number so we can automatically
> move the whole thing to the better way our friendly Flamereyes
> suggested after the next upgrade? :)

because noone posted a patch doing that :)


> 
> ...or, does that cause copy relocations? :(

in principle i cannot imagine a case where it would be needed but iam pretty
sure that it will be done on x86-64 with a non PIC app and PIC libpp anyway

The only use of that array would be to take its address, that is equivalent of
loading a 64bit value in a register such code can be relocated and would not
be affected by the famous 32bit limit for global_array[x] style accesses.


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080103/08f59bfd/attachment.pgp>