[FFmpeg-devel] [PATCH] Realmedia / RTSP (RDT)

[Luca Abeni]

Hi Diego,

Diego Biurrun wrote:
[...]
>>> I feel there is a need for file splitting here (especially rtp.c).
>>> Maybe I will try to have a deeper look at it.
>> I was going to apply my patch (with the change suggested by Diego), but 
>> after reading your doubts I prefer to wait for your ok too: can I commit 
>> the first patch, or there is a better approach to fix the problem? 
>> Should I rewrite the second patch splitting rtp.c in rtp.c, rtpenc.c and 
>> rtpdec.c?
> 
> I would say start by applying your patches, especially the first one.

Ok, committed (I also committed a fix for a bug in RTP dependencies that 
I noticed when testing my patch).

> Splitting the files is the preferable long-term solution, but it can
> still be done later.  If you want to try your hand at refactoring rtp.c
> into several smaller parts, go right ahead, it should not be hard.

Double-thinking about it, splitting rtp.c should not be much more 
difficult than adding the #ifdefs... I am looking at this, and I will 
post a patch soon.


			Thanks,
				Luca