[FFmpeg-devel] [PATCH] rtsp - alternate protocol

[Diego Biurrun]

On Wed, Jan 02, 2008 at 11:25:15PM +0100, Michael Niedermayer wrote:
> On Wed, Jan 02, 2008 at 08:01:00PM +0100, Diego Biurrun wrote:
> > On Sat, Dec 29, 2007 at 01:54:26AM +0100, Michael Niedermayer wrote:
> > > On Sat, Dec 29, 2007 at 12:08:59AM +0100, Diego Biurrun wrote:
> > > > 
> > > > May I propose granting Ronald commit access?
> > > 
> > > iam against it!
> > > 
> > > > His patches may need some review rounds to be acceptable, but he has a
> > > > history of following through and beating them into shape.  Also, there
> > > 
> > > he has a history of broken patches with alot of stuff never being approved
> > > I see RDT and related code, 90% is not in svn
> > > I see the url_split() patches, first cleanup (introduced a bug) and a
> > >   purpoted fix which introduced more bugs but all this is one page of code
> > > Then the resolve_host() stuff, it should have been replaced by standard
> > > (POSIX) functions, this never happened
> > > various http improvements like seeking support, these did reach svn and
> > > work fine AFAIK
> > > Then there are many small fixes all over the place, these are nice ...
> > > 
> > > I certainly dont want to loose ronald as contributor, but iam scared of
> > > him having direct svn write access!
> > 
> > All of this would only be a problem if he committed non-approved patches.
> > Avoiding this cannot be so hard, can it?
> 
> Noone was able to keep track of his patches ...
> You assume he, himself succeeds keeping track of them :)

Without a doubt he is in the best position to keep track of his own
patches :p

> > > Anyway its not a big issue for me to commit approved patches from him myself.
> > 
> > Then please commit them, because many patches are being dropped on the
> > floor, which is very unfortunate.
> 
> Well i dont keep track of patches after approving them ...
> Ill change that from now on (for ronalds patches), but i cant do anything for
> past patches from him anymore.

Just tracking the patches is unlikely to help, commit them :p

Diego