[FFmpeg-devel] r9017 breaks WMA decoding on Intel Macs

[Trent Piepho]

On Thu, 31 May 2007, Guillaume POIRIER wrote:
> On 5/30/07, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Wed, May 30, 2007 at 02:07:19PM +0200, Guillaume POIRIER wrote:
> > > Ok, fine with me. Michael, do you think that the patch I posted
> > > earlier (100% based on Trent's, only fixing minor issues) should be
> > > applied?
> >
> > well, after actually reading the code ... the loops should be written
> > in asm not by using for() / while() this will make the code faster
> > and it will make the n+%m code naturally dissapear
>
> Well, after getting a hint from Apple guys, here's an updated patch
> that gets rid of all assembler warnings without touching the code as
> much as Trent had done.
>
> Now, maybe writing the loop in ASM ourselves will help, but at least,
> this patch doesn't harm and works on all supported platforms!

This won't assemble correctly if any of the memory operands already have a
displacement. Loren explained why:
http://article.gmane.org/gmane.comp.video.ffmpeg.devel/51453