[FFmpeg-devel] [PATCH] libavformat/mpegts.c minor crash and warning avoidance

[Benoit Fouet]

Michael Niedermayer wrote:
> Hi
>
> On Fri, May 25, 2007 at 09:50:23PM -0700, Glenn A. Serre wrote:
>   
>> Good evening,
>>
>> Benoit Fouet wrote:
>>     
>>> Hi,
>>>
>>> Glenn A. Serre wrote:
>>>       
>>>> Good afternoon,
>>>>
>>>> Benoit Fouet wrote:
>>>>  
>>>>         
>>>>> Hi,
>>>>>
>>>>> Glenn A. Serre wrote:
>>>>>    
>>>>>           
>>>>>> Good evening,
>>>>>>
>>>>>> This patch would be to avoid a compiler warning and avoid a crash that 
>>>>>> happened when I experimented with having mpegts add streams from all 
>>>>>> the PMTs in the transport stream, rather than just from the first one 
>>>>>> found.
>>>>>>
>>>>>>  
>>>>>>      
>>>>>>             
>>>>> it is better to split patches
>>>>> the two ones you're proposing are not correlated, so they should be
>>>>> splitted.
>>>>>    
>>>>>           
>>>> OK.  What is protocol in these cases?  Should I reply with two 
>>>> attachments, make two replies, or ???
>>>>
>>>>  
>>>>         
>>> i think it is ok if you reply with two patches, now that the thread exists
>>>
>>>       
>> [...]
>>
>> Sorry for the delay.  The two separate patches are attached.
>>     
>
> the second patch is rejected
>   

and the first one is applied
(please send patches that can be applied from ffmpeg root directory)

> at least until you provide everyting needed to reproduce the crash and an
> analysis of why the crash happens, from my POV this looks like your
> private modifications are buggy and causing it
>   

Ben
-- 
Purple Labs S.A.
www.purplelabs.com