[FFmpeg-devel] the future of fastmemcpy.h

[Diego Biurrun]

On Sat, May 26, 2007 at 06:18:18PM +0000, Arpi wrote:
> 
> > On Tue, May 22, 2007 at 10:55:27PM +0200, Michael Niedermayer wrote:
> > > 
> > > On Tue, May 22, 2007 at 10:15:43PM +0200, Alex Beregszaszi wrote:
> > > > 
> > > > > > > Ronald brought up the subject of the fastmemcpy.h #includes that we
> > > > > > > continue to have in a few source files.  fastmemcpy.h is part of
> > > > > > > MPlayer and not FFmpeg.  Is the #include just old cruft or worth
> > > > > > > keeping?
> > > > > > 
> > > > > > I thought today about moving fastmemcpy into libavutil.
> > > > > 
> > > > > What about licensing? Fastmemcpy is GPL, isn't it?
> > > > 
> > > > We already have GPL code in FFMpeg, which is enabled only when
> > > > --enable-gpl is specified. Also making fastmemcpy optional won't be a
> > > > problem, as it is optional currently too.
> > > > 
> > > > Should I try preparing a patch?
> > > > 
> > > > Also in long term we could try asking fastmemcpy authors for LGPL
> > > > licensing. Big part of it was written by Michael anyway (agpcopy).
> > > 
> > > you have my agreement for LGPL-ing the parts of fastmemcpy i wrote
> > > but IIRC part of the fastmemcpy code came from the linux kernel though
> > > maybe i remember that wrong its a long time ago ...
> > 
> > The file consists largely of two functions, memcpy_pic() and
> > mem2agpcpy().  The first was added by Arpi in r5505, the second by you
> > in r4682.  Arpi, did you write that function yourself or where did it
> > come from?  And if it's completely your code, do you agree to LGPL it?
> 
> these are only wrappers over fast_memcpy() implemented in aclib_template.c
> i don't remember if i wrote these or just moved out from some other
> file (probably some vo_ driver), but they are so simple and trivial...
> 
> so feel free to LGPL these, and if anybody has complaints send him to me.

I've slapped an LGPL header on the file.

Diego