[FFmpeg-devel] [PATCH] make libavcodec use bytestream functions

Ramiro Ribeiro Polla ramiro
Wed May 23 17:51:46 CEST 2007


Michael Niedermayer wrote:
> Hi
>
> On Wed, May 09, 2007 at 08:37:22PM -0300, Ramiro Ribeiro Polla wrote:
>   
>> Michael Niedermayer wrote:
>>     
>>> Hi
>>>
>>> On Fri, Mar 16, 2007 at 01:45:52AM -0300, Ramiro Polla wrote:
>>>   
>>>       
>>>> Hello,
>>>>
>>>> Attached patches (one per file) make libavcodec use bytestream functions 
>>>> and AV_[RW]xx macros.
>>>>
>>>> It might be a good idea to cat the final reviewed patches and commit as 
>>>> one patch, or else there'll be a big ammount of commits...
>>>>
>>>> Regression tests succeeded.
>>>>     
>>>>         
>>> patches look ok
>>>
>>>   
>>>       
>> What's the best way to apply these patches?
>> 1 one big patch
>> 2 one for each file
>> 3 one for each kind of modification for each file
>> 4 one for each kind of modification for the whole libavcodec
>>     
>
> i prefer 4.
>
>   

Applied removal of duplicate bytestream functions.

Anyone care to triple check attached patch before I commit it?

You once said to not hide *dst++ in {get,put}_byte() functions. Should I 
go through and also remove those?
(or even remove bytestream_{get,put}_byte)

Ramiro Polla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: av_rw.diff
Type: text/x-patch
Size: 19071 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070523/971e454d/attachment.bin>



More information about the ffmpeg-devel mailing list