[FFmpeg-devel] [PATCH] Coremake support - ffmpeg_nommx.patch (1/1) - ffmpeg-nommx.patch (1/1)

[Ronald S. Bultje]

Hi,

In article <20070521171340.GK16391 at MichaelsNB>,
 Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, May 21, 2007 at 09:40:19AM -0400, Ronald S. Bultje wrote:
> > dsptest in tests/ and cputest in lavc/i386/ can't be compiled, since 
> > they use internaly API (dsptest is about ten pages of warnings, so 
> > nevermind there), cputest is below:
> > 
> > cputest.c: In function 'mm_support':
> > cputest.c:83: error: 'MM_MMX' undeclared (first use in this function)
> > cputest.c:83: error: (Each undeclared identifier is reported only once
> > cputest.c:83: error: for each function it appears in.)
> > cputest.c:85: error: 'MM_MMXEXT' undeclared (first use in this function)
> > cputest.c:85: error: 'MM_SSE' undeclared (first use in this function)
> > cputest.c:87: error: 'MM_SSE2' undeclared (first use in this function)
> > cputest.c:89: error: 'MM_SSE3' undeclared (first use in this function)
> > cputest.c:91: error: 'MM_SSSE3' undeclared (first use in this function)
> > cputest.c:99: error: 'MM_3DNOW' undeclared (first use in this function)
> > cputest.c:101: error: 'MM_3DNOWEXT' undeclared (first use in this 
> > function)
> 
> this should be useing FF_MM_MMX and similar

There's a small problem there, avcodec.h defines those if HAVE_MMX is 
defined, which is in config.h. config.h is only included if 
HAVE_AV_CONFIG_H is defined (in libavutil/common.h). This is actually a 
larger problem, since an installed ffmpeg would lose the config.h and 
thus apps would need to manually check whether their ffmpeg lib is 
compiled with MMX to be able to use any of this API. It (FF_MM_*) should 
either be moved out of avcodec.h and re-privatized, or parts of config.h 
should be moved to an installed ffconfig.h or so.

Also, SS/SSSE3 are missing in the FF_MM_* list in avcodec.h, but that's 
less of an issue (anyone want to apply the obvious patch?).

Ronald