[FFmpeg-devel] [PATCH] Split H.261into separate encoder and decoder

[Michael Niedermayer]

Hi

On Mon, May 21, 2007 at 02:45:47PM +0200, Aurelien Jacobs wrote:
> On Mon, 21 May 2007 14:33:57 +0200
> Michael Niedermayer <michaelni at gmx.at> wrote:
[...]
> > -    MPV_common_end(s);
> > -    return 0;
> > -}
> > -
> >  #ifdef CONFIG_ENCODERS
> >  AVCodec h261_encoder = {
> >      "h261",
> > @@ -978,14 +334,3 @@
> >  };
> >  #endif
> >  
> > -AVCodec h261_decoder = {
> > -    "h261",
> 
> The #ifdef CONFIG_ENCODERS is not useful anymore.

agree


> 
> Also another remarks:
> 
> > --- libavcodec/Makefile	(revision 9088)
> > +++ libavcodec/Makefile	(working copy)
> > @@ -83,8 +83,8 @@
> >  OBJS-$(CONFIG_FRAPS_DECODER)           += fraps.o
> >  OBJS-$(CONFIG_GIF_DECODER)             += gifdec.o lzw.o
> >  OBJS-$(CONFIG_GIF_ENCODER)             += gif.o
> > -OBJS-$(CONFIG_H261_DECODER)            += h261.o
> > -OBJS-$(CONFIG_H261_ENCODER)            += h261.o
> > +OBJS-$(CONFIG_H261_DECODER)            += h261.o h261dec.o
> > +OBJS-$(CONFIG_H261_ENCODER)            += h261.o h261enc.o
> 
> I prefer seeing h261.o after h261dec.o and after h261enc.o, but
> that's purely cosmetics and only my personnal feeling so that
> don't matter much.

iam fine with either unless some linker on some system has problems with
one of them ...


> 
> I didn't had a deep look at the patch, but it looks mostly ok.

i didnt had a deep look on it either but considering the number of
removed and inserted lines of the second diffstat it looked like its
well split

PS: thanks for reviewing, the more people review patches the better ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070521/b6dcc6e1/attachment.pgp>