[FFmpeg-devel] [PATCH] FF_ARRAY_SIZE()

[Michael Niedermayer]

Hi

On Sat, May 19, 2007 at 06:49:35PM +0200, Aurelien Jacobs wrote:
> On Sat, 19 May 2007 17:55:05 +0200
> Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> 
> > Hello,
> > On Sat, May 19, 2007 at 05:48:06PM +0200, Aurelien Jacobs wrote:
> > > The attached patch adds a FF_ARRAY_SIZE() macro and uses it everywhere.
> > > I think it's cleaner this way.
> > > Ok to apply ?
> > 
> > > +#define FF_ARRAY_SIZE(a)  (sizeof(a)/sizeof(*a))
> > > +#define FF_ARRAY_SIZE2(a) (sizeof(a)/sizeof(**a))
> > 
> > IMO please think of a proper name for FF_ARRAY_SIZE2, the name is not at
> > all descriptive.
> 
> Ok, maybe FF_ARRAY_2D_SIZE would be better ?
> (patch attached)

iam mildly against these patches, they make it more difficult for a
developer who isnt used to ffmpeg code to understand it ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070519/293556a1/attachment.pgp>