[FFmpeg-devel] [PATCH] RoQ muxer

[Michael Niedermayer]

Hi

On Mon, May 07, 2007 at 10:12:05PM +0200, Vitor wrote:
> Michael Niedermayer wrote:
> > this sounds all fairly fragile, are you sure simple plain per dts
> > interleaving doesnt work?
> > also what about simple dts interleaving with subtracting a constant
> > of the dts of all audio packets?
> >   
> Actually, I don't have Quake 3, so I can't verify if it really is so 
> sensible to the frame interleaving...

that is a problem


> The original's author comment says 
> so, and the format description in Tim Ferguson page specifies that 
> order. 

the idroq.txt file shows in an example that audio packets and video
packets are interleaved together one after one but your code does not produce
this it rather omits audio packets if it received 2 consecutive video packets
after dts ordering, this is very odd
also its just a example diagram in idroq.txt ive not found any mentioning
of this interleaving requirement in the actual text


> If this order is really necessary, I don't think that just dts 
> interleaving (even subtracting a constant of the dts audio packets) will 
> be enough to assure a proper packet ordering.

what is proper packet ordering for roq?

blind 1 audio + 1 video is almost certainly wrong, just think of the case that
the duration of the audio and video packets missmatch
and if they match then how does your code differ from dts ordering + constant?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070507/7e2191c5/attachment.pgp>