[FFmpeg-devel] [Ffmpeg-devel] [PATCH] FAAC profile selection

Benoit Fouet benoit.fouet
Wed May 2 15:49:34 CEST 2007


Michael Niedermayer wrote:
> Hi
>
> On Sun, Apr 29, 2007 at 12:53:03PM +0200, Nicolas George wrote:
>   
>> Le nonidi 9 flor?al, an CCXV, Michael Niedermayer a ?crit :
>>     
>>> iam not disagreeing with your argumentation but i prefer the simplest/most
>>> minimal code which gets the job done optimally and theres no real gain with
>>> the #ifdef IMHO
>>>
>>> also various other parts of AVOption are not under #ifdef
>>> i mean arithmetic coding, the various mpeg4 options, ...
>>> and if they all where under ifdefs the AVOption list would contain 3 times
>>> more ifdefs then actual code ...
>>>       
>> That is quite convincing indeed. Here is an updated version of the patch to
>> take your remarks into account.
>>     
>
> looks ok
>
> [...]
>   
>   
applied

Ben
-- 
Purple Labs S.A.
www.purplelabs.com




More information about the ffmpeg-devel mailing list