[FFmpeg-cvslog] tests/checkasm: fix wrong summation of bench time

Niklas Haas git at videolan.org
Mon Mar 31 16:27:31 EEST 2025


ffmpeg | branch: master | Niklas Haas <git at haasn.dev> | Mon Mar 31 14:40:16 2025 +0200| [256a38101fd1bc26b020b870a202fd638616a0a6] | committer: Niklas Haas

tests/checkasm: fix wrong summation of bench time

This was changed 8 years ago with the introduction of the linux-perf path,
with seemingly no justification at the time. Likely a developer oversight
from testing.

This bug not only made --runs completely ineffective, but also meant that we
didn't actually correctly filter out outliers.

Fixes: e0d56f097f42bcdbe6c3b2f57df62a4da63f2094

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=256a38101fd1bc26b020b870a202fd638616a0a6
---

 tests/checkasm/checkasm.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/checkasm/checkasm.h b/tests/checkasm/checkasm.h
index 75c81317ba..131e71c56e 100644
--- a/tests/checkasm/checkasm.h
+++ b/tests/checkasm/checkasm.h
@@ -364,8 +364,8 @@ typedef struct CheckasmPerf {
                 }\
             }\
             emms_c();\
-            perf->cycles += t;\
-            perf->iterations++;\
+            perf->cycles += tsum;\
+            perf->iterations += tcount;\
             checkasm_set_signal_handler_state(0);\
         }\
     } while (0)



More information about the ffmpeg-cvslog mailing list