[FFmpeg-cvslog] avcodec/osq: avoid undefined negation

Michael Niedermayer git at videolan.org
Thu Apr 10 04:13:18 EEST 2025


ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Tue Feb  4 03:58:45 2025 +0100| [c6a889f3e09249d2a643a6beb7d44a8e42ea3541] | committer: Michael Niedermayer

avcodec/osq: avoid undefined negation

Fixes: negation of -2147483648 cannot be represented in type 'int32_t' (aka 'int'); cast to an unsigned type to negate this value to itself
Fixes: 390646659/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-5040277374435328

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=c6a889f3e09249d2a643a6beb7d44a8e42ea3541
---

 libavcodec/osq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/osq.c b/libavcodec/osq.c
index 4cd9984ee0..1e94a486e9 100644
--- a/libavcodec/osq.c
+++ b/libavcodec/osq.c
@@ -190,7 +190,7 @@ static uint32_t get_urice(GetBitContext *gb, int k)
 
 static int32_t get_srice(GetBitContext *gb, int x)
 {
-    int32_t y = get_urice(gb, x);
+    uint32_t y = get_urice(gb, x);
     return get_bits1(gb) ? -y : y;
 }
 



More information about the ffmpeg-cvslog mailing list