[FFmpeg-cvslog] lavfi/concat: prefer av_asprintf() over stack allocated buffer.
Clément Bœsch
git at videolan.org
Thu Nov 29 12:57:55 CET 2012
ffmpeg | branch: master | Clément Bœsch <ubitux at gmail.com> | Thu Nov 29 12:25:02 2012 +0100| [a7eabbb20dc077d7380f874b9c35fffa478186a6] | committer: Clément Bœsch
lavfi/concat: prefer av_asprintf() over stack allocated buffer.
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=a7eabbb20dc077d7380f874b9c35fffa478186a6
---
libavfilter/avf_concat.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/libavfilter/avf_concat.c b/libavfilter/avf_concat.c
index eb13282..6be2c53 100644
--- a/libavfilter/avf_concat.c
+++ b/libavfilter/avf_concat.c
@@ -24,6 +24,7 @@
*/
#include "libavutil/avassert.h"
+#include "libavutil/avstring.h"
#include "libavutil/channel_layout.h"
#include "libavutil/opt.h"
#include "avfilter.h"
@@ -344,7 +345,6 @@ static av_cold int init(AVFilterContext *ctx, const char *args)
ConcatContext *cat = ctx->priv;
int ret;
unsigned seg, type, str;
- char name[32];
cat->class = &concat_class;
av_opt_set_defaults(cat);
@@ -365,8 +365,7 @@ static av_cold int init(AVFilterContext *ctx, const char *args)
.get_audio_buffer = get_audio_buffer,
.filter_frame = filter_frame,
};
- snprintf(name, sizeof(name), "in%d:%c%d", seg, "va"[type], str);
- pad.name = av_strdup(name);
+ pad.name = av_asprintf("in%d:%c%d", seg, "va"[type], str);
ff_insert_inpad(ctx, ctx->nb_inputs, &pad);
}
}
@@ -379,8 +378,7 @@ static av_cold int init(AVFilterContext *ctx, const char *args)
.config_props = config_output,
.request_frame = request_frame,
};
- snprintf(name, sizeof(name), "out:%c%d", "va"[type], str);
- pad.name = av_strdup(name);
+ pad.name = av_asprintf("out:%c%d", "va"[type], str);
ff_insert_outpad(ctx, ctx->nb_outputs, &pad);
}
}
More information about the ffmpeg-cvslog
mailing list