[FFmpeg-cvslog] ffmpeg: complain loudly and exit in case removed -sameq option is specified

Stefano Sabatini git at videolan.org
Sat Nov 3 13:09:51 CET 2012


ffmpeg | branch: master | Stefano Sabatini <stefasab at gmail.com> | Fri Nov  2 12:57:15 2012 +0100| [a62242678ff96eade59960d1bbf65e4f3f03344f] | committer: Stefano Sabatini

ffmpeg: complain loudly and exit in case removed -sameq option is specified

This is better than silently ignoring the option, which results in
unexpected quality results.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=a62242678ff96eade59960d1bbf65e4f3f03344f
---

 ffmpeg_opt.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/ffmpeg_opt.c b/ffmpeg_opt.c
index adf40f2..8fdb4cb 100644
--- a/ffmpeg_opt.c
+++ b/ffmpeg_opt.c
@@ -159,8 +159,11 @@ static int opt_pad(void *optctx, const char *opt, const char *arg)
 
 static int opt_sameq(void *optctx, const char *opt, const char *arg)
 {
-    av_log(NULL, AV_LOG_WARNING, "Ignoring option '%s'\n", opt);
-    return 0;
+    av_log(NULL, AV_LOG_ERROR, "Option '%s' was removed. "
+           "If you are looking for an option to preserve the quality (which is not "
+           "what -%s was for), use -qscale 0 or an equivalent quality factor option.\n",
+           opt, opt);
+    return AVERROR(EINVAL);
 }
 
 static int opt_video_channel(void *optctx, const char *opt, const char *arg)



More information about the ffmpeg-cvslog mailing list