[DVDnav-discuss] [PATCH][libdvdread] remove needless _LIBC checks from libdvdread

Erik Auerswald auerswal at unix-ag.uni-kl.de
Sat Feb 9 22:18:50 CET 2013


Hi,

the first attached patch removes preprocessor checks for _LIBC, because 
libdvdread is not GNU Libc and does never #define _LIBC.

The compiled objects stay the same (checked with md5sum (without 
debugging info: ./configure2 --disable-debug)).

I have tested this patch (that is, the md5.[ch] changes) with MPlayer 
from svn as well, works the same as before.

I did not re-indent the nested #if construct in the 2nd and 3rd hunks of 
the src/md5.h changes to ease review. This should be done after applying 
this patch. You can use the second attached patch to do this (use patch 
-p1).

Applying this patch results in cleaner code, which should help in 
maintaining it. Additionally, a -Wundef warning in MPlayer (from svn) 
compilation is fixed.

This is a more comprehensive than my first proposed patch (see 
http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2013-January/001862.html) 
and replaces it.

Thanks,
Erik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libdvdread-is_not_glibc-remove__LIBC_checks.patch
Type: text/x-diff
Size: 4462 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20130209/bdf00d6c/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libdvdread-is_not_glibc-remove__LIBC_checks-re-indentation.patch
Type: text/x-diff
Size: 1577 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20130209/bdf00d6c/attachment-0001.bin>


More information about the DVDnav-discuss mailing list