[DVDnav-discuss] [PATCH] "dvdnav_jump_to_sector" as an alternative to "dvdnav_time_search" (REV 6: add mode argument)

[gnosygnu]

Hi. Sorry for the late reply. I've been checking email very sporadically.

> As a small nit,
> maybe return DVDNAV_STATUS_ERR instead of NULL on failure.
>
> and use
>
> int32_t result = DVDNAV_STATUS_OK;
>
> instead of
> int32_t result = 0;

Thanks. You are completely correct. I should be using constants
instead of numbers I changed them accordingly in my version
    int32_t result = DVDNAV_STATUS_ERR;
    result = DVDNAV_STATUS_OK;

> Also maybe fail if they pass in anything besides 0 for the mode
> parameter of dvdnav_jump_to_sector_by_time.

Sure. I can add a "if (mode != 0) return DVDNAV_STATUS_ERR;" I'll
change the "!=0" to a constant later.

> Also would it be possible to ask for a write up some where (maybe on a
> wiki somewhere?) that describes the overall general process used? Like
> "you do this, then that".  It's so poorly documented on the web, it
> would be nice to get a brain dump.

I tried to describe as much in my initial email a year ago. See the
"Details" section in the following link:
http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/2011-November/001551.html

Feel free to let me know if anything needs specific clarification. If
you want it posted to a wiki, let me know where, and I'll document
accordingly.

For anyone else: I know this topic is a year old, and doesn't seem to
generate much interest outside of Roger (and Joakim). However, I would
like to get this patch accepted. It is working and addresses a current
limitation (cannot jump accurately to a specific time). Please let me
know what else I can do.

Thanks.