[DVDnav-discuss] [PATCH] fix dvdnav multi-cell menus

Erik Hovland erik at hovland.org
Wed Oct 19 19:17:29 CEST 2011


> Does the first change look correct to you, though (advancing to the next
> cell in this multi-cell menu case)?

It looks fine to me. How does it behave when it is the only patch to
the current release w/ other DVDs?

>> You are welcome to attach a patch that does the reindenting of the
>> if clause as a reformatting patch. Keeping them separate highlights
>> the fix you are trying to make. Then reformatting the code makes it
>> a little more readable.
>
> That is what I did, no?  Or, do you mean the reformatting patch should
> not also include the actual change?

My mistake. You did submit a reformatting patch.

Thanks

E

-- 
Erik Hovland
erik at hovland.org
http://hovland.org/


More information about the DVDnav-discuss mailing list