[DVDnav-discuss] Patch from the Living dead for dvdnav

Erik Hovland erik at hovland.org
Thu Nov 3 00:48:16 CET 2011


> Am I reading this cross-eyed or is this just totally stupid?
>
>       off = lseek( fd, 32 * (off_t) DVD_VIDEO_LB_LEN, SEEK_SET );
> -      if( off == ( 32 * (off_t) DVD_VIDEO_LB_LEN ) ) {
> +      if (off == 16) {
>
> unless lseek errors, off should always == 32 * DVD_VIDEO_LB_LEN and that new test should never succeed.

I was just reading and saying the same things to myself. If Jean
applies this I don't think it ever fires. Or lseek returns something
magical on OSX
and Windows.

I take it HandBrake does not apply this patch?

E

-- 
Erik Hovland
erik at hovland.org
http://hovland.org/


More information about the DVDnav-discuss mailing list