[DVDnav-discuss] dvdnav patches from handbrake project

[Jean-Baptiste Kempf]

On Fri, May 28, 2010 at 03:41:43PM +0200, Nico Sabbi wrote :
> I applied A00 that is obviously ok.
> A02: I don't know anything about win32, so if it works it can be applied  
> on the trust, but please explain the mismatch between MSC and WIN32
The win32 fix seems correct.

_MSVC means Microsoft Visual Studio Compiler.
_WIN32 is recognized by all Win32 compilers, including gcc, mingw and icc
It also works with Xcompilers.


Just as a side note, '/' is a valid DIR_SEP on Win32, not only '\\'

* Hence, I believe the if( strlen( path_copy ) > TITLES_MAX ) { could be
  rewritten in a nice way, sharing more code between the different
  platforms.

* GetDriveType, are you targetting A or W ?



Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/