[DVDnav-discuss] dvdnav patches from handbrake project

[John Stebbins]

On 07/18/2010 11:40 AM, Erik Hovland wrote:
>>> * nav-missing-menu-abort.patch
>>> This patch prevents an abort when a nav command tries to send you to a
>>> menu that doesn't exist.
>>> Mac the ripper's feature title extraction removes menus from the
>>> resulting image, but does not remove navigation instructions that
>>> attempt to jump to those  menus.  This patch checks that a menu exists
>>> before acting on such instructions.  If the menu does not exist, the it
>>> puts the vm into the stopped state.
>>>       
>> This has a high likelihood of being committed by me. I just have to get my
>> head around the error path handling.
>>     
> John,
>
> Is it possible to consolidate the valid pointer checks in vm_jump_menu? See
> the attached patch. I am probably going to break the original patch up
> into at least
> two different commits. Even though they treat the same problem they work in
> different functions.
>
> Thanks
>
>   
Sorry it took me so long to get back to you on this.  The patch you
proposed is incorrect.  The 2 cases are testing different things, so
they can't be consolidated. One tests:
      if(vm->vmgi == NULL || vm->vmgi->pgci_ut == NULL) {
and the other is:
      if(vm->vtsi == NULL || vm->vtsi->pgci_ut == NULL) {

I see that you've committed this change.  I'll include a reversion in my
updated patch (which I'm currently testing).