[DVDnav-discuss] [PATCH] crash while processing mac the ripper "feature title extract" images

[John Stebbins]

On 11/17/2009 04:19 PM, Erik Hovland wrote:
>> Mac the ripper's feature title extraction removes menus from the resulting
>> image, but does not remove navigation instructions that attempt to jump to
>> those menus.  This patch checks that a menu exists before acting on such
>> instructions.  If the menu does not exist, the it puts the vm into the
>> stopped state.
>>      
> I am not opposed to this patch. But in the first set the fail marker does
> the same thing as a success (return 0). Could the fail marker have a
> negative return value? If so, what effect does that have?
>
> E
>
>    
For that function success is this block:
     if(get_PGCIT(vm) && set_MENU(vm, menuid)) {
       process_command(vm, play_PGC(vm));
       return 1;  /* Jump */
     } else {

If it gets to the end of the function, it has failed.