[DVDnav-discuss] Fwd: Patch to add dvdnav_get_serial_string function to dvdnav

[Nico Sabbi]

> 
> 
> 
> ---------- Messaggio inoltrato ----------
> From: Matthew Wire <devel at mrwire.co.uk>
> To: dvdnav mailing list <dvdnav-discuss at mplayerhq.hu>
> Date: Wed, 28 Jan 2009 12:53:11 +0000
> Subject: [DVDnav-discuss] Patch to add dvdnav_get_serial_string
> function to dvdnav
> The attached patch adds a function to dvdnav to obtain the dvd serial
> number externally.
> 
> This is used in mythtv to generate a unique id for the disc for it's
> bookmarking code.
> 
> This is my first patch to dvdnav to please tell me if I'm doing things
> wrong etc.
> 
> Cheers,
> Matthew
> 

you broke the API extending an existing function for no reason; you
should add a new function and raise the minor number instead.
>