Author: hyc Date: Mon May 24 21:43:48 2010 New Revision: 484 Log: Just return 1 packet's worth of data at a time from RTMP_Read() Modified: trunk/librtmp/rtmp.c Modified: trunk/librtmp/rtmp.c ============================================================================== --- trunk/librtmp/rtmp.c Mon May 24 15:29:05 2010 (r483) +++ trunk/librtmp/rtmp.c Mon May 24 21:43:48 2010 (r484) @@ -4162,7 +4162,7 @@ fail: size -= nRead; } - while (size > 0 && (nRead = Read_1_Packet(r, buf, size)) >= 0) + if (size > 0 && (nRead = Read_1_Packet(r, buf, size)) >= 0) { buf += nRead; total += nRead;
Hi, This patch will cause ffmpeg with librtmp fail or segmentation fault. example command line: $ ffmpeg -i rtmp://server/live/livestream -acodec copy -vcodec copy -y test.flv On Tue, May 25, 2010 at 3:43 AM, hyc <subversion@mplayerhq.hu> wrote:
Author: hyc Date: Mon May 24 21:43:48 2010 New Revision: 484
Log: Just return 1 packet's worth of data at a time from RTMP_Read()
Modified: trunk/librtmp/rtmp.c
Modified: trunk/librtmp/rtmp.c
============================================================================== --- trunk/librtmp/rtmp.c Mon May 24 15:29:05 2010 (r483) +++ trunk/librtmp/rtmp.c Mon May 24 21:43:48 2010 (r484) @@ -4162,7 +4162,7 @@ fail: size -= nRead; }
- while (size > 0 && (nRead = Read_1_Packet(r, buf, size)) >= 0) + if (size > 0 && (nRead = Read_1_Packet(r, buf, size)) >= 0) { buf += nRead; total += nRead; _______________________________________________ rtmpdump mailing list rtmpdump@mplayerhq.hu https://lists.mplayerhq.hu/mailman/listinfo/rtmpdump
-- ------------------------------------------------------------ Yours trueice
trueice wrote:
Hi,
This patch will cause ffmpeg with librtmp fail or segmentation fault.
Impossible for this change to cause that. There is something else broken in your build environment.
example command line: $ ffmpeg -i rtmp://server/live/livestream -acodec copy -vcodec copy -y test.flv
The sample URLs you sent me before still work here. Note that since this is a live stream, you must use "rtmp://server/live/livstream live=1"
On Tue, May 25, 2010 at 3:43 AM, hyc <subversion@mplayerhq.hu <mailto:subversion@mplayerhq.hu>> wrote:
Author: hyc Date: Mon May 24 21:43:48 2010 New Revision: 484
Log: Just return 1 packet's worth of data at a time from RTMP_Read()
Modified: trunk/librtmp/rtmp.c
Modified: trunk/librtmp/rtmp.c ============================================================================== --- trunk/librtmp/rtmp.c Mon May 24 15:29:05 2010 (r483) +++ trunk/librtmp/rtmp.c Mon May 24 21:43:48 2010 (r484) @@ -4162,7 +4162,7 @@ fail: size -= nRead; }
- while (size > 0 && (nRead = Read_1_Packet(r, buf, size)) >= 0) + if (size > 0 && (nRead = Read_1_Packet(r, buf, size)) >= 0) { buf += nRead; total += nRead; _______________________________________________ rtmpdump mailing list rtmpdump@mplayerhq.hu <mailto:rtmpdump@mplayerhq.hu> https://lists.mplayerhq.hu/mailman/listinfo/rtmpdump
-- ------------------------------------------------------------ Yours trueice
_______________________________________________ rtmpdump mailing list rtmpdump@mplayerhq.hu https://lists.mplayerhq.hu/mailman/listinfo/rtmpdump
-- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
participants (3)
-
Howard Chu -
hyc -
trueice