Hi, It seems like the parseurl changes in r21 changed the behavior of slist parsing slightly, previously .flv wasn't stripped from the slist= param, but was from the URL. The attached patch puts it back to how it was. (Anyone have any clue if that matches what Flash actually does? I'm only going on something that worked before breaking against SVN, but maybe it got the URL wrong.)
Monsieur Video wrote:
Hi,
It seems like the parseurl changes in r21 changed the behavior of slist parsing slightly, previously .flv wasn't stripped from the slist= param, but was from the URL. The attached patch puts it back to how it was.
(Anyone have any clue if that matches what Flash actually does? I'm only going on something that worked before breaking against SVN, but maybe it got the URL wrong.)
Yeah, I just noticed that after r21 it was broken for me, hadn't figured out what the error was yet. Thanks for this.
-- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
Howard Chu wrote:
Monsieur Video wrote:
Hi,
It seems like the parseurl changes in r21 changed the behavior of slist parsing slightly, previously .flv wasn't stripped from the slist= param, but was from the URL. The attached patch puts it back to how it was.
(Anyone have any clue if that matches what Flash actually does? I'm only going on something that worked before breaking against SVN, but maybe it got the URL wrong.)
(And no, no idea. I haven't looked at any unencrypted rtmp streams lately.) By the way, get-flash-videos seems to do its own download size check and warn if it thinks it's incomplete, based on size/percentage. This is a bit redundant, since rtmpdump already checks for completion and returns RD_SUCCESS or RD_INCOMPLETE (or RD_FAILED). Probably should just test the exit status, if anything. Right now it's a bit confusing if a download comes in at e.g. 97% and rtmpdump gets the Play.Complete status, exits printing Download complete; and then get-flash-videos says "may be incomplete" ... -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
2009/11/7 Howard Chu <hyc@highlandsun.com>
By the way, get-flash-videos seems to do its own download size check and warn if it thinks it's incomplete, based on size/percentage. This is a bit redundant, since rtmpdump already checks for completion and returns RD_SUCCESS or RD_INCOMPLETE (or RD_FAILED). Probably should just test the exit status, if anything. Right now it's a bit confusing if a download comes in at e.g. 97% and rtmpdump gets the Play.Complete status, exits printing Download complete; and then get-flash-videos says "may be incomplete" ...
Yes, that would make sense. The main reason I didn't do that before was older versions of rtmpdump didn't return an exit status. Probably less of a problem now rtmpdump has a home ;) In gfv svn now (there's a bit of refactoring to the rtmpdump support that also adds flvstreamer support in the svn too).
participants (2)
-
Howard Chu -
Monsieur Video