[PATCH] rtmpsrv crashes when playpath is too long
Test page : http://mubi.com/films/the-new-environmentalists username : qodijnwoqfj@mailinator.com password : bugmenot detected playpath for above video is too long. rtmpsrv crashes when it tries to use it in SendPlayStart and SendPlayStop function. attached patch increases the buffer size from 512 bytes to 1024 bytes to avoid crashing.
On Sat, 8 Oct 2011 00:54:06 +0530 (IST), KSV wrote:
- char pbuf[512], *pend = pbuf+sizeof(pbuf); + char pbuf[1024], *pend = pbuf+sizeof(pbuf); - char pbuf[512], *pend = pbuf+sizeof(pbuf); + char pbuf[1024], *pend = pbuf+sizeof(pbuf);
is 1024 big enough? why not 2048 while you are at it?
________________________________ From: compn <tempn@twmi.rr.com> To: rtmpdump@mplayerhq.hu Sent: Saturday, 8 October 2011 7:35 AM Subject: Re: [rtmpdump] [PATCH] rtmpsrv crashes when playpath is too long is 1024 big enough? why not 2048 while you are at it? _______________________________________________ I haven't seen such long playpath string during my usage period. string length was 853 so i increased buffer size to 1024 on conservative basis. though increasing it to 2048 doesn't gonna hurt anyway.
participants (2)
-
compn -
KSV