October 2013 - rtmpdump - lists.mplayerhq.hu

[PATCH] Extended timestamp field may be present in type 3 chunk headers
by Martin Panter 03 Mar '14

03 Mar '14

>From c5a88e2ba458588b4b88a4e5b1411c9ee9c03afb Mon Sep 17 00:00:00 2001 From: Martin Panter <vadmium à gmail·com> Date: Wed, 18 Sep 2013 11:58:01 +1000 Subject: [PATCH] Extended timestamp field may be present in type 3 chunk headers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As described in Adobe’s RTMP specification dated 21 Dec 2012; also: * RTMPY ticket #107, “Compressed headers also can have an extended timestamp”, http://web.archive.org/web/20120624031323/http://dev.rtmpy.org/ticket/107 * https://rarut.wordpress.com/2012/03/21/announcing-nginx-rtmp-module/ This resolves intermittent hangs, segfaults and crashes I was seeing when starting ABC News 24 streams, e.g.: rtmpdump -r rtmp://cp81899.live.edgefcs.net/live/news24-med@28772 --live Some of the packets seemed to contain junk timestamp fields, which often required the extended field. --- Original in case G Mail messes this up: https://github.com/vadmium/rtmpdump/commit/c5a88e2.patch librtmp/rtmp.c | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/librtmp/rtmp.c b/librtmp/rtmp.c index 014ff8b..91ad27f 100644 --- a/librtmp/rtmp.c +++ b/librtmp/rtmp.c @@ -3573,6 +3573,7 @@ RTMP_ReadPacket(RTMP *r, RTMPPacket *packet) char *header = (char *)hbuf; int nSize, hSize, nToRead, nChunk; int didAlloc = FALSE; + int extendedTimestamp; RTMP_Log(RTMP_LOGDEBUG2, "%s: fd=%d", __FUNCTION__, r->m_sb.sb_socket); @@ -3675,17 +3676,19 @@ RTMP_ReadPacket(RTMP *r, RTMPPacket *packet) packet->m_nInfoField2 = DecodeInt32LE(header + 7); } } - if (packet->m_nTimeStamp == 0xffffff) + } + + extendedTimestamp = packet->m_nTimeStamp == 0xffffff; + if (extendedTimestamp) + { + if (ReadN(r, header + nSize, 4) != 4) { - if (ReadN(r, header + nSize, 4) != 4) - { - RTMP_Log(RTMP_LOGERROR, "%s, failed to read extended timestamp", - __FUNCTION__); - return FALSE; - } - packet->m_nTimeStamp = AMF_DecodeInt32(header + nSize); - hSize += 4; + RTMP_Log(RTMP_LOGERROR, "%s, failed to read extended timestamp", + __FUNCTION__); + return FALSE; } + packet->m_nTimeStamp = AMF_DecodeInt32(header + nSize); + hSize += 4; } RTMP_LogHexString(RTMP_LOGDEBUG2, (uint8_t *)hbuf, hSize); @@ -3730,6 +3733,10 @@ RTMP_ReadPacket(RTMP *r, RTMPPacket *packet) if (!r->m_vecChannelsIn[packet->m_nChannel]) r->m_vecChannelsIn[packet->m_nChannel] = malloc(sizeof(RTMPPacket)); memcpy(r->m_vecChannelsIn[packet->m_nChannel], packet, sizeof(RTMPPacket)); + if (extendedTimestamp) + { + r->m_vecChannelsIn[packet->m_nChannel]->m_nTimeStamp = 0xffffff; + } if (RTMPPacket_IsReady(packet)) { -- 1.8.3.4

2 4

Won't compile with Polarssl-1.3.1.
by bat guano 29 Oct '13

29 Oct '13

Hi RTMPDump still seems to build OK with old version of polarssl.(eg polarssl-1.1.4) But it won't build for me (using ARCH Linux) with latest version polarssl-1.3.1. Method used. ############################################## # cd ~/; mkdir build; cd build # curl -L polarssl.org/code/releases/polarssl-1.3.1-gpl.tgz | tar -xz; cd polarssl-* # make; make install DESTDIR=$HOME/build # cd .. # git clone --depth 1 git://git.ffmpeg.org/rtmpdump; cd rtmpdump # make install CRYPTO=POLARSSL SHARED= XLDFLAGS=-L$HOME/build/lib INC=-I$HOME/build/include prefix=$HOME/build # ############################################## Result. $ make install CRYPTO=POLARSSL SHARED= XLDFLAGS=-L$HOME/build/lib INC=-I$HOME/build/include prefix=$HOME/build gcc -Wall -I/home/user/build/include -DRTMPDUMP_VERSION=\"v2.4\" -O2 -c -o rtmpdump.o rtmpdump.c make[1]: Entering directory '/home/user/build/rtmpdump/librtmp' gcc -Wall -I/home/user/build/include -DRTMPDUMP_VERSION=\"v2.4\" -DUSE_POLARSSL -O2 -c -o rtmp.o rtmp.c In file included from rtmp.c:32:0: rtmp_sys.h:82:2: error: unknown type name ‘x509_cert’ x509_cert cert; ^ In file included from rtmp.c:150:0: handshake.h:28:27: fatal error: polarssl/sha2.h: No such file or directory #include <polarssl/sha2.h> ^ compilation terminated. <builtin>: recipe for target 'rtmp.o' failed make[1]: *** [rtmp.o] Error 1 make[1]: Leaving directory '/home/user/build/rtmpdump/librtmp' Makefile:76: recipe for target 'librtmp/librtmp.a' failed make: *** [librtmp/librtmp.a] Error 2 ##############################################

1 0

librtmp extend timestamp can't accept by FMS3.5/red5/crtmpserver ?
by VGAIC畅通-邱工 21 Oct '13

21 Oct '13

Dear Sir, I use librtmp to send rtmp packet to rtmp server(FMS3.5/red5/crtmpserver). The librtmp version is git from server(Mon Sep 23 22:45:29 2013 +0300). After I use librtmp to send 4.5 hours(time stampe is large 0xffffff)， then rtmp server will send "Netstream.unpublish.success". And I see the server log and found that librtmp's packet is can't accept. My app is rtmp live stream and the timestamp is from 0 40 80... to 0xffffff and forerver, but then I can only use 4.5 hours and again to connect the server. And I use this config to send h264 frame to the server: vpacket.m_hasAbsTimestamp = TRUE; vpacket.m_packetType = RTMP_PACKET_TYPE_VIDEO; vpacket.m_nChannel = 0x03; vpacket.m_headerType = RTMP_PACKET_SIZE_LARGE; vpacket.m_nTimeStamp = nTimeStamp; vpacket.m_nInfoField2 = rtmp->m_stream_id; vpacket.m_nBodySize = i + size; So, there is anyone to help me about this problem? Thanks. - Gongfen Qiu

2 1

bug in "Look for a fourth slash when splitting the url into app+playpath"
by compn 14 Oct '13

14 Oct '13

heres a bug reported to me on irc: "there is a bug in rtmpdump, which creates this problem https://bugs.launchpad.net/qarte/+bug/1100842 I've tracked this down to this changeset: https://github.com/svnpenn/rtmpdump/commit/f3e3e6b507ac0df89a11764abd15cc95… If this changeset is backed out, the bug goes away." -compn

2 1

Help with Stream
by Jorge Fábregas 09 Oct '13

09 Oct '13

Hi everyone, I've been happily using rtmpdump for years but recently the Radio Station I record changed its streaming technology and I can no longer capture the streams. The video stream is on the right side here: http://radioisla1320.com/ ...and this is the command line I'm using: $ rtmpdump --verbose -r "rtmpt://streams.streambound.com:80/mediapower/radioisla1" -W http://p.jwpcdn.com/6/4/jwplayer.flash.swf -p http://www.radioisla1320.com -o radio.flv RTMPDump v2.3 (c) 2010 Andrej Stepanchuk, Howard Chu, The Flvstreamer Team; license: GPL DEBUG: Parsing... DEBUG: Parsed protocol: 1 DEBUG: Parsed host : streams.streambound.com DEBUG: Parsed app : mediapower DEBUG: Protocol : RTMPT DEBUG: Hostname : streams.streambound.com DEBUG: Port : 80 DEBUG: Playpath : radioisla1 DEBUG: tcUrl : rtmpt://streams.streambound.com:80/mediapower DEBUG: swfUrl : http://p.jwpcdn.com/6/4/jwplayer.flash.swf DEBUG: pageUrl : http://www.radioisla1320.com DEBUG: app : mediapower DEBUG: live : no DEBUG: timeout : 30 sec DEBUG: SWFSHA256: DEBUG: 4c dd 8c fe 69 76 47 e4 02 b0 fe a0 b9 53 22 18 DEBUG: ea a4 e3 a9 7d 2a 05 b2 7e 3b 75 8a 5b 35 44 55 DEBUG: SWFSize : 272033 DEBUG: Setting buffer time to: 36000000ms Connecting ... DEBUG: RTMP_Connect1, ... connected, handshaking DEBUG: HandShake: Client type: 03 DEBUG: HandShake: Client digest offset: 430 DEBUG: HandShake: Initial client digest: DEBUG: 1d 04 6d 79 a2 c1 55 5b a0 0f 72 69 8f cf 2c 20 DEBUG: 0f 8d 9c 96 72 c1 49 22 bf ad 01 b8 89 54 fc d4 ...and it stays there (radio.flv is empty). Any hint would be appreciated! Thanks, Jorge

1 1