November 2009 - rtmpdump - lists.mplayerhq.hu

r57 - parseurl.c rtmp.h
by hyc 24 Nov '09

24 Nov '09

Author: hyc Date: Tue Nov 24 00:48:22 2009 New Revision: 57 Log: remove 'not yet supported' comment for rtmpe Modified: parseurl.c rtmp.h Modified: parseurl.c ============================================================================== --- parseurl.c Sun Nov 22 23:08:35 2009 (r56) +++ parseurl.c Tue Nov 24 00:48:22 2009 (r57) @@ -32,7 +32,7 @@ #define RTMP_PROTOCOL_RTMP 0 #define RTMP_PROTOCOL_RTMPT 1 // not yet supported #define RTMP_PROTOCOL_RTMPS 2 // not yet supported -#define RTMP_PROTOCOL_RTMPE 3 // not yet supported +#define RTMP_PROTOCOL_RTMPE 3 #define RTMP_PROTOCOL_RTMPTE 4 // not yet supported #define RTMP_PROTOCOL_RTMFP 5 // not yet supported Modified: rtmp.h ============================================================================== --- rtmp.h Sun Nov 22 23:08:35 2009 (r56) +++ rtmp.h Tue Nov 24 00:48:22 2009 (r57) @@ -51,7 +51,7 @@ #define RTMP_PROTOCOL_RTMP 0 #define RTMP_PROTOCOL_RTMPT 1 // not yet supported #define RTMP_PROTOCOL_RTMPS 2 // not yet supported -#define RTMP_PROTOCOL_RTMPE 3 // not yet supported +#define RTMP_PROTOCOL_RTMPE 3 #define RTMP_PROTOCOL_RTMPTE 4 // not yet supported #define RTMP_PROTOCOL_RTMFP 5 // not yet supported

1 0

Fix to compile rtmpdump v 1.9 on Mac OSX 10.6 Snow Leopard
by Tom Selgas 22 Nov '09

22 Nov '09

To compile rtmpdump v 1.9 on Mac OSX 10.6 Snow Leopard you will need to do the following: 1) Install Xcode 3.2 from the Snow Leopard Installation DVD 2) Edit the "streams.cpp" file in the "rtmpdump-1.9" folder by replacing all (two) occurrences of "MSG_NOSIGNAL" with "SO_NOSIGPIPE". Tom Selgas Mobile: 972-333-3817 This e-mail is intended ONLY for the recipient to whom it was sent by Thomas Selgas. PLEASE DO NOT FORWARD THIS MESSAGE WITHOUT THE EXPRESS CONSENT OF THOMAS SELGAS.

2 1

r56 - streams.cpp
by hyc 22 Nov '09

22 Nov '09

Author: hyc Date: Sun Nov 22 23:08:35 2009 New Revision: 56 Log: Just ignore SIGPIPE, MSG_NOSIGNAL is Linux-specific Modified: streams.cpp Modified: streams.cpp ============================================================================== --- streams.cpp Fri Nov 20 20:03:20 2009 (r55) +++ streams.cpp Sun Nov 22 23:08:35 2009 (r56) @@ -661,7 +661,7 @@ void processTCPrequest // write FLV header first nRead = WriteHeader(&buffer, PACKET_SIZE); if(nRead > 0) { - nWritten = send(sockfd, buffer, nRead, MSG_NOSIGNAL); + nWritten = send(sockfd, buffer, nRead, 0); if(nWritten < 0) { Log(LOGERROR, "%s, sending failed, error: %d", __FUNCTION__, GetSockError()); goto cleanup; // we are in STREAMING_IN_PROGRESS, so we'll go to STREAMING_ACCEPTING @@ -680,7 +680,7 @@ void processTCPrequest if(nRead > 0) { - nWritten = send(sockfd, buffer, nRead, MSG_NOSIGNAL); + nWritten = send(sockfd, buffer, nRead, 0); //Log(LOGDEBUG, "written: %d", nWritten); if(nWritten < 0) { Log(LOGERROR, "%s, sending failed, error: %d", __FUNCTION__, GetSockError()); @@ -1025,6 +1025,7 @@ int main(int argc, char **argv) }; signal(SIGINT, sigIntHandler); + signal(SIGPIPE, SIG_IGN); while((opt = getopt_long(argc, argv, "hvqVzr:s:t:p:a:f:u:n:c:l:y:m:d:D:A:B:g:w:x:", longopts, NULL)) != -1) { switch(opt) {

1 0

rpm spec file for rtmpdump
by Itamar Reis Peixoto 22 Nov '09

22 Nov '09

Can you include this spec file in rtmpdump ? it's compatible with fedora, centos and rhel , probably others too. -- ------------ Itamar Reis Peixoto e-mail/msn/google talk/sip: itamar(a)ispbrasil.com.br skype: itamarjp icq: 81053601 +55 11 4063 5033 +55 34 3221 8599

1 0

r55 - rtmp.cpp rtmpdump.cpp
by hyc 20 Nov '09

20 Nov '09

Author: hyc Date: Fri Nov 20 20:03:20 2009 New Revision: 55 Log: flvstreamer bug#107134 stop streaming for onFCUnsubscribe Modified: rtmp.cpp rtmpdump.cpp Modified: rtmp.cpp ============================================================================== --- rtmp.cpp Fri Nov 20 19:43:45 2009 (r54) +++ rtmp.cpp Fri Nov 20 20:03:20 2009 (r55) @@ -1151,6 +1151,11 @@ int CRTMP::HandleInvoke(const char *body { // SendOnFCSubscribe(); } + else if (CSCMP(method,"onFCUnsubscribe")) + { + Close(); + return 1; + } else if (CSCMP(method,"_onbwcheck")) { SendCheckBWResult(txn); Modified: rtmpdump.cpp ============================================================================== --- rtmpdump.cpp Fri Nov 20 19:43:45 2009 (r54) +++ rtmpdump.cpp Fri Nov 20 20:03:20 2009 (r55) @@ -158,6 +158,12 @@ int WriteStream( char *packetBody = packet.m_body; unsigned int nPacketLen = packet.m_nBodySize; + // Return -3 if this was completed nicely with invoke message Play.Stop or Play.Complete + if (rtnGetNextMediaPacket == 2) { + Log(LOGDEBUG, "Got Play.Complete or Play.Stop from server. Assuming stream is complete"); + return -3; + } + // skip video info/command packets if(packet.m_packetType == 0x09 && nPacketLen == 2 && @@ -432,11 +438,6 @@ stopKeyframeSearch: if(tsm) *tsm = bLiveStream ? packet.m_nTimeStamp : nTimeStamp; - // Return -3 if this was completed nicely with invoke message Play.Stop or Play.Complete - if (rtnGetNextMediaPacket == 2) { - Log(LOGDEBUG, "Got Play.Complete or Play.Stop from server. Assuming stream is complete"); - return -3; - } return size; }

1 0

r54 - rtmpdump.cpp
by hyc 20 Nov '09

20 Nov '09

Author: hyc Date: Fri Nov 20 19:43:45 2009 New Revision: 54 Log: flvstreamer bug#107134, don't retry live streams Modified: rtmpdump.cpp Modified: rtmpdump.cpp ============================================================================== --- rtmpdump.cpp Sun Nov 15 22:56:50 2009 (r53) +++ rtmpdump.cpp Fri Nov 20 19:43:45 2009 (r54) @@ -1366,7 +1366,7 @@ int main(int argc, char **argv) /* If we succeeded, we're done. */ - if (nStatus != RD_INCOMPLETE || !rtmp->IsTimedout()) + if (nStatus != RD_INCOMPLETE || !rtmp->IsTimedout() || bLiveStream) break; }

1 0

Issue with brightcove and auth param
by Monsieur Video 16 Nov '09

16 Nov '09

Hi, There seems to be an issue with Brightcove with rtmpdump 1.9, the following fixes it: --- rtmp.cpp (revision 52) +++ rtmp.cpp (working copy) @@ -766,8 +766,8 @@ // add auth string if(Link.auth) { -// *enc = 0x01; enc++; -// *enc = 0x01; enc++; + *enc = 0x01; enc++; + *enc = 0x01; enc++; enc += EncodeString(enc, Link.auth); } Any idea why that was commented out to start with? (seems to be right back in r12)

3 2

r53 - rtmp.cpp
by hyc 15 Nov '09

15 Nov '09

Author: hyc Date: Sun Nov 15 22:56:50 2009 New Revision: 53 Log: Fix auth encoding, partial revert of r12 Modified: rtmp.cpp Modified: rtmp.cpp ============================================================================== --- rtmp.cpp Sat Nov 14 01:44:04 2009 (r52) +++ rtmp.cpp Sun Nov 15 22:56:50 2009 (r53) @@ -766,8 +766,8 @@ bool CRTMP::SendConnectPacket() // add auth string if(Link.auth) { -// *enc = 0x01; enc++; -// *enc = 0x01; enc++; + *enc = 0x01; enc++; + *enc = 0x01; enc++; enc += EncodeString(enc, Link.auth); }

1 0

bug: RTMPDump v1.9 (as of 15/11/2009) connection timeout param ignored
by Tom Shaw 15 Nov '09

15 Nov '09

Hey, It seems that the connection timeout is ignored. In fact even 120secs the default is not honoured. It takes 3 minutes and 10secs for the connection to time out regardless of the setting I use in my command line. This is the error message when it finally does. Connecting ... ERROR: Connect, failed to connect socket. 110 (Connection timed out) DEBUG: Closing connection. Cheers, Tom

2 2

/etc/hosts ignored by rtmp dump
by Tom Shaw 15 Nov '09

15 Nov '09

It seems that rtmpdump v1.9 ignores my /etc/hosts file. When I use ping (for example) my hostnames are correctly resolved. Any ideas on why this should happen, and how to fix it? Cheers, Tom

1 0