Hi see attached -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many things microsoft did are stupid, but not doing something just because microsoft did it is even more stupid. If everything ms did were stupid they would be bankrupt already.
Michael Niedermayer wrote:
The ID values used are the same as in AVI, so if a codec uses a specific FourCC in AVI then the same FourCC MUST be used here. + For raw video and audio, the used sample format (signed/unsigned, + 8/16/32bit, big/little endian, rgb/yuv) is indicated by the fourcc.
24-bit audio (i.e., not padded to 32 bits) might make sense. AVI has separate FourCCs for raw video formats but not for raw audio formats. I guess the intention is to use the MOV codes in these cases? Regards, Clemens
Clemens Ladisch wrote:
Michael Niedermayer wrote:
The ID values used are the same as in AVI, so if a codec uses a specific FourCC in AVI then the same FourCC MUST be used here. + For raw video and audio, the used sample format (signed/unsigned, + 8/16/32bit, big/little endian, rgb/yuv) is indicated by the fourcc.
24-bit audio (i.e., not padded to 32 bits) might make sense.
AVI has separate FourCCs for raw video formats but not for raw audio formats. I guess the intention is to use the MOV codes in these cases?
I stand by my opinions on fourccs, previously discussed at length. -- Måns Rullgård mans@mansr.com
On Tue, Feb 12, 2008 at 03:03:39PM +0100, Clemens Ladisch wrote:
Michael Niedermayer wrote:
The ID values used are the same as in AVI, so if a codec uses a specific FourCC in AVI then the same FourCC MUST be used here. + For raw video and audio, the used sample format (signed/unsigned, + 8/16/32bit, big/little endian, rgb/yuv) is indicated by the fourcc.
24-bit audio (i.e., not padded to 32 bits) might make sense.
There is nothing in this patch that precludes 24 or even 123bit audio. it does just list by examples what the fourcc specifies.
AVI has separate FourCCs for raw video formats but not for raw audio formats. I guess the intention is to use the MOV codes in these cases?
You take a few steps too far. First we need to decide what the fourcc for raw audio does specify. Then we can decide if the ones from mov are an appropriate choice. [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are too smart to engage in politics are punished by being governed by those who are dumber. -- Plato
On Tue, Feb 12, 2008 at 03:34:23PM +0100, Michael Niedermayer wrote: [...]
AVI has separate FourCCs for raw video formats but not for raw audio formats. I guess the intention is to use the MOV codes in these cases?
You take a few steps too far. First we need to decide what the fourcc for raw audio does specify. Then we can decide if the ones from mov are an appropriate choice.
And as mov uses "sowt" for both 8bit and 16bit the awnser to your question is likely "no, we cant use the mov fourccs here" [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable
On Tue, Feb 12, 2008 at 02:07:20PM +0100, Michael Niedermayer wrote:
Hi
see attached
What about this? Any comments, alternative suggestions? objections? mans, is your comment about fourccs a objection? If so what do you suggest to identify the needed things for raw video/audio. If there are no objections then ill commit in 48h. [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unrelated to the bug with no further explanation, that is a good sign that the bugfix is wrong.
Michael Niedermayer <michaelni@gmx.at> writes:
On Tue, Feb 12, 2008 at 02:07:20PM +0100, Michael Niedermayer wrote:
Hi
see attached
What about this?
Any comments, alternative suggestions? objections? mans, is your comment about fourccs a objection? If so what do you suggest to identify the needed things for raw video/audio.
The diff is fine, provided those fourccs are actually specified somewhere. It's the deferring of codec tag definitions to some ill-defined AVI common practice I dislike. But we've had that discussion already... -- Måns Rullgård mans@mansr.com
On Sun, Feb 17, 2008 at 04:05:11AM +0000, Måns Rullgård wrote:
Michael Niedermayer <michaelni@gmx.at> writes:
On Tue, Feb 12, 2008 at 02:07:20PM +0100, Michael Niedermayer wrote:
Hi
see attached
What about this?
Any comments, alternative suggestions? objections? mans, is your comment about fourccs a objection? If so what do you suggest to identify the needed things for raw video/audio.
The diff is fine, provided those fourccs are actually specified somewhere.
nut4cc.txt should do that. [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualities wherein our enemies excel us and endeavor to excel them, by avoiding what is faulty, and imitating what is excellent in them. -- Plutarch
participants (3)
-
Clemens Ladisch -
Michael Niedermayer -
Måns Rullgård