Hi On Sat, Nov 25, 2006 at 01:38:39PM -0500, Rich Felker wrote: [...]
The only other possibilities are to give up on your correct seeking with subtitles (which you seemed to want the most of any of us) or throw in thousands of fake empty keyframes.
yes, ~1000 small (<10byte) keyframes whos position in time matches the video keyframes would be the correct solution, needing 10kb for 2 hours is negligible its a mere ~ 0.01 kbit/sec
It's not correct! To do this the muxer has to manufacture data as
my sugestion was not to make the muxer inject new frames but rather that you cannot seek to points where there are no keyframes (this is pretty much how things normally behave, ignoring subtitles ...) with gaps/EOR OTOH its possible to seek to keyframes and gaps but if so why disallow it for non subtitle streams? what extra computations would be needed on the demuxer side for non subtitle EOR? (a muxer could always choose not to support EOR)
well! It also means seeking will be _incorrect_, in the sense that if you disable video and just enable audio and subs, seeks will go farther back than they need to in order to find the _useless_ blank subtitle.
which will cause a few milliseconds of useless computations after a seek
PLEASE for the love of [insert deity here] stop bringing up old issues now; it's too late. It's easy to complain about these things now 1.5-2 years later when everyone's forgotten why the decisions were made the way they were and why they're essential to correct operation, but that doesn't mean we should go through the same process again now only to rediscover the same thing. :(
its a bad sign if you need to think about something for days to rediscover why it was needed, it means IMHO the thing is too complex already or the case which needs it is pretty obscure or the reasoning hasnt been documented, in which case disscussing the issue and documenting the reasoning seems like a good idea ... [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In the past you could go to a library and read, borrow or copy any book Today you'd get arrested for mere telling someone where the library is