- NUT-devel - lists.mplayerhq.hu

Re: [NUT-devel] FINALIZE NUT SPEC!!
by Oded Shimon 27 Feb '06

27 Feb '06

Move thread to nut-devel... Sorry, I should have mentioned in the first mail that all replies should go to nut-devel if possible. On Mon, Feb 27, 2006 at 01:34:52PM -0500, Rich Felker wrote: > On Mon, Feb 27, 2006 at 03:43:52PM +0200, Oded Shimon wrote: > > Also I want to improove speed, everytime I seeked back the damaged region > > when reaching it again it linear searched the entire ~200mb of damage > > again... > > This might be desirable in the case of an incremental download, but in > general it's probably good to cache known bad regions. Which actually also brings the issue of seeking in a "growing" file. In the first seek you do, libnut does a discovery seek of finding the last syncpoint in the file, and marks it known. The only way it can invalidated is by playing past it (libnut automatically realizes this simply by adding a syncpoint to the syncpoint cache past the last syncpoint...). I should make some kind of signal in the API to indicate file has grown... > > I object to index splitting because it is unnecessary complexity for very > > very rare occassion - partial damage in a 80kb chunk in a seekable stream. > > Now you can copy the index anywhere, it's even more unnecessary... > > I tend to agree. If one sector of the index is broken it's likely that > many are. And if the index is unusable, it's not the end of the world. > Just seek without index or rebuild the index. In theory it does sound bad to loose such a nice feature over a "single byte" when you can salvage some of it by splitting, but in practice I don't ever see such a situation happenning. Seekable streams (streams which have an index at all) are probably permanent storage. Damage in permanent storage is practically always in HUGE chunks, not in a single byte... > > The big problem I have with just info packets is that there's no way to > > really load them because they can be in any arbitrary location. Like we > > restricted the index being only after main headers and not any arbitrary > > location so demuxers can find it, same with info packets... > > Global (chapter_id==0) info would still be required to be with > headers, and users would have to put any other chapter info they > wanted to be globally available with the headers too. Storing it other > places would just be for streaming purposes. > > However, for many streaming applications, you need the full power of a > stream to represent realtime data reasonably. So even if we allow info > packets at places other than with headers, I still want info streams. If we're having info streams, then no "arbitrary info packets" please... They are an annoying complexity. (I have an api function, get_packet(), which when called either always gives a single frame, or throws an error. If it sees main headers, it skips over the entire header stuff, and recurses... With arbitrary info packets, this will have to turn nasty as a call could either give a frame, or an info packet...) One nice advntage I see to dumping info streams is that, in reality, info streams don't really have "stream-like" behavior... (They make back_ptr big etc.) - ods15

2 1

[NUT] (ods15): r83 - /trunk/libnut/reorder.c
by syncmail＠mplayerhq.hu 27 Feb '06

27 Feb '06

Author: ods15 Date: Mon Feb 27 19:01:20 2006 New Revision: 83 Log: add stdio.h for off_t Modified: trunk/libnut/reorder.c Modified: trunk/libnut/reorder.c ============================================================================== --- trunk/libnut/reorder.c (original) +++ trunk/libnut/reorder.c Mon Feb 27 19:01:20 2006 @@ -1,5 +1,6 @@ #include <inttypes.h> #include <stdlib.h> +#include <stdio.h> #include "nut.h" #include "priv.h"

1 0

dump info streams, just info packets
by Oded Shimon 27 Feb '06

27 Feb '06

It's non ideal IMO, I like the current system where the only packets that can appear during normal demuxing is only frame, syncpoint, or main header. But still, my suggestion for just info packets is: all info packets with chapter_id >= 0 MUST appear at BOF (or maybe MUST appear after all copies of main headers), and chapter_id <0 carry no restrictions... I still preffer an info stream solution if possible... - ods15

1 0

Patch for info frames
by Oded Shimon 26 Feb '06

26 Feb '06

Comments... - ods15

3 7

[NUT] (ods15): r82 - /trunk/libnut/priv.h
by syncmail＠mplayerhq.hu 26 Feb '06

26 Feb '06

Author: ods15 Date: Sun Feb 26 09:01:27 2006 New Revision: 82 Log: info table is obsolete Modified: trunk/libnut/priv.h Modified: trunk/libnut/priv.h ============================================================================== --- trunk/libnut/priv.h (original) +++ trunk/libnut/priv.h Sun Feb 26 09:01:27 2006 @@ -157,25 +157,6 @@ int sync_overhead; }; -static const struct { char * name, * type; } info_table [] = { - {NULL , NULL }, // end - {NULL , NULL }, - {NULL , "UTF8"}, - {NULL , "v"}, - {NULL , "s"}, - {"StreamId" , "v"}, - {"Author" , "UTF8"}, - {"Title" , "UTF8"}, - {"Language" , "UTF8"}, - {"Description" , "UTF8"}, - {"Copyright" , "UTF8"}, - {"Encoder" , "UTF8"}, - {"Keyword" , "UTF8"}, - {"Cover" , "JPEG"}, - {"Cover" , "PNG"}, - {"Disposition" , "UTF8"}, -}; - static inline uint32_t crc32(uint8_t * buf, int len){ int32_t crc = 0; int i;

1 0

Patch for info packets
by Oded Shimon 26 Feb '06

26 Feb '06

This is my patch... Comments welcome, I hope this patch will please everyone... - ods15

3 17

FINALIZE NUT SPEC!!
by Oded Shimon 25 Feb '06

25 Feb '06

The info frames patch I just sent to nut-devel is the last withstanding problem I know of for NUT. libnut seeking has been rather heavily tested, even with EOR. We could still add (remove?) some fields for Info packets/frames, but that can be done after finalizing. libnut/nututils is far from ready for production, but I think mpcf.txt _IS_. Is there anything else? Is anyone displeased? (even Ivan is happy and stopped flaming! :) Speak now or forever (or atleast until NUT 2.0 :) hold you peace... (The spec could really use a cleaning up, but the bitstream is locked...) - ods15

2 1

[NUT] (ods15): r81 - /trunk/libnut/muxer.c
by syncmail＠mplayerhq.hu 25 Feb '06

25 Feb '06

Author: ods15 Date: Sat Feb 25 19:50:31 2006 New Revision: 81 Log: sync to spec for info rationals Modified: trunk/libnut/muxer.c Modified: trunk/libnut/muxer.c ============================================================================== --- trunk/libnut/muxer.c (original) +++ trunk/libnut/muxer.c Sat Feb 25 19:50:31 2006 @@ -390,7 +390,7 @@ put_s(tmp, -3); put_s(tmp, field->val); } else if (!strcmp(field->type, "r")) { - put_s(tmp, -(field->den + 2)); + put_s(tmp, -(field->den + 3)); put_s(tmp, field->val); } else { if (strcmp(field->type, "UTF-8")) {

1 0

[NUT] (ods15): r80 - in /trunk: libnut/priv.h nututils/nutindex.c
by syncmail＠mplayerhq.hu 25 Feb '06

25 Feb '06

Author: ods15 Date: Sat Feb 25 19:24:17 2006 New Revision: 80 Log: fix crc32... Modified: trunk/libnut/priv.h trunk/nututils/nutindex.c Modified: trunk/libnut/priv.h ============================================================================== --- trunk/libnut/priv.h (original) +++ trunk/libnut/priv.h Sat Feb 25 19:24:17 2006 @@ -177,7 +177,7 @@ }; static inline uint32_t crc32(uint8_t * buf, int len){ - uint32_t crc = 0; + int32_t crc = 0; int i; while (len--) { crc ^= *buf++ << 24; Modified: trunk/nututils/nutindex.c ============================================================================== --- trunk/nututils/nutindex.c (original) +++ trunk/nututils/nutindex.c Sat Feb 25 19:24:17 2006 @@ -21,7 +21,7 @@ #define bctello(bc) ((bc)->file_pos + ((bc)->buf_ptr - (bc)->buf)) static inline uint32_t crc32(uint8_t * buf, int len){ - uint32_t crc = 0; + int32_t crc = 0; int i; while (len--) { crc ^= *buf++ << 24;

1 0

[NUT] (ods15): r79 - /trunk/libnut/demuxer.c
by syncmail＠mplayerhq.hu 25 Feb '06

25 Feb '06

Author: ods15 Date: Sat Feb 25 18:39:57 2006 New Revision: 79 Log: fix use of uninited memory Modified: trunk/libnut/demuxer.c Modified: trunk/libnut/demuxer.c ============================================================================== --- trunk/libnut/demuxer.c (original) +++ trunk/libnut/demuxer.c Sat Feb 25 18:39:57 2006 @@ -451,7 +451,7 @@ GET_V(tmp, A); GET_V(tmp, B); sl->eor[j * nut->stream_count + i] = last_pts + A + B; - } + } else sl->eor[j * nut->stream_count + i] = 0; sl->pts[j * nut->stream_count + i] = last_pts + A; last_pts += A + B; }

1 0