May 2003 - MPlayer-G2-dev - lists.mplayerhq.hu

[RFC] first draft of stream/demux-metadata support (+playlist-infos)
by Fabian Franz 14 Jun '03

14 Jun '03

Hi, I slept a while and think I found the different types, that need to be supported (supposed playlist-handlers will be complete in demuxer-level too) To-be-supported Examples: QT-MOVIE: (or other playlist) Metadata: Title: Foo's adventure Author: Bar Bar cue Date: 2005 References: (Ext-)Reference: url: foo-high-res.mov bitrate: 16000 quality: 9 -- url: foo-medi-res.mov -- url: foo-low-res1.mov -- url: foo-low-res2.mov (Ext-)Reference: url: foo-title2.mov DVD: Metadata: Title: Foo on DVD Author: Bar Bar Cue Date: 2005 DVD-META: Titles: 16 Chapters: 25 Subtitle-Languages: de en uk fr Audio-Languages: de en References: (Int-)Reference: name: Main-Movie (title1) offset: 1656 (Int-)Reference: name: Chapter 1 offset: 1656 (Int-)Reference: name: Chapter 2 offset: 1856 ... (Int-)Reference: name: title2 offset: 1987 CD: Metadata: Title: Bar is singing Author: Foo's hidden microphone Date: 2008 CD-META: nb_tracks = 16 length = 00:57:68 References: (Int-)Reference: name: Foo Title 1 offset: 108 (Int-)Reference: name: Foo Title 2 offset: 206 Proposed structures: -> Metadata as list. (as already implemented) <SPEC>-META as an struct specific to media. Reference: (somewaht similar to metadata, which should not be specific to demuxer-level) struct ref_list_s; typedef struct ref_entry_s { char* name; int offset; Url_t *URL; int bitrate; // perhaps present in Url_t ? int quality; ... int type; // external / internal reference ref_list_t* alternatives; ref_list_t* sublist; } ref_entry_t; typedef struct ref_list_s { int num_refs; // number of available entries int max_refs; // number of allocated entries (if(num_metas>=max_metas)realloc()) ref_entry_t* refs; } ref_list_t; So CD is a flat structure, which do not use alternatives or sublist. MOV can make use of alternatives to allow player an choice. DVD does make heavy use of sublist, as disk/titles/chapters have a somewaht nested strucutre. One goal in later implementation should be simplicity. num=add_ext_reference(reflist,name, url) // returns the index ... add_ext_reference_alternative(reflist,num, name, url, bitrate, quality, ...) add_ext_reference_alternative(reflist,num, name2, url2, bitrate2, quality2, ...) num=add_reference(reflist,dvdname, offset) // returns the index ... add_reference_sublist(reflist,num, chaptername, offset) add_reference_sublist(reflist,num, chaptername2, offset2) Later CONTROL-program can get the data via: for (i=0;i<reflist.num_refs;i++) { printf("Name: %s\n",reflist.refs[i]->name); } Convert it into own playlist/playtree-format and so on... The whole thing shall be in stream_t stream* as meta_t *meta { metadata_list_t data; void* specific_data; // or struct some_specific_s (like stream_priv_s) ref_list_t list; } or similar. cu Fabian

2 4

cfg.h (config layer 0 discussion)
by Arpi 31 May '03

31 May '03

Hi, Here's an updated/modified/extended/stipped :) version of Andriy's cfg.h: #ifndef __CFG_H #define __CFG_H 1 /* type (menu field) ->p ->min ->max ->priv */ typedef enum { // flag (checkbox) int* reset set - CONF_TYPE_FLAG=1, // integer (slider) int* min max - CONF_TYPE_INT, // float (slider) float* min max - CONF_TYPE_FLOAT, // position (slider) off_t* min max - CONF_TYPE_POSITION, // string (input box) char** min max - (min/max length) CONF_TYPE_STRING, // select list (combobox) int* - - config_select_list_t* CONF_TYPE_SELECT, // string list char*** min max - (min/max nr. of strings) // (comma-seperated list of strings, to be parsed later or to pass ordered list of strings) CONF_TYPE_STRING_LIST, // function void* arg1 arg2 (*parser_func)(void*,arg1,arg2) // (custom parser func for 3rd party plugins or special applications) CONF_TYPE_FUNC, // removed option - - - - // (removed option, parser should fail with error, with message from *desc, gui should ignore this) CONF_TYPE_OBSOLETE, // group separator - - - config_group_info_t* // (this is NOT a real option, but an option group definition, for gui use) CONF_TYPE_GROUP, //*** this is not a valid type, but the number of types: CONF_TYPE_MAX } config_type_t; typedef struct { int value; char* name; char* desc; } config_select_list_t; typedef struct { // TODO!!!! int dummy; } config_group_info_t; /* flags for options */ // 'min' value is given in config_t #define CONF_MIN (1<<0) // 'max' value is given in config_t #define CONF_MAX (1<<1) // both 'min' and 'max' value is given in config_t #define CONF_RANGE (CONF_MIN|CONF_MAX) // This option cannot be in config file #define CONF_NOCFG (1<<2) // This option cannot be in command line #define CONF_NOCMD (1<<3) // This option cannot (shouldn't) be visible in gui: #define CONF_NOGUI (1<<4) // This option can be used without explicit naming: #define CONF_UNNAMED (1<<5) typedef struct { char *name; void *p; /* pointer to variable where store result to, type specific */ config_type_t type; unsigned int flags; float min, max; /* valid range */ void *priv; /* additional pointer, type specific */ char *desc; /* short description for help and gui */ } config_t; /* note: version has to be first in ModuleInfo struct in loadable module to allow us always do validation/version check of module */ typedef struct { unsigned short type, version; // for loadable plugins char *name; char *desc; // short description for commandline help and gui char *maintainer; char *author; char *comment; config_t *config; void *config_defaults; int *config_size; // void *handle; } module_info_t; #endif /* __CFG_H */ Any questions/suggestions? (I've tried to apply the ideas/comments from that thread) Problem: we should store some reference inside the module_info_t struct to the actual module entry point (maybe the addess of the open() func? or the functions_t struct? do we need to store dlopen() handle there?) I'm trying to avoid the unification of all layer's API, but maybe we should decide between the open()-only (vo2, vf) and functions_t (ao2, ad, vd) style, and convert the looser. A'rpi / Astral & ESP-team -- Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu

3 35

trying mp_image -> get/release_buffer migration...
by Arpi 29 May '03

29 May '03

Hi, After some problems raised (including still images and/or osd rendering into non-temp buffers), codecs using new buffering schemes (like vp3's gold frames, or h264's more-than-two P frames) i've decided to try to change video filter layer (yes, i said video filter layer, and yes, i remember what i did say before :)) to use the get_buffer/release_buffer concept insteda of current MP_IMAGE_TYPE thingie (buffering schemes like static, temp, export, ip, ipb) ok, it will be a hard and serious change, meaning that porting codecs & filters from g1 will be not as easy... but i feel it does worth it. and anyway as our primary codec is libavcodec, it will be even easier, as it already uses get/release buffer scheme. anyway my plans for this implementation inherits some key elements from g1's mp_image stuff: there will be a type field for get_buffer() requests: - EXPORT (it means that memory allocation is done by codec) - TEMP - STATIC (temp and static are actually the same, this type is only a hint for underlaying layers that we will keep this buffer after rendering for the next frames, or we'll drop it. maybe i'll leave this thing out?) also there will be restriction flags, just like in g1's mpi, to define what kind of stride and buffer alignment is accepted and do we need to preserve buffer content or allocate it in fast (readable and/or random writeable) memory. main differences from g1/mpi style: - no more specialized schemes like IP and IPB, and more than 3 buffers supported... (mpi is limited to 3) - no 'one frame decoding == one get_image call' restirction. it's possible to allocate 3 buffers at init (or at first farme decoding) and then use them all them and then release them at uninit. or a filter (likeinv. telecine) may delay video by many frames, by allocating for example 5 of them. and so on, there is no limit. it will solve some problems we currently have. and it also make sit easier to implement filter merging/branching (multiple vo drivers, mixing 2 videos etc) _later_. also a buffer (image) may be returned multiple times by process_image(). - buffer structs aren't cloned/copied while transfering from one filter to another, like mpi. although i'm not sure it's required / is a good idea. comments? A'rpi / Astral & ESP-team -- Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu

3 6

pre31 + pause
by Arpi 29 May '03

29 May '03

Hi, ok here's pre31, nothing special, just some patches applied, and configure from g1 included: pre31: - stream layer: mms:// support ported from g1/main by Fabian Franz - libmpeg2 postprocessing (export qscale) support by Fabian Franz - cvs up (libavcodec etc updated) - configure from g1 included (modified at help/* and mpdvdklit2 detection) - stream/README updated :))))) Don't expect pre32 soon, i'll mess up my tree to death to try out the get/release_buffer concept in practice. also i'll get my long-awaited hauppauge pvr-350 capture card tomorrow so i'll hack it for a few days. and i'll be away at weekend, so probably no g2 development until the end of this week... A'rpi / Astral & ESP-team -- Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu

4 6

Crash in G2 (v30)
by Ross Finlayson 28 May '03

28 May '03

I downloaded and built MPlayer "G2" (v30) from <http://mplayerhq.hu/~arpi/g2/> (with the aim of seeing how easy it would be to port the LIVE.COM RTSP/RTP demuxer to it), but unfortunately "test-play" crashed when I tried to play an ordinary MPEG-1 Program Stream file. See the "gdb" output below. I have left a copy of the input file online as http://www.live.com/mplayer/test.mpg Ross. %gdb ./test-play GNU gdb 4.18 Copyright 1998 Free Software Foundation, Inc. GDB is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. Type "show copying" to see the conditions. There is absolutely no warranty for GDB. Type "show warranty" for details. This GDB was configured as "i386-redhat-linux"... (gdb) run test.mpg Starting program: /home/rsf/mplayer/g2/./test-play ~/.mk/testProgs/test.mpg Using GNU internationalization Original domain: messages Original dirname: /usr/share/locale Current domain: mplayer Current dirname: /usr/local/share/locale CPU: Intel Celeron A Mendocino/Pentium II Dixon (Family: 6, Stepping: 10) Detected cache-line size is 32 bytes faszom 0/1 parsed /home/rsf/.mk/testProgs/test.mpg as filename get_path('codecs.conf') -> '/home/rsf/.mplayer/codecs.conf' Reading /home/rsf/.mplayer/codecs.conf: 53 audio & 141 video codecs Not an URL! Stream type: 0 len: 41639108 demuxer: trying [avi] based on Content, level 1 DEMUXER: freeing demuxer at 0x829d598 demuxer: trying [asf] based on Content, level 1 DEMUXER: freeing demuxer at 0x829d598 demuxer: trying [ogg] based on Content, level 1 DEMUXER: freeing demuxer at 0x829d598 demuxer: trying [nsv] based on Content, level 1 DEMUXER: freeing demuxer at 0x829d598 demuxer: trying [ts] based on Content, level 1 demuxer: trying [mpeg] based on Content, level 1 demuxer: trying [avi] based on Content, level 2 demuxer: trying [asf] based on Content, level 2 demuxer: trying [ogg] based on Content, level 2 demuxer: trying [nsv] based on Content, level 2 demuxer: trying [ts] based on Content, level 2 DEMUXER: freeing demuxer at 0x829d598 demuxer: trying [mpeg] based on Content, level 2 demuxer: trying [avi] based on Content, level 3 demuxer: trying [asf] based on Content, level 3 demuxer: trying [ogg] based on Content, level 3 demuxer: trying [nsv] based on Content, level 3 demuxer: trying [ts] based on Content, level 3 demuxer: trying [mpeg] based on Content, level 3 Detected fileformat: [mpeg] MPEG TS/PS/PES/ES Audio and/or Video MPEG-PS System Stream synced at 0x0 (0)! DEMUXER: New stream: 480 type: 1 DEMUXER: New stream: 448 type: 2 ######### Audio STREAM #448 (enabled) ######### Opening audio decoder: [mp3lib] MPEG layer-2, layer-3 dec_audio: Allocating 4608 + 65536 = 70144 bytes for output buffer mp3lib: made decode tables with MMX optimization mp3lib: using MMX optimized decore! MP3lib: init layer2&3 finished, tables done Program received signal SIGILL, Illegal instruction. 0x81ab51b in fast_memcpy_SSE (to=0x8260e40, from=0x8260740, len=512) at aclib_template.c:213 213 __asm__ __volatile__ ( (gdb) where #0 0x81ab51b in fast_memcpy_SSE (to=0x8260e40, from=0x8260740, len=512) at aclib_template.c:213 #1 0x81ab60f in fast_memcpy (to=0x8260e40, from=0x8260740, len=512) at aclib.c:136 #2 0x816ec3b in MP3_DecodeFrame (hova=0x84aa380 "", single=-1) at sr1.c:168 #3 0x804fc0c in init (sh=0x84aa308) at ad_mp3lib.c:49 #4 0x804e91e in init_audio_codec (sh_audio=0x84aa308) at dec_audio.c:105 #5 0x804eb69 in init_audio (sh_audio=0x84aa308, codecname=0x0, afm=0x0, status=1) at dec_audio.c:195 #6 0x804ece1 in init_best_audio_codec (sh_audio=0x84aa308, audio_codec_list=0xbffffa44, audio_fm_list=0x0) at dec_audio.c:240 #7 0x804ddbc in main (argc=2, argv=0xbffffb04, envp=0xbffffb10) at test-play.c:206 (gdb)

2 1

[PATCH] ported mms from main
by Fabian Franz 27 May '03

27 May '03

hi, here it is. As always I had some questions and marked them with // FF: . But the good thing is, that it already works and output seems to me (as far as I can see with watching some videos ;) not different from mmst://) cu Fabian

4 17

Can I try it?
by Jonathan Rogers 26 May '03

26 May '03

I know that I'm not a G2 developer, and I do not wish to waste any time here, so I'll be brief. Is there any chance of getting anonymous CVS access for G2 so I can start trying it? I realize it's not "ready for the masses," but I want to follow development. I promise not to ask any questions here about getting it to work or otherwise waste anyone's time. Thanks for all the great work you guys have done so far. Jonathan Rogers

2 2

[QUESTION] (How) will you handle playlists and other info structures ?
by Fabian Franz 26 May '03

26 May '03

Hi, (How) will you handle playlists and other info structures ? like cddb-titles, dvd-titles, mov-lists, asx-parsing ( :( ) and so on to get it nicely to CONTROL (i.e. cli/gui) from demuxer/stream-layer. I think this still needs to be designed. cu Fabian

2 1

pre30...
by Arpi 26 May '03

26 May '03

Hi, pre30: - stream layer fixes/ports by Fabian Franz: - decreased smb:// verbose level - http proxy support - bin/cue support - vcd cleanup - DOCS/cfg.txt - libvo2 migrated to new config layer - vf_scale cleanup, migrated to new config layer (-sws, -ssf etc) - several 10ls fixed in config layers A'rpi / Astral & ESP-team -- Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu

2 2

RFC: commandline syntax
by Arpi 26 May '03

26 May '03

Hi, Before we start flaming about commandline parsing is UI's job, of course it is. But we have to prepare core libs and config code to serve it. And anyway defining a standard (reference) syntax for g2 libs is not a bad thing, imho. And anyway 2, we should implement a simple CLI for testing g2 libs (sth like current test-play.c). Ok, the topic of this thread will be the reference (recommended) commandline syntax. Ie how to pass arhs to the core libs, modules/plugins. AO/VO ~~~~~ In case of ao and vo, i would keep the old (g1) syntax, with the little difference that 'subdevice' is now parsed by the config layer instead of sscanf and such mess. I've already updated libvo2 to use it. Libao2 isn't update dyet, but 1. Anders promised some libao3? 2. we need to change libao2 API anyway to get rid of ao-data and such globals, so we can do the ao_info=>module_info change at the same time. So the syntax is -vo driver1[=[param1=]arg1[:[param2=]arg2...]][,driver2][,] In short: oen or more drivers (even teh same driver with different args, for example -vo mga:/dev/mga_vid1,mga:/dev/mga_vid0) can be listed together with their optional args (which may be just arg-list (like g1's -vf syntax) or named params (like g1's subconfig) or the combination of them). The list may be terminated by a comma (,), it means that non-listed drivers should be tried too. AF/VF ~~~~~ For audio/video filters, imho g1's -vf syntax is still ok: -vf filter1[=[param1=]arg1[:[param2=]arg2...]][,filter2][,] (so it's the same as ao/vo but lists filters instead of drivers, and all the filters are loaded/inited/used not only the first available one) It's implemented for video filters in g2 (ok it's buggy as it uses reverse (-vop) order but -vf name :)). I plan to redesign audio filter layer, so i left it for now. Ok we're over the simple things. AC/VC/AFM/VFM ~~~~~~~~~~~~~ Audio/video codecs: in g1 there is no way to pass options to codecs directly in -ac/-vc/-afm/-vfm options. There is -lavdopts for the only codec requiring extra config. So it's unusual that a codec have extra config, so I left codec level migration for now. It's not easy anyway (i have an almost-compilable version locally but it's ugly as hell due to triple typecasts in function calls). If we decide that we need to pass config to codecs in a generic way (ie. no -lavdopts), then the question is there: how?? Actually codec modules/plugins are named by -afm/-vfm options, the -ac/-vc options name codecs.conf entries, not plugins. Maybe an -vdopts/-adopts can do the job? see bellow at stream. STREAM ~~~~~~ It'ts tricky. Currently the stream driver to be used is determined from the url. If it has prot://... syntax, then stream_prot.c is used (if exists, otherwise dummy stream handle is created for stream-less demuxers...). If it has no prot://... syntax, it's assumed to be plain file or stream (==non-seekable file, like stdin or pipe). Ok it's not so simple. Plugins may be named differently than url:// syntax, to allow multiple plugins to handle same url (for example rtsp:// or rtp:// cases, when there is live.com, real-rtsp and dvbstream's rtp). So, we also need a way to explicitly name (or list in order) the stream drivers to be used. There is 2 methods to pass config: 1. -stream [option1=]value1[:option2=value2...], ie g1-subconfig syntax. it will allow options for single driver/plugin only, and will eb applied to the driver selected based on url/type. 2. -stream driver1[=[option1=]value1[:...]][,driver2...][,], ie. ao/vo syntax I guess we should vote for 2 (while 5 mins ago i thought 1. is better), because this way we get parsig for free (automatic handled by cfg layer 1) and we can explicitly name/order drivers, even the same driver with different args (like -stream vcd=dev=/dev/hdd:vcd=dev=/dev/hdc, to force player to try both cdrom drives when playing vcd) DEMUX: ~~~~~~ After writting the above lines, i guess it's the same case as stream. Maybe we should extend the syntax (both stream & demuxer, but it could help in codec acse too) somehow to allow out-of-order configuration. Ie list various plugins with their config/args, but _without_ changing the order 'hardcoded' in the core libs or codecs.conf. It could be different option (like -demuxopts or -demuxconf) or some special sign in the option list to note it's unordered, for example -demuxer !mpeg=maxpkt=8192 would mean use maxpkt=8192 for moeg demuxer, but do not raise mpeg demuxer to top priority. I'm interested in comments, better ideas, i'm not too good in CLI design ;( Also we should discuss/decide if we keep CLI somewhat compatible/consistent with g1 or redesign (option names, syntax) from scratch? Imho g1's syntax is not as bad, with the above things decided it could be usable. Also keeping g1's syntax will make migrating easier for users, and even for developers. Ah, and yet another thing: currently the cfg-parser is very strict, if you do synatx errors, list non-existant modules/plugins, it will exit with error. Imho we should find some nice way to handle existing but non-available options (like -dvd without dvdread support compiled in (YES i know it's wrong example for g2...)), and non-existant (or non-available, == not compiled / downloaded plugin) plugins. For example, g1's -vop allwoed to list non-existant filter, and it didn't even fail, just printed warning message that that filter doesn't exist and is ignored. ok, enough for today. happy brainstorming :) A'rpi / Astral & ESP-team -- Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu

2 3