[PATCH] add a \n at the end of MSGTR_CacheFill
why not to add a '\n' at the end ot the message MSGTR_CacheFill in help/help_mp-en.h????? sometimes the output of that line is odd. for example with -identify one has: Cache fill: 0.00% (1127219200 bytes) ID_VIDEO_ID=0 ID_AUDIO_ID=132 ... or Cache fill: 0.00% (1127219200 bytes) MPEG-PS file format detected.
On Wed, Oct 26, 2005 at 05:50:41PM +0200, Paul TT wrote:
why not to add a '\n' at the end ot the message MSGTR_CacheFill in help/help_mp-en.h?????
sometimes the output of that line is odd. for example with -identify one has:
Cache fill: 0.00% (1127219200 bytes) ID_VIDEO_ID=0 ID_AUDIO_ID=132 ...
or Cache fill: 0.00% (1127219200 bytes) MPEG-PS file format detected.
or Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes) .... Try a bigger cache and an actually slow connection, see what happens The code which runs cache should be fixed, it should do a \n after cache fill is done. - ods15
On Wed, Oct 26, 2005 at 07:31:47PM +0200, Oded Shimon wrote:
On Wed, Oct 26, 2005 at 05:50:41PM +0200, Paul TT wrote:
why not to add a '\n' at the end ot the message MSGTR_CacheFill in help/help_mp-en.h?????
sometimes the output of that line is odd. for example with -identify one has:
Cache fill: 0.00% (1127219200 bytes) ID_VIDEO_ID=0 ID_AUDIO_ID=132 ...
or Cache fill: 0.00% (1127219200 bytes) MPEG-PS file format detected.
or
Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes) Cache fill: 0.00% (1127219200 bytes)
....
Try a bigger cache and an actually slow connection, see what happens
The code which runs cache should be fixed, it should do a \n after cache fill is done.
Oded, this sounds like you could implement it in 15 minutes, why don't you have a go at it? :-) Diego
On Wed, Oct 26, 2005 at 10:09:36PM +0200, Diego Biurrun wrote:
On Wed, Oct 26, 2005 at 07:31:47PM +0200, Oded Shimon wrote:
The code which runs cache should be fixed, it should do a \n after cache fill is done.
Oded, this sounds like you could implement it in 15 minutes, why don't you have a go at it? :-)
sigh.. about 2 minutes. i could've used them for something else, like being bored. Not my code, so not committing before i send patch. Trivial, will commit soon. - ods15
On Wed, Oct 26, 2005 at 10:37:18PM +0200, Oded Shimon wrote:
On Wed, Oct 26, 2005 at 10:09:36PM +0200, Diego Biurrun wrote:
On Wed, Oct 26, 2005 at 07:31:47PM +0200, Oded Shimon wrote:
The code which runs cache should be fixed, it should do a \n after cache fill is done.
Oded, this sounds like you could implement it in 15 minutes, why don't you have a go at it? :-)
sigh.. about 2 minutes. i could've used them for something else, like being bored.
:)
Not my code, so not committing before i send patch. Trivial, will commit soon.
It's really trivial. Commit right away. Diego
On Wed, Oct 26, 2005 at 10:53:51PM +0200, Diego Biurrun wrote:
On Wed, Oct 26, 2005 at 10:37:18PM +0200, Oded Shimon wrote:
On Wed, Oct 26, 2005 at 10:09:36PM +0200, Diego Biurrun wrote:
On Wed, Oct 26, 2005 at 07:31:47PM +0200, Oded Shimon wrote:
The code which runs cache should be fixed, it should do a \n after cache fill is done.
Oded, this sounds like you could implement it in 15 minutes, why don't you have a go at it? :-)
sigh.. about 2 minutes. i could've used them for something else, like being bored.
:)
Not my code, so not committing before i send patch. Trivial, will commit soon.
It's really trivial. Commit right away.
Done - ods15
participants (3)
-
Diego Biurrun -
Oded Shimon -
Paul TT