Author: diego Date: Tue May 27 15:32:00 2008 New Revision: 26901 Log: mga_vid string wording fix Modified: trunk/help/help_mp-en.h Modified: trunk/help/help_mp-en.h ============================================================================== --- trunk/help/help_mp-en.h (original) +++ trunk/help/help_mp-en.h Tue May 27 15:32:00 2008 @@ -1712,7 +1712,7 @@ static char help_text[]= #define MSGTR_LIBVO_MGA_IncompatibleDriverVersion "[MGA] Your mga_vid driver version is incompatible with this MPlayer version!\n" #define MSGTR_LIBVO_MGA_CouldntOpen "[MGA] Couldn't open: %s\n" #define MGSTR_LIBVO_MGA_ResolutionTooHigh "[MGA] Source resolution is in at least one dimension larger than 1023x1023. Please rescale in software or use -lavdopts lowres=1\n" -#define MGSTR_LIBVO_MGA_mgavidVersionMismatch "[MGA] The version of the mga_vid driver (%u) does not match the version with which MPlayer was compiled with (%u)\n" +#define MGSTR_LIBVO_MGA_mgavidVersionMismatch "[MGA] The version of the mga_vid driver (%u) does not match the version MPlayer was compiled with (%u).\n" // libvo/vesa_lvo.c
diego wrote:
Author: diego Date: Tue May 27 15:32:00 2008 New Revision: 26901
Log: mga_vid string wording fix
Modified: trunk/help/help_mp-en.h
Modified: trunk/help/help_mp-en.h ============================================================================== --- trunk/help/help_mp-en.h (original) +++ trunk/help/help_mp-en.h Tue May 27 15:32:00 2008 @@ -1712,7 +1712,7 @@ static char help_text[]= #define MSGTR_LIBVO_MGA_IncompatibleDriverVersion "[MGA] Your mga_vid driver version is incompatible with this MPlayer version!\n" #define MSGTR_LIBVO_MGA_CouldntOpen "[MGA] Couldn't open: %s\n" #define MGSTR_LIBVO_MGA_ResolutionTooHigh "[MGA] Source resolution is in at least one dimension larger than 1023x1023. Please rescale in software or use -lavdopts lowres=1\n" -#define MGSTR_LIBVO_MGA_mgavidVersionMismatch "[MGA] The version of the mga_vid driver (%u) does not match the version with which MPlayer was compiled with (%u)\n" +#define MGSTR_LIBVO_MGA_mgavidVersionMismatch "[MGA] The version of the mga_vid driver (%u) does not match the version MPlayer was compiled with (%u).\n"
For strict grammaticality the "with which" should have been kept and the terminal "with" dropped (per the classic rule "never end a sentence with a preposition"), but in practice the strictly-correct form is likely to look odd to more people than the other form, so this way might be better. -- The Wanderer Warning: Simply because I argue an issue does not mean I agree with any side of it. Secrecy is the beginning of tyranny.
On Tue, May 27, 2008 at 05:04:32PM -0400, The Wanderer wrote:
diego wrote:
Log: mga_vid string wording fix
--- trunk/help/help_mp-en.h (original) +++ trunk/help/help_mp-en.h Tue May 27 15:32:00 2008 @@ -1712,7 +1712,7 @@ static char help_text[]= #define MGSTR_LIBVO_MGA_ResolutionTooHigh "[MGA] Source resolution is in at least one dimension larger than 1023x1023. Please rescale in software or use -lavdopts lowres=1\n" -#define MGSTR_LIBVO_MGA_mgavidVersionMismatch "[MGA] The version of the mga_vid driver (%u) does not match the version with which MPlayer was compiled with (%u)\n" +#define MGSTR_LIBVO_MGA_mgavidVersionMismatch "[MGA] The version of the mga_vid driver (%u) does not match the version MPlayer was compiled with (%u).\n"
For strict grammaticality the "with which" should have been kept and the terminal "with" dropped (per the classic rule "never end a sentence with a preposition"), but in practice the strictly-correct form is likely to look odd to more people than the other form, so this way might be better.
Next try committed. Diego
participants (3)
-
diego -
Diego Biurrun -
The Wanderer