The time has came for me to read mencoder.xml ;) Here's what I want to point out: The tables at the first section (a/v codecs and container formats) use capital and non-capital letters at beginnings liberally. I'd vote for starting each entri with non-capital letter, except of course for MPEG, Xvid etc. See patch #1 Section 13.8. Encoding from multiple input image files (JPEG, PNG, TGA, SGI): The title of this section is the only place in the whole file where I (or grep) find SGI. Either add some text/examples or remove it from the title. Examples: Almost all of them have overly long lines. Most of them can be broken (see patch #2), sometimes by reordering the options, hopefully I've done it right (will double check before commiting). A lot of them also have missing <replaceable> tags, added as well. The i_certify_that_my_video_stream_does_not_use_b_frames -lavf option: At first I thought it was 'insert here all options to certify...', not a real option name. I even translated it in first try. Only grepping the sources convinced me otherwise. Maybe it would be worth noting this in documentation. Good thing at least there's a big fat explanation if you omit this option. Torinthiel -- Waclaw "Torinthiel" Schiller GG#: 3073512 torinthiel(at)megapolis(dot)pl gpg: 0906A2CE fpr: EE3E DFB4 C4D6 E22E 8999 D714 7CEB CDDC 0906 A2CE "No classmates may be used during this examination"
Torinthiel wrote:
The time has came for me to read mencoder.xml ;)
Here's what I want to point out:
The tables at the first section (a/v codecs and container formats) use capital and non-capital letters at beginnings liberally. I'd vote for starting each entri with non-capital letter, except of course for MPEG, Xvid etc. See patch #1
patch ok with me. Unless Diego disagrees, go ahead and commit this patch.
Section 13.8. Encoding from multiple input image files (JPEG, PNG, TGA, SGI): The title of this section is the only place in the whole file where I (or grep) find SGI. Either add some text/examples or remove it from the title.
I'd say remove it. It's not common enough to deserve to be cited. replace it by " etc..." or smth similar since MPlayer/MEncoder can read more image formats than the ones listed AFAIK.
Examples: Almost all of them have overly long lines. Most of them can be broken (see patch #2), sometimes by reordering the options, hopefully I've done it right (will double check before commiting). A lot of them also have missing <replaceable> tags, added as well.
patch Ok too. Go ahead and commit it right away.
The i_certify_that_my_video_stream_does_not_use_b_frames -lavf option: At first I thought it was 'insert here all options to certify...', not a real option name. I even translated it in first try. Only grepping the sources convinced me otherwise. Maybe it would be worth noting this in documentation. Good thing at least there's a big fat explanation if you omit this option.
I just committed a patch to the man page to improve the description of i_certify_that_my_video_stream_does_not_use_b_frames (the existing doc was indeed quite succinct). If you think you can come up with smth better for the xml doc that won't be redundant with the man page, please speak up :-) Guillaume
On Thu, Nov 30, 2006 at 10:30:40AM +0100, Guillaume Poirier wrote:
Torinthiel wrote:
The time has came for me to read mencoder.xml ;)
Here's what I want to point out:
The tables at the first section (a/v codecs and container formats) use capital and non-capital letters at beginnings liberally. I'd vote for starting each entri with non-capital letter, except of course for MPEG, Xvid etc. See patch #1
patch ok with me. Unless Diego disagrees, go ahead and commit this patch.
Commit. Diego
On Thu, Nov 30, 2006 at 12:45:32AM +0100, Torinthiel wrote:
The time has came for me to read mencoder.xml ;)
Here's what I want to point out:
The tables at the first section (a/v codecs and container formats) use capital and non-capital letters at beginnings liberally. I'd vote for starting each entri with non-capital letter, except of course for MPEG, Xvid etc. See patch #1
Applied
Section 13.8. Encoding from multiple input image files (JPEG, PNG, TGA, SGI): The title of this section is the only place in the whole file where I (or grep) find SGI. Either add some text/examples or remove it from the title.
What about it? Replace with etc., as Guillaume suggested?
Examples: Almost all of them have overly long lines. Most of them can be broken (see patch #2), sometimes by reordering the options, hopefully I've done it right (will double check before commiting). A lot of them also have missing <replaceable> tags, added as well.
Applied Torinthiel -- Waclaw "Torinthiel" Schiller GG#: 3073512 torinthiel(at)megapolis(dot)pl gpg: 0906A2CE fpr: EE3E DFB4 C4D6 E22E 8999 D714 7CEB CDDC 0906 A2CE "No classmates may be used during this examination"
On Sat, Dec 02, 2006 at 01:06:26AM +0100, Torinthiel wrote:
On Thu, Nov 30, 2006 at 12:45:32AM +0100, Torinthiel wrote:
Section 13.8. Encoding from multiple input image files (JPEG, PNG, TGA, SGI): The title of this section is the only place in the whole file where I (or grep) find SGI. Either add some text/examples or remove it from the title.
What about it? Replace with etc., as Guillaume suggested?
Fine with me. Diego
On Sat, Dec 02, 2006 at 02:22:00PM +0100, Diego Biurrun wrote:
On Sat, Dec 02, 2006 at 01:06:26AM +0100, Torinthiel wrote:
On Thu, Nov 30, 2006 at 12:45:32AM +0100, Torinthiel wrote:
Section 13.8. Encoding from multiple input image files (JPEG, PNG, TGA, SGI): The title of this section is the only place in the whole file where I (or grep) find SGI. Either add some text/examples or remove it from the title.
What about it? Replace with etc., as Guillaume suggested?
Fine with me.
Done. Now, however, another issue: does mf:// work with different image types? Like first ten frames from .jpg, rest from .png? I've ran a simple test, and it appears to work. If so, it might be worth mentioning, as a paragraph after the @list.txt notation IMHO. How about it? Torinthiel -- Waclaw "Torinthiel" Schiller GG#: 3073512 torinthiel(at)megapolis(dot)pl gpg: 0906A2CE fpr: EE3E DFB4 C4D6 E22E 8999 D714 7CEB CDDC 0906 A2CE "No classmates may be used during this examination"
On Sun, Dec 03, 2006 at 12:53:24PM +0100, Torinthiel wrote:
Now, however, another issue: does mf:// work with different image types? Like first ten frames from .jpg, rest from .png? I've ran a simple test, and it appears to work. If so, it might be worth mentioning, as a paragraph after the @list.txt notation IMHO. How about it?
Go right ahead. Diego
On Mon, Dec 04, 2006 at 09:55:50AM +0100, Diego Biurrun wrote:
On Sun, Dec 03, 2006 at 12:53:24PM +0100, Torinthiel wrote:
Now, however, another issue: does mf:// work with different image types? Like first ten frames from .jpg, rest from .png? I've ran a simple test, and it appears to work. If so, it might be worth mentioning, as a paragraph after the @list.txt notation IMHO. How about it?
Go right ahead.
Done (finally) Torinthiel -- Waclaw "Torinthiel" Schiller GG#: 3073512 torinthiel(at)megapolis(dot)pl gpg: 0906A2CE fpr: EE3E DFB4 C4D6 E22E 8999 D714 7CEB CDDC 0906 A2CE "No classmates may be used during this examination"
participants (3)
-
Diego Biurrun -
Guillaume Poirier -
Torinthiel