Ok, there is a huge bunch of help messages prefixed in no known form whatsoever but almost all they use some variation of [foobar], [im this module]. etc. Well, even tho this could be a nono from the start, attached patch makes all message have a prefix stating what module they where generated from. just for you to see if it fits your eyes. who knows, maybe we can put some order on the message spitting chaos mplayer is. Regards Reynaldo
On Wed, Apr 26, 2006 at 01:18:56AM -0400, Reynaldo H. Verdejo Pinochet wrote:
Ok, there is a huge bunch of help messages prefixed in no known form whatsoever but almost all they use some variation of [foobar], [im this module]. etc. Well, even tho this could be a nono from the start, attached patch makes all message have a prefix stating what module they where generated from. just for you to see if it fits your eyes. who knows, maybe we can put some order on the message spitting chaos mplayer is.
I'm pro. Especially thanks to new -msglevel .
@@ -65,7 +78,10 @@ void mp_msg(int mod, int lev, const char *format, ... ){ va_list va; char tmp[MSGSIZE_MAX]; - + char label[MSG_LABEL_LENGTH+2]; + + snprintf(label, MSG_LABEL_LENGTH+2, "%-12s| ", MSG_LABEL[mod]);
snprintf(label, MSG_LABEL_LENGTH+2, "%-*s| ", MSG_LABEL[mod], MSG_LABEL_LENGTH);
if (!mp_msg_test(mod, lev)) return; // do not display va_start(va, format); vsnprintf(tmp, MSGSIZE_MAX, format, va); @@ -187,8 +203,10 @@ } #endif if (lev <= MSGL_WARN){ + fprintf(stderr, "%s", label);
Take consideration of MP_MSG_COLOR (yes I actually use it), you will get the label printed twice. Another thing to consider is overflowing 80 width consoles, especially status line. Also the status line (sometimes) uses spaces to blank to end of line, and it assumes it doesn't have a header changing its width. - ods15
On Wed, Apr 26, 2006 at 01:18:56AM -0400, Reynaldo H. Verdejo Pinochet wrote:
Ok, there is a huge bunch of help messages prefixed in no known form whatsoever but almost all they use some variation of [foobar], [im this module]. etc. Well, even tho this could be a nono from the start, attached patch makes all message have a prefix stating what module they where generated from.
Hmm, this moves many messages over 80 characters line width. I'm not sure I like it.. Diego
Hi, On Thu, Apr 27, 2006 at 11:39:05AM +0200, Diego Biurrun wrote:
On Wed, Apr 26, 2006 at 01:18:56AM -0400, Reynaldo H. Verdejo Pinochet wrote:
Ok, there is a huge bunch of help messages prefixed in no known form whatsoever but almost all they use some variation of [foobar], [im this module]. etc. Well, even tho this could be a nono from the start, attached patch makes all message have a prefix stating what module they where generated from.
Hmm, this moves many messages over 80 characters line width. I'm not sure I like it..
I am actually against it, for this reason and that most of these prefixes are to unspecific to be useful, and I guess close inspection would reveal some that are place illogically. It might make sense to do this for some, but a closer look would be needed to find that out. Greetings, Reimar Doeffinger
On Thu, Apr 27, 2006 at 06:08:26PM +0200, Reimar Doeffinger wrote:
Hi, On Thu, Apr 27, 2006 at 11:39:05AM +0200, Diego Biurrun wrote:
On Wed, Apr 26, 2006 at 01:18:56AM -0400, Reynaldo H. Verdejo Pinochet wrote:
Ok, there is a huge bunch of help messages prefixed in no known form whatsoever but almost all they use some variation of [foobar], [im this module]. etc. Well, even tho this could be a nono from the start, attached patch makes all message have a prefix stating what module they where generated from.
Hmm, this moves many messages over 80 characters line width. I'm not sure I like it..
I am actually against it, for this reason and that most of these prefixes are to unspecific to be useful, and I guess close inspection would reveal some that are place illogically.
Can you think of a beter way to be able to realize that? of course there are wrong MSGT's used all over, so are MSGL's i think a move in this direction can help us spot an fix those.
It might make sense to do this for some, but a closer look would be needed to find that out.
What about making it optional, what about making it an -msglevel suboption ?
Greetings, Reimar Doeffinger
Regards Reynaldo
On Thu, Apr 27, 2006 at 11:39:05AM +0200, Diego Biurrun wrote:
On Wed, Apr 26, 2006 at 01:18:56AM -0400, Reynaldo H. Verdejo Pinochet wrote:
Ok, there is a huge bunch of help messages prefixed in no known form whatsoever but almost all they use some variation of [foobar], [im this module]. etc. Well, even tho this could be a nono from the start, attached patch makes all message have a prefix stating what module they where generated from.
Hmm, this moves many messages over 80 characters line width. I'm not sure I like it..
thats irrelevant, there are way to many mesages that need to be fixed /corrected anyway, not to mention you will get some spare chars when you remove the [im this module] ocurrences.
Diego
I have no particular interest in having this applied, I just though from a conversation we had last week it could be usesfull, other than that, feel free to drop it. Regards Reynaldo
_______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
On Thu, Apr 27, 2006 at 11:39:05AM +0200, Diego Biurrun wrote:
On Wed, Apr 26, 2006 at 01:18:56AM -0400, Reynaldo H. Verdejo Pinochet wrote:
Ok, there is a huge bunch of help messages prefixed in no known form whatsoever but almost all they use some variation of [foobar], [im this module]. etc. Well, even tho this could be a nono from the start, attached patch makes all message have a prefix stating what module they where generated from.
Hmm, this moves many messages over 80 characters line width. I'm not sure I like it..
I strongly dislike it just for cosmetic reasons. Rich
On Fri, Apr 28, 2006 at 09:07:37AM -0400, Rich Felker wrote:
On Thu, Apr 27, 2006 at 11:39:05AM +0200, Diego Biurrun wrote:
On Wed, Apr 26, 2006 at 01:18:56AM -0400, Reynaldo H. Verdejo Pinochet wrote:
Ok, there is a huge bunch of help messages prefixed in no known form whatsoever but almost all they use some variation of [foobar], [im this module]. etc. Well, even tho this could be a nono from the start, attached patch makes all message have a prefix stating what module they where generated from.
Hmm, this moves many messages over 80 characters line width. I'm not sure I like it..
I strongly dislike it just for cosmetic reasons.
Rich
Patch droped then. Regards Reynaldo
participants (5)
-
Diego Biurrun -
Oded Shimon -
Reimar Doeffinger -
Reynaldo H. Verdejo Pinochet -
Rich Felker