[PATCH] restored dvdnav:// stream layer
$Subject. Only the stream reader is restored; all the navigation code in mplayer.c is disabled. If no one onjects I'll commit tomorrow. P.S. Maybe we should remove completely the old code from mplayer.c and from the gui, so that the forthcoming dvdnav patches will look more understandable? Nico
Hi, On 6/11/06, Nico Sabbi <nicola_sabbi@fastwebnet.it> wrote:
$Subject. Only the stream reader is restored; all the navigation code in mplayer.c is disabled. If no one onjects I'll commit tomorrow.
P.S. Maybe we should remove completely the old code from mplayer.c and from the gui, so that the forthcoming dvdnav patches will look more understandable?
Since no one is gonna review the full blown DVDNav patch, I'd say yes: the old code would be better off being ripped off and replaced by the new implementation. Even though we would loose history, I guess we don't have much of a choice if we wanna get that patch in. Guillaume -- "Success consists of going from failure to failure without loss of enthusiasm." -- Winston Churchill
2006/6/12, Nico Sabbi <nicola_sabbi@fastwebnet.it>:
$Subject. Only the stream reader is restored; all the navigation code in mplayer.c is disabled. If no one onjects I'll commit tomorrow.
P.S. Maybe we should remove completely the old code from mplayer.c and from the gui, so that the forthcoming dvdnav patches will look more understandable?
Just by looking the patch only. + if(1) //from vlc: if not used dvdnav from cvs will fail + { + int len, event; + char buf[2048]; I don't see buf[] been used in the scope of its definition. (unless dvdnav_get_next_block is macros using buf[] ) And is there any particular reason to replace printf with fprintf, and not with mp_msg ?
Ivan Kalvachev wrote:
Just by looking the patch only.
+ if(1) //from vlc: if not used dvdnav from cvs will fail + { + int len, event; + char buf[2048];
I don't see buf[] been used in the scope of its definition. (unless dvdnav_get_next_block is macros using buf[] )
it is used: + if(1) //from vlc: if not used dvdnav from cvs will fail + { + int len, event; + char buf[2048]; + + dvdnav_get_next_block(dvdnav_priv->dvdnav,buf,&event,&len); + } ^^^^
And is there any particular reason to replace printf with fprintf, and not with mp_msg ? _______________________________________________
right. I'll fix it tonight -- Email.it, the professional e-mail, gratis per te: http://www.email.it/f Sponsor: Studiare è facile e divertente con le tecniche di Apprendimento * Creativo, in offerta speciale a soli 49 fino al 31 Agosto! * Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=5298&d=12-6
participants (4)
-
Guillaume POIRIER -
Ivan Kalvachev -
Nico Sabbi -
Nico Sabbi