[PATCH] Fix runtime adjustment of audio delay
When changing audio delay at runtime, the immediate adjustment and the change in av sync target are in opposite directions. This means that the delay immediately changes in one direction, then gradually returns to the original value and finally stabilizes in the opposite direction. I'm not sure which of the contradictory directions is the intended one (the documentation could be clearer about this) but the patch at least makes the code use one direction consistently. Btw the way the default keyboard mappings increase the shown delay value with '-' and decrease it with '+' is a bit weird.
Hi, On Sun, Apr 02, 2006 at 02:26:32PM +0300, Uoti Urpala wrote:
When changing audio delay at runtime, the immediate adjustment and the change in av sync target are in opposite directions. This means that the delay immediately changes in one direction, then gradually returns to the original value and finally stabilizes in the opposite direction.
Applied. For all I could see (and test) it seems to be correct, though I don't exactly know the A-V sync code.
Btw the way the default keyboard mappings increase the shown delay value with '-' and decrease it with '+' is a bit weird.
Well, in nit-picky mode I would say pressing + increases the Audio delay (so it somehow makes sense to put it on '+'), whereas the displayed value is the "target" A-V difference. Since audio delay means that video is ahead (higher timestamps) the A-V value would be negative for audio delay. But seriously, does anyone really think about this instead of just trying it out? *g* Greetings, Reimar Döffinger
Reimar Döffinger wrote:
Hi, On Sun, Apr 02, 2006 at 02:26:32PM +0300, Uoti Urpala wrote:
Btw the way the default keyboard mappings increase the shown delay value with '-' and decrease it with '+' is a bit weird.
Well, in nit-picky mode I would say pressing + increases the Audio delay (so it somehow makes sense to put it on '+'), whereas the displayed value is the "target" A-V difference. Since audio delay means that video is ahead (higher timestamps) the A-V value would be negative for audio delay. But seriously, does anyone really think about this instead of just trying it out? *g*
I have, on multiple occasions, until I figured out that the signs on the three relevant bits (the -delay option, the increase/decrease keys, and the displayed value) were not in sync. Since then I've taken great care to stop and think things through clearly every time I need to use the increase/decrease keys, to make sure I'm not making my perceived desync problem worse. -- The Wanderer Warning: Simply because I argue an issue does not mean I agree with any side of it. Secrecy is the beginning of tyranny.
participants (3)
-
Reimar Döffinger -
The Wanderer -
Uoti Urpala