[PATCH]Allow compilation with icc
Hi! Attached patch is currectly necessary to compile mplayer with icc (10.1). I'll commit next week, Carl Eugen
On Thu, Nov 13, 2008 at 12:50:22AM +0100, Carl Eugen Hoyos wrote:
Hi!
Attached patch is currectly necessary to compile mplayer with icc (10.1). I'll commit next week, Carl Eugen
Index: configure =================================================================== --- configure (Revision 27904) +++ configure (Arbeitskopie) @@ -7767,6 +7767,8 @@ cc_check -Wdeclaration-after-statement && CFLAGS="-Wdeclaration-after-statement $CFLAGS" cc_check -Wno-pointer-sign && CFLAGS="-Wno-pointer-sign $CFLAGS" cc_check -Wdisabled-optimization && CFLAGS="-Wdisabled-optimization $CFLAGS" +else + CFLAGS="-D_ISOC99_SOURCE -D_BSD_SOURCE $CFLAGS" fi
What is _ISOC99_SOURCE needed for? I think it should be -D_BSD_SOURCE -D_POSIX_C_SOURCE=200112L and it should be added always.
Hello, On Wed, Nov 12, 2008 at 11:12 PM, Reimar Döffinger <Reimar.Doeffinger@stud.uni-karlsruhe.de> wrote:
On Thu, Nov 13, 2008 at 12:50:22AM +0100, Carl Eugen Hoyos wrote:
Hi!
Attached patch is currectly necessary to compile mplayer with icc (10.1). I'll commit next week, Carl Eugen
Index: configure =================================================================== --- configure (Revision 27904) +++ configure (Arbeitskopie) @@ -7767,6 +7767,8 @@ cc_check -Wdeclaration-after-statement && CFLAGS="-Wdeclaration-after-statement $CFLAGS" cc_check -Wno-pointer-sign && CFLAGS="-Wno-pointer-sign $CFLAGS" cc_check -Wdisabled-optimization && CFLAGS="-Wdisabled-optimization $CFLAGS" +else + CFLAGS="-D_ISOC99_SOURCE -D_BSD_SOURCE $CFLAGS" fi
What is _ISOC99_SOURCE needed for? I think it should be -D_BSD_SOURCE -D_POSIX_C_SOURCE=200112L and it should be added always.
I think it's due to: mplayer/libavcodec/nellymoserenc.c:205: opt[0][i] = INFINITY; mplayer/libavcodec/nellymoserenc.c:242: best_val = INFINITY; Guillaume -- One should not give up hope on imbeciles. With a little training, you can make them into soldiers. -- Pierre Desproges
On Thu, Nov 13, 2008 at 12:50:22AM +0100, Carl Eugen Hoyos wrote:
--- configure (Revision 27904) +++ configure (Arbeitskopie) @@ -7767,6 +7767,8 @@ cc_check -Wno-pointer-sign && CFLAGS="-Wno-pointer-sign $CFLAGS" cc_check -Wdisabled-optimization && CFLAGS="-Wdisabled-optimization $CFLAGS" +else + CFLAGS="-D_ISOC99_SOURCE -D_BSD_SOURCE $CFLAGS" fi
Why _BSD_SOURCE? Diego
Hi! Diego Biurrun <diego <at> biurrun.de> writes:
On Thu, Nov 13, 2008 at 12:50:22AM +0100, Carl Eugen Hoyos wrote:
+ CFLAGS="-D_ISOC99_SOURCE -D_BSD_SOURCE $CFLAGS" fi
Why _BSD_SOURCE?
Because loader/pe_image.c needs it to define u_short. And yes, _ISOC99_SOURCE is needed for INFINITY. Carl Eugen
On Sat, Nov 15, 2008 at 10:20:32PM +0000, Carl Eugen Hoyos wrote:
Diego Biurrun <diego <at> biurrun.de> writes:
On Thu, Nov 13, 2008 at 12:50:22AM +0100, Carl Eugen Hoyos wrote:
+ CFLAGS="-D_ISOC99_SOURCE -D_BSD_SOURCE $CFLAGS" fi
Why _BSD_SOURCE?
Because loader/pe_image.c needs it to define u_short.
Maybe we should just get rid of these non-standard types then... Diego
Hi! Diego Biurrun <diego <at> biurrun.de> writes:
Why _BSD_SOURCE?
Because loader/pe_image.c needs it to define u_short.
Maybe we should just get rid of these non-standard types then...
Unfortunately, that doesn't help with declarations of alloca() and getpagesize(). Patch applied, Carl Eugen
participants (5)
-
Carl Eugen Hoyos -
Carl Eugen Hoyos -
Diego Biurrun -
Guillaume POIRIER -
Reimar Döffinger