Hi All. I am created a patch mplayer and gmplayer to using dvd menu. Implemented: - still frame menu (partially) - spu menu buttons (partially) - can be used mouse with menu selection (partially) - simple light box menu button (new OSDTYPE) - time length of vts domain stream - can be selection the subtitle language with "vobsub_lang" command ('j') - can be dvd menu trought set audio and subtitle languages - new menu item in gmplayer (in gtk menu) - can be set dvd menu languages The patch is big (185 kbyte), hence donwload this about link: http://members.chello.hu/dc/mplayer/ (I am sorry to say that my English knowledge isn't good.) Best regards! Attila
On Mon, Dec 19, 2005 at 02:46:50AM +0100, Ötvös Attila wrote:
Hi All.
I am created a patch mplayer and gmplayer to using dvd menu.
Nice work, havent reviewed them, but I'll give it a try this week ;) Reynaldo
Hi Reynaldo, On 12/19/05, Reynaldo H. Verdejo Pinochet <reynaldo@opendot.cl> wrote:
On Mon, Dec 19, 2005 at 02:46:50AM +0100, Ötvös Attila wrote:
Hi All.
I am created a patch mplayer and gmplayer to using dvd menu.
Nice work, havent reviewed them, but I'll give it a try this week ;)
So, does it work as expected? Guillaume -- Life is pleasant. Death is peaceful. It's the transition that's troublesome. Isaac Asimov (1920 - 1992) MPlayer's doc is offline. Find some fresh one here: http://tuxrip.free.fr//MPlayer-DOCS-HTML/en/ http://tuxrip.free.fr//MPlayer-DOCS-HTML/fr/
On Wed, 21 Dec 2005 16:58:01 +0100 Guillaume POIRIER <poirierg@gmail.com> wrote:
Hi Reynaldo,
On 12/19/05, Reynaldo H. Verdejo Pinochet <reynaldo@opendot.cl> wrote:
On Mon, Dec 19, 2005 at 02:46:50AM +0100, Ötvös Attila wrote:
Hi All.
I am created a patch mplayer and gmplayer to using dvd menu.
Nice work, havent reviewed them, but I'll give it a try this week ;)
So, does it work as expected?
Nope, but i consider it a bit nasty that someone who introduces a patch with potential support for the biggest drawback of MPlayer doesn't get any feedback ... Whatever, i've tested the patch quickly and it appears the following : - first dvd i've tried : the menu is displayed but once reached, instead of displaying a still picture waiting for user interaction, the stream continues and so does the movie begin to play. - second dvd i've tried : the dvd fbi bullshit warning si displayed and once it should have reached the main menu, dvdnav receives a DVDNAV_STOP event and then MPlayer quits. So basically it doesn't work for me at least on the few DVDs i've tested. Nontheless, a patch is here and partly does its job so someone may consider looking at it more deeply. It really would be a shame to drop it imho. BTW, does MPlayer still have a DVD-related code maintainer ? Ben -- "My life, and by extension everyone else's is meaningless." Bender, Futurama
On Wed, 21 Dec 2005 18:21:29 +0100 Benjamin Zores <ben@tutuxclan.org> wrote:
On Wed, 21 Dec 2005 16:58:01 +0100 Guillaume POIRIER <poirierg@gmail.com> wrote:
Hi Reynaldo,
On 12/19/05, Reynaldo H. Verdejo Pinochet <reynaldo@opendot.cl> wrote:
On Mon, Dec 19, 2005 at 02:46:50AM +0100, Ötvös Attila wrote:
Hi All.
I am created a patch mplayer and gmplayer to using dvd menu.
Nice work, havent reviewed them, but I'll give it a try this week ;)
So, does it work as expected?
Nope, but i consider it a bit nasty that someone who introduces a patch with potential support for the biggest drawback of MPlayer doesn't get any feedback ...
agree :-) i'll try the patch me too in these days, to see if other issues are present/if the ones already pointed out by you are easy to adjust
On Wed, Dec 21, 2005 at 06:21:29PM +0100, Benjamin Zores wrote:
On Wed, 21 Dec 2005 16:58:01 +0100 Guillaume POIRIER <poirierg@gmail.com> wrote:
Hi Reynaldo,
On 12/19/05, Reynaldo H. Verdejo Pinochet <reynaldo@opendot.cl> wrote:
On Mon, Dec 19, 2005 at 02:46:50AM +0100, Ötvös Attila wrote:
Hi All.
I am created a patch mplayer and gmplayer to using dvd menu.
Nice work, havent reviewed them, but I'll give it a try this week ;)
So, does it work as expected?
Nope, but i consider it a bit nasty that someone who introduces a patch with potential support for the biggest drawback of MPlayer doesn't get any feedback ...
I agree, although I dont consider it a drawback but a nice feature a lot of users wish for.
Whatever, i've tested the patch quickly and it appears the following :
nice
- first dvd i've tried : the menu is displayed but once reached, instead of displaying a still picture waiting for user interaction, the stream continues and so does the movie begin to play. - second dvd i've tried : the dvd fbi bullshit warning si displayed and once it should have reached the main menu, dvdnav receives a DVDNAV_STOP event and then MPlayer quits.
So basically it doesn't work for me at least on the few DVDs i've tested. Nontheless, a patch is here and partly does its job so someone may consider looking at it more deeply.
I wish i could this week.
It really would be a shame to drop it imho.
I agree.
BTW, does MPlayer still have a DVD-related code maintainer ?
AFAIK, no, however I have seen Diego working with libmpdvdkit2 lately. Best regards Reynaldo
Re,
Nope, but i consider it a bit nasty that someone who introduces a patch with potential support for the biggest drawback of MPlayer doesn't get any feedback ...
I agree, although I dont consider it a drawback but a nice feature a lot of users wish for.
I guess, the lack of a dvd-nav is meant as drawback ;) bye, hco
2005. december 21. 18.21 dátummal Benjamin Zores ezt írta:
Whatever, i've tested the patch quickly and it appears the following : - first dvd i've tried : the menu is displayed but once reached, instead of displaying a still picture waiting for user interaction, the stream continues and so does the movie begin to play. - second dvd i've tried : the dvd fbi bullshit warning si displayed and once it should have reached the main menu, dvdnav receives a DVDNAV_STOP event and then MPlayer quits.
if append "#define TRACE" line on libmpdvdkit2\dvdnav_internal.h then print message most likely: libdvdnav: play_Cell_post: (vm->state).cellN (1) libdvdnav: last cell in this PGC libdvdnav: play_PGC_post: libdvdnav: ** Fell of the end of the pgc, continuing in NextPGC libdvdnav: ** No such pgcN = 0 libdvdnav: Before printout starts: libdvdnav: Exit libmpdvdkiv2/vm.c(1177): ------------------------------- static link_t play_PGC_post(vm_t *vm) { link_t link_values; ... printf("(vm->state).pgc->command_tbl: %p\n",(vm->state).pgc->command_tbl); if((vm->state).pgc->command_tbl && (vm->state).pgc->command_tbl->nr_of_post && vmEval_CMD((vm->state).pgc->command_tbl->post_cmds, (vm->state).pgc->command_tbl->nr_of_post, &(vm->state).registers, &link_values)) { return link_values; } ... /* Should end up in the STOP_DOMAIN if next_pgc is 0. */ if(!set_PGCN(vm, (vm->state).pgc->next_pgc_nr)) { link_values.command = Exit; return link_values; } return play_PGC(vm); } most likely: (vm->state).pgc->command_tbl is NULL and (vm->state).pgc->next_pgc_nr is 0. Why? I don't know. :-( (I am sorry to say that my English knowledge isn't good.) Best regards! Attila
On Wed, Dec 21, 2005 at 04:58:01PM +0100, Guillaume POIRIER wrote:
Hi Reynaldo,
On 12/19/05, Reynaldo H. Verdejo Pinochet <reynaldo@opendot.cl> wrote:
On Mon, Dec 19, 2005 at 02:46:50AM +0100, Ötvös Attila wrote:
Hi All.
I am created a patch mplayer and gmplayer to using dvd menu.
Nice work, havent reviewed them, but I'll give it a try this week ;)
So, does it work as expected?
havent tried it yet :|
Guillaume
Reynaldo
On Mon, Dec 19, 2005 at 02:46:50AM +0100, ?tv?s Attila wrote:
I am created a patch mplayer and gmplayer to using dvd menu.
Implemented: - still frame menu (partially) - spu menu buttons (partially) - can be used mouse with menu selection (partially) - simple light box menu button (new OSDTYPE) - time length of vts domain stream - can be selection the subtitle language with "vobsub_lang" command ('j') - can be dvd menu trought set audio and subtitle languages - new menu item in gmplayer (in gtk menu) - can be set dvd menu languages
Wow, this looks like quite a feat! I've patched it into my test tree to try it out (I had to --disable-live at configure time, but that's minor for the moment) and indeed a DVD menu comes up.. But how do I interact with it? Diego
On Fri, Dec 23, 2005 at 03:07:04AM +0100, Diego Biurrun wrote:
On Mon, Dec 19, 2005 at 02:46:50AM +0100, ?tv?s Attila wrote:
I am created a patch mplayer and gmplayer to using dvd menu.
Implemented: - still frame menu (partially) - spu menu buttons (partially) - can be used mouse with menu selection (partially) - simple light box menu button (new OSDTYPE) - time length of vts domain stream - can be selection the subtitle language with "vobsub_lang" command ('j') - can be dvd menu trought set audio and subtitle languages - new menu item in gmplayer (in gtk menu) - can be set dvd menu languages
Wow, this looks like quite a feat!
I've patched it into my test tree to try it out (I had to --disable-live at configure time, but that's minor for the moment) and indeed a DVD menu comes up.. But how do I interact with it?
OK, works with the mouse when using GMPlayer. Still frames still seem to be problematic, though. Diego
On Fri, Dec 23, 2005 at 03:10:55AM +0100, Diego Biurrun wrote:
On Fri, Dec 23, 2005 at 03:07:04AM +0100, Diego Biurrun wrote:
On Mon, Dec 19, 2005 at 02:46:50AM +0100, ?tv?s Attila wrote:
I am created a patch mplayer and gmplayer to using dvd menu.
Implemented: - still frame menu (partially) - spu menu buttons (partially) - can be used mouse with menu selection (partially) - simple light box menu button (new OSDTYPE) - time length of vts domain stream - can be selection the subtitle language with "vobsub_lang" command ('j') - can be dvd menu trought set audio and subtitle languages - new menu item in gmplayer (in gtk menu) - can be set dvd menu languages
Wow, this looks like quite a feat!
I've patched it into my test tree to try it out (I had to --disable-live at configure time, but that's minor for the moment) and indeed a DVD menu comes up.. But how do I interact with it?
OK, works with the mouse when using GMPlayer. Still frames still seem to be problematic, though.
Do you plan on fixing these issues? Diego
2006. január 2. 16.33 dátummal Diego Biurrun ezt írta:
On Fri, Dec 23, 2005 at 03:10:55AM +0100, Diego Biurrun wrote:
On Fri, Dec 23, 2005 at 03:07:04AM +0100, Diego Biurrun wrote:
On Mon, Dec 19, 2005 at 02:46:50AM +0100, ?tv?s Attila wrote:
I am created a patch mplayer and gmplayer to using dvd menu.
Implemented: - still frame menu (partially) - spu menu buttons (partially) - can be used mouse with menu selection (partially) - simple light box menu button (new OSDTYPE) - time length of vts domain stream - can be selection the subtitle language with "vobsub_lang" command ('j') - can be dvd menu trought set audio and subtitle languages - new menu item in gmplayer (in gtk menu) - can be set dvd menu languages
Wow, this looks like quite a feat!
I've patched it into my test tree to try it out (I had to --disable-live at configure time, but that's minor for the moment) and indeed a DVD menu comes up.. But how do I interact with it?
OK, works with the mouse when using GMPlayer. Still frames still seem to be problematic, though.
Do you plan on fixing these issues?
Diego
_______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
The dvdnav handler is bad in mplayer.c and in several case it passes in the dvdnav event in the course of processing of the demuxer_seek(). I found out DVDNAV_STOP event error, that it happenes if at the given program entry hasn't command table present. The new dvdnav patch: http://members.chello.hu/dc/mplayer/ Main modifications (compared with old patch): - libdvdnav & dvdnav_stream were packed in the stream_dvdnav (so that cab be used: --disable-mpdvdkit2 options) - dvdnav handle is an error and I corrected it in mplayer.c (demuxer_seek()) - dvdnav STOP_EVENT is an error and I corrected it - remove demuxer->event structure (I am sorry to say that my English knowledge isn't good.) Best regards! Attila
On Tue, Jan 03, 2006 at 08:21:45PM +0100, Ötvös Attila wrote:
2006. január 2. 16.33 dátummal Diego Biurrun ezt írta:
Do you plan on fixing these issues?
The dvdnav handler is bad in mplayer.c and in several case it passes in the dvdnav event in the course of processing of the demuxer_seek().
I found out DVDNAV_STOP event error, that it happenes if at the given program entry hasn't command table present.
The new dvdnav patch:
http://members.chello.hu/dc/mplayer/
Main modifications (compared with old patch):
- libdvdnav & dvdnav_stream were packed in the stream_dvdnav (so that cab be used: --disable-mpdvdkit2 options) - dvdnav handle is an error and I corrected it in mplayer.c (demuxer_seek()) - dvdnav STOP_EVENT is an error and I corrected it - remove demuxer->event structure
Here is some more feedback. Compilation fails if Live555 (used to be called LIVE.COM) is enabled: cc -c -I../libvo -I../../libvo -I/usr/X11R6/include -g -O4 -maltivec -mabi=altivec -pipe -ffast-math -fomit-frame-pointer -D_REENTRANT -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I.. -I../loader -I../libavutil -I../libavcodec -I../libavformat -I/usr/local/live/liveMedia/include -I/usr/local/live/UsageEnvironment/include -I/usr/local/live/BasicUsageEnvironment/include -I/usr/local/live/groupsock/include -o demux_rtp.o demux_rtp.cpp stream_dvdnav.h:1053: error: expected ',' or '...' before 'this' stream_dvdnav.h:1062: error: expected ',' or '...' before 'this' make[1]: *** [demux_rtp.o] Error 1 make[1]: Leaving directory `/home/diego/src/mplayer/vanilla/libmpdemux' make: *** [libmpdemux/libmpdemux.a] Error 2 Some more issues: - Language selection does not appear to work. When I select a different language in a menu, the movie does not start. - Sometimes items in menus are highlighted if the mouse/cursor is above them, sometimes not. - With gmplayer in the small movie that is played before the real menu comes up, if I move the mouse I get annoying "Not in a menu." error messages on the console *and* as popups. - On startup with gmplayer I get the error message "Virtual DVD machine not started" or "Bad VM state." on the console and as popup. - Some menus still fail to work at all. I don't want to sound too negative, this revision is working much better than the last one already, keep up the good work!
(I am sorry to say that my English knowledge isn't good.)
Don't worry, it's perfectly acceptable. Diego
2006. január 6. 15.29 dátummal Diego Biurrun ezt írta:
Here is some more feedback.
Compilation fails if Live555 (used to be called LIVE.COM) is enabled:
cc -c -I../libvo -I../../libvo -I/usr/X11R6/include -g -O4 -maltivec -mabi=altivec -pipe -ffast-math -fomit-frame-pointer -D_REENTRANT -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I.. -I../loader -I../libavutil -I../libavcodec -I../libavformat -I/usr/local/live/liveMedia/include -I/usr/local/live/UsageEnvironment/include -I/usr/local/live/BasicUsageEnvironment/include -I/usr/local/live/groupsock/include -o demux_rtp.o demux_rtp.cpp stream_dvdnav.h:1053: error: expected ',' or '...' before 'this' stream_dvdnav.h:1062: error: expected ',' or '...' before 'this' make[1]: *** [demux_rtp.o] Error 1 make[1]: Leaving directory `/home/diego/src/mplayer/vanilla/libmpdemux' make: *** [libmpdemux/libmpdemux.a] Error 2
--- libmpdemux/stream_dvdnav.h 2006-01-06 16:38:19.000000000 +0100 +++ libmpdemux/stream_dvdnav.h 2006-01-06 16:40:05.000000000 +0100 @@ -1050,7 +1050,7 @@ int8_t dvdnav_get_audio_logical_stream(dvdnav_t *self, uint8_t audio_num); #ifdef USE_MPDVDNAV -dvdnav_status_t dvdnav_get_audio_attr(dvdnav_t *this, uint8_t audio_mum, audio_attr_t *audio_attr); +dvdnav_status_t dvdnav_get_audio_attr(dvdnav_t *self, uint8_t audio_mum, audio_attr_t *audio_attr); #endif /* @@ -1059,7 +1059,7 @@ int8_t dvdnav_get_spu_logical_stream(dvdnav_t *self, uint8_t subp_num); #ifdef USE_MPDVDNAV -dvdnav_status_t dvdnav_get_spu_attr(dvdnav_t *this, uint8_t audio_mum, subp_attr_t *subp_attr); +dvdnav_status_t dvdnav_get_spu_attr(dvdnav_t *self, uint8_t audio_mum, subp_attr_t *subp_attr); #endif /*
Some more issues:
- Language selection does not appear to work. When I select a different language in a menu, the movie does not start.
My question: After the selection of the language if the playing didn't start automatically or the selection of the language interfered with the playing.
- Sometimes items in menus are highlighted if the mouse/cursor is above them, sometimes not. - With gmplayer in the small movie that is played before the real menu comes up, if I move the mouse I get annoying "Not in a menu." error messages on the console *and* as popups.
--- libmpdemux/stream_dvdnav.c 2006-01-03 23:04:33.000000000 +0100 +++ libmpdemux/stream_dvdnav.c 2006-01-06 18:49:23.000000000 +0100 @@ -6334,8 +6334,9 @@ dvdnav_mouse_orig_x=dvdnav_mouse_x; dvdnav_mouse_orig_y=dvdnav_mouse_y; } + if (pnavpci->hli.hl_gi.btn_ns) { /* is buttons */ dvdnav_mouse_select(dvdnav_priv->dvdnav, pnavpci, dvdnav_mouse_orig_x, dvdnav_mouse_orig_y); /* mouse position select */ - if (dvdnav_mouse_button) dvdnav_menu_action(dvdnav_priv, MP_CMD_DVDNAV_SELECT); /* mouse button event */ + if (dvdnav_mouse_button) dvdnav_menu_action(dvdnav_priv, MP_CMD_DVDNAV_SELECT); } /* mouse button event */ dvdnav_mouse_set=0; dvdnav_mouse_button=0; return;
- On startup with gmplayer I get the error message "Virtual DVD machine not started" or "Bad VM state." on the console and as popup.
-- libmpdemux/stream_dvdnav.c 2006-01-03 23:04:33.000000000 +0100 +++ libmpdemux/stream_dvdnav.c 2006-01-06 18:44:38.000000000 +0100 @@ -6105,7 +6105,7 @@ } #endif dvdnav_priv_t* dvdnav_priv=s->priv; - int domain_vts=dvdnav_is_domain_vts(dvdnav_priv->dvdnav); + int domain_vts=dvdnav_priv->vts_domain; if(newpos!=s->pos) { if (!domain_vts) mp_msg(MSGT_STREAM,MSGL_V,"Cannot seek in DVDNAV streams yet!\n"); else { @@ -6457,8 +6457,10 @@ dvdnav_priv->vts_domain=dvdnav_is_domain_vts(dvdnav_priv->dvdnav); dvdnav_get_position(dvdnav_priv->dvdnav, &(dvdnav_priv->tpos), &(dvdnav_priv->tlen)); dvdnav_get_number_of_titles(dvdnav_priv->dvdnav, &(dvdnav_priv->titles_nr)); - dvdnav_current_title_info(dvdnav_priv->dvdnav, &dvdnav_priv->title, &dvdnav_priv->part); + dvdnav_priv->part=0; + dvdnav_priv->title=0; if (!(dvdnav_priv->vts_domain)) dvdnav_priv->chapters_nr=0; else { + dvdnav_current_title_info(dvdnav_priv->dvdnav, &dvdnav_priv->title, &dvdnav_priv->part); dvdnav_get_number_of_parts(dvdnav_priv->dvdnav, dvdnav_priv->title, &dvdnav_priv->chapters_nr); uint32_t audio_id;
- Some menus still fail to work at all.
I think the greatest problem is at the handling of the DVD NAV menu if there are few video packet and a large number of audio packet in gicen pgc. In this case the audio packets determine the playing of the time of pgc. The video packet showes up at first frame and then it will be unchanged. I suspect the demuxer reades the first video and audio packets then it tries to read the next video packets but from of this there isn't more therefore the demuxers reades the audio packets long before it must be. Therefore the mplayer does the processing of the menu in an instant that takes long secondes (eg.: 40 sec). I am trying to find the solution so that the demuxer will be read at stated intervals from dvdnav stream if it hasn't any video packets. I hope the solution will solve most menu handling problems and the modify of the ds_fill_buffer in demuxer.c will be dropped out. The backlink was a faulty trial in the stream_dvdnav.c.
I don't want to sound too negative, this revision is working much better than the last one already, keep up the good work!
(I am sorry to say that my English knowledge isn't good.)
Don't worry, it's perfectly acceptable.
Diego
Best regards! Attila
On Sat, Jan 07, 2006 at 09:17:30PM +0100, Ötvös Attila wrote:
2006. január 6. 15.29 dátummal Diego Biurrun ezt írta:
Here is some more feedback.
Some more issues:
- Language selection does not appear to work. When I select a different language in a menu, the movie does not start.
My question: After the selection of the language if the playing didn't start automatically or the selection of the language interfered with the playing.
Sorry, it seems that the DVD I tested with was broken.. Could you please update your patch, fishing out the changes from your mail is tedious since your mailer broke them... I'll retest the next version, it seems that you fixed most of the issues I mentioned :-) Diego
2006. január 7. 23.01 dátummal Diego Biurrun ezt írta:
Could you please update your patch, fishing out the changes from your mail is tedious since your mailer broke them...
I am sorry, I didn't pay attention to it. Mail attachment or: http://members.chello.hu/dc/mplayer Best regards! Attila
On Sun, Jan 08, 2006 at 11:43:43AM +0100, Ötvös Attila wrote:
2006. január 7. 23.01 dátummal Diego Biurrun ezt írta:
Could you please update your patch, fishing out the changes from your mail is tedious since your mailer broke them...
I am sorry, I didn't pay attention to it.
Mail attachment or: http://members.chello.hu/dc/mplayer
OK, an updated version of your patch would probably be easier, though. Now I sometimes get double frees that crash gmplayer: *** glibc detected *** free(): invalid pointer: 0x108a1cf8 *** Also, with gmplayer I often get DVDNAV stream seek error: (0) error popups. Let me know if you cannot reproduce this. Diego
2006. január 8. 14.11 dátummal Diego Biurrun ezt írta:
OK, an updated version of your patch would probably be easier, though.
Now I sometimes get double frees that crash gmplayer:
*** glibc detected *** free(): invalid pointer: 0x108a1cf8 ***
I met with this error not once but there is cause for alarm.
Also, with gmplayer I often get
DVDNAV stream seek error: (0)
error popups.
Let me know if you cannot reproduce this.
The new patch has already worked with my all the test DVDs now: http://members.chello.hu/dc/mplayer Best regards! Attila
On Monday, 09 January 2006 at 22:29, Ötvös Attila wrote:
2006. január 8. 14.11 dátummal Diego Biurrun ezt írta:
OK, an updated version of your patch would probably be easier, though.
Now I sometimes get double frees that crash gmplayer:
*** glibc detected *** free(): invalid pointer: 0x108a1cf8 ***
I met with this error not once but there is cause for alarm.
Also, with gmplayer I often get
DVDNAV stream seek error: (0)
error popups.
Let me know if you cannot reproduce this.
The new patch has already worked with my all the test DVDs now:
First, let me congratulate you on achieving something many people thought impossible with current MPlayer design. Second, your patch works for me just fine, I'm really amazed. Third, there's a small problem: if I apply the patch, but don't specify --enable-dvdnav for ./configure, MPlayer build fails with: mplayer.c:2249: error: ‘dvdnav_go_spu’ undeclared (first use in this function) Please bear with us a little more and fix this. It probably involves putting #ifdef DVDNAV or something similar around the new code and adding appropriate code to ./configure. Regards, R. -- MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/ "I am Grey. I stand between the candle and the star. We are Grey. We stand between the darkness ... and the light." -- Delenn in Grey Council in Babylon 5:"Babylon Squared"
2006. január 14. 04.49 dátummal Dominik 'Rathann' Mierzejewski ezt írta:
First, let me congratulate you on achieving something many people thought impossible with current MPlayer design.
Second, your patch works for me just fine, I'm really amazed.
Third, there's a small problem: if I apply the patch, but don't specify --enable-dvdnav for ./configure, MPlayer build fails with: mplayer.c:2249: error: ‘dvdnav_go_spu’ undeclared (first use in this function)
I am revised it.
Please bear with us a little more and fix this. It probably involves putting #ifdef DVDNAV or something similar around the new code and adding appropriate code to ./configure.
Regards, R.
In this dvdnav patch the waiting time length at still frame event was implemented. I am sorry, my ISP lost my web pages because I created other web pages: http://dcxx.fw.hu (I am sorry to say that my English knowledge isn't good.) Best regards! Attila
Hi, On Saturday, 21 January 2006 at 15:45, Ötvös Attila wrote:
2006. január 14. 04.49 dátummal Dominik 'Rathann' Mierzejewski ezt írta:
First, let me congratulate you on achieving something many people thought impossible with current MPlayer design.
Second, your patch works for me just fine, I'm really amazed.
Third, there's a small problem: if I apply the patch, but don't specify --enable-dvdnav for ./configure, MPlayer build fails with: mplayer.c:2249: error: ‘dvdnav_go_spu’ undeclared (first use in this function)
I am revised it.
Tested again, this time with GiTS R0 Polish re-release and noticed the following problems: In GUI, I'm constantly getting "DVDNAV stream seek error:0" after every title switch.
From command line, mouse navigation doesn't work at all: No bind found for key 'MOUSE_BTN0'
Aspect ration of the main title/movie is not correct. Menu is 4:3 but movie is 16:9 and it doesn't get switched. In the preferences screen, the settings texts are duplicated below. My guess is that these are their "inactive" versions. It doesn't prevent preferences from working, but is a bit confusing. Other than that, it seems mostly fine.
Please bear with us a little more and fix this. It probably involves putting #ifdef DVDNAV or something similar around the new code and adding appropriate code to ./configure.
In this dvdnav patch the waiting time length at still frame event was implemented.
After applying the patch and NOT using --enable-dvdnav, MPlayer still fails to compile, so this is still not fixed. Good work so far. Amazing, really, but please bear with us a bit longer and try to fix the above.
I am sorry, my ISP lost my web pages because I created other web pages:
(I am sorry to say that my English knowledge isn't good.)
Please, stop apologizing, it's good enough. Best regards, R. -- MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/ "I am Grey. I stand between the candle and the star. We are Grey. We stand between the darkness ... and the light." -- Delenn in Grey Council in Babylon 5:"Babylon Squared"
2006. január 27. 00.07 dátummal Dominik 'Rathann' Mierzejewski ezt írta:
Tested again, this time with GiTS R0 Polish re-release and noticed the following problems:
In GUI, I'm constantly getting "DVDNAV stream seek error:0" after every title switch.
I am traying to mend it.
From command line, mouse navigation doesn't work at all: No bind found for
key 'MOUSE_BTN0'
The cause of the console mode would need the query of the window's current size and mouse's position. Can this use with vo eg. framebuffer mode?
Aspect ration of the main title/movie is not correct. Menu is 4:3 but movie is 16:9 and it doesn't get switched.
I am trying to mend it.
In the preferences screen, the settings texts are duplicated below. My guess is that these are their "inactive" versions. It doesn't prevent preferences from working, but is a bit confusing.
You can work out the DVD and DVDNAV menus, but there is difference in the processing: The case of the DVD the after choosing audio or subtitle the playing startes afresh (This time it reopens the DVD stream). Probably couldn't change during the playing formerly, but think this isn't the best solution. My questions: - Do I modify this part that without restarting I can choise the audio or the subtitle? - Do I close up the DVD and the DVDNAV menus so that the GUI hasn't the double menu.
Other than that, it seems mostly fine.
Please bear with us a little more and fix this. It probably involves putting #ifdef DVDNAV or something similar around the new code and adding appropriate code to ./configure.
In this dvdnav patch the waiting time length at still frame event was implemented.
After applying the patch and NOT using --enable-dvdnav, MPlayer still fails to compile, so this is still not fixed.
Does this error come up at the translation of the mplayer.c?
Good work so far. Amazing, really, but please bear with us a bit longer and try to fix the above.
Best regards! Attila
On Sat, Jan 21, 2006 at 03:45:43PM +0100, Ötvös Attila wrote:
In this dvdnav patch the waiting time length at still frame event was implemented.
Yes, this revision seems to be handling still frames better. However, with my Rush Hour DVD, I suddenly get no sound in the menu. This worked before. Another thing that was present before already: The menu "highlights" (for lack of a better word), the areas that light up if up pass over them with the mouse, are a different color than in xine or the Apple DVD player. Don't let this demotivate you, your patch seems to be making some progress, I look forward to the day this gets committed to CVS.
(I am sorry to say that my English knowledge isn't good.)
Please don't apologize, your English is fine. Diego
2006. január 27. 01.53 dátummal Diego Biurrun ezt írta:
Yes, this revision seems to be handling still frames better. However, with my Rush Hour DVD, I suddenly get no sound in the menu. This worked before.
I am looking at the problem of the voice.
Another thing that was present before already: The menu "highlights" (for lack of a better word), the areas that light up if up pass over them with the mouse, are a different color than in xine or the Apple DVD player.
Yes, I signed it in he guide too: the colours of the SPU menu aren't correct. The problem is in either palette ot the ambit of the draw_alpha (in the decspu.c) I haven't found out it yet. Best regards! Attila
Fixed (I hope so working): - DVDNAV stream seek error:0 - Menu & Movie aspect ratio - build with not using --enable-dvdnav - Menu sound - "watch dog" in wait event handler New options: -dvdnav-newwin: if vts change event then close current vo window and open new vo window (default) -dvdnav-nonewwin: if vts change event then continue play in current vo window http://dcxx.fw.hu/ Best regards! Attila
Ötvös Attila wrote:
Fixed (I hope so working):
- DVDNAV stream seek error:0 - Menu & Movie aspect ratio - build with not using --enable-dvdnav - Menu sound - "watch dog" in wait event handler
New options:
-dvdnav-newwin: if vts change event then close current vo window and open new vo window (default) -dvdnav-nonewwin: if vts change event then continue play in current vo window
Best regards! Attila
Hi, I'm impressed by your effort, but I wish you would fix some fundamental issues before going on: - the patch below is not acceptable because 1) it reintroduces demuxer-specific code in demuxer.c (that we worked hard to clean) and 2) it's a huge hack. You can get something similar but cleaner implementing a new DEMUXER_CTRL call. --- libmpdemux/demuxer.c 2006-01-17 21:04:49.000000000 +0100 +++ libmpdemux/demuxer.c 2006-01-27 22:40:17.000000000 +0100 @@ -370,6 +373,19 @@ --ds->packs; return 1; //ds->buffer_size; } +#ifdef USE_MPDVDNAV + if(demux->stream->type==STREAMTYPE_DVDNAV && ( + (dvdnav_isevent_lock((dvdnav_priv_t*)(demux->stream->priv)) && ds==demux->video && (demux->audio->packs>=128)) || /* slow wait max= 4096 : only stream length time query max=128 */ [snip] - I'm sure you can clean and place decode_video_still() in a custom decoder (maybe something like libmpcodecs/vd_videostill.c) - the biggest one: stream_dvdnav.c seems to be the whole libdvdnav unrolled in one file + mplayer's specific stream code. If so, it's not acceptable, either. Can't you simply link to the official libdvdnav? If not (yet), try to get your patches applied by the maintaner of the library or remove your additions. In any case I'm against importing dvdnav in mplayer (especially in this all-in-one form). BTW, since the current dvdnav code is hopelessly broken why don't we remove it completely? Thanks, Nico
2006. január 28. 09.26 dátummal Nico Sabbi ezt írta:
- the patch below is not acceptable because 1) it reintroduces demuxer-specific code in demuxer.c (that we worked hard to clean) and 2) it's a huge hack. You can get something similar but cleaner implementing a new DEMUXER_CTRL call.
--- libmpdemux/demuxer.c 2006-01-17 21:04:49.000000000 +0100 +++ libmpdemux/demuxer.c 2006-01-27 22:40:17.000000000 +0100 @@ -370,6 +373,19 @@ --ds->packs; return 1; //ds->buffer_size; } +#ifdef USE_MPDVDNAV + if(demux->stream->type==STREAMTYPE_DVDNAV && ( + (dvdnav_isevent_lock((dvdnav_priv_t*)(demux->stream->priv)) && ds==demux->video && (demux->audio->packs>=128)) || /* slow wait max= 4096 : only stream length time query max=128 */
[snip]
I modified the code of the function ds_fill_buffer() in the demuxer.c. This have been more complicated because while opening of the demuxer there is needed the lower audio packet limit. Before the opening of the demuxer I can't use the DEMUXER_CTRL call.
- I'm sure you can clean and place decode_video_still() in a custom decoder (maybe something like libmpcodecs/vd_videostill.c)
I created a vd_videostill.c. I would like to know if the modify of the decode_video() function will be better in the dec_video.c because the decode_video_still() function is an expanded version of the decode_video().
- the biggest one: stream_dvdnav.c seems to be the whole libdvdnav unrolled in one file + mplayer's specific stream code. If so, it's not acceptable, either. Can't you simply link to the official libdvdnav? If not (yet), try to get your patches applied by the maintaner of the library or remove your additions. In any case I'm against importing dvdnav in mplayer (especially in this all-in-one form).
I created a libmpdvdnav directory and I moved here the suitable files from stream_dvdnav.c. Unfortunately, official libdvdnav can be used because there is needed some new functions. At first the decode of the still frame is faulty but at second it will be successful therefore the repeat of the still frame must be forced from libdvdnav. New patch: http://dcxx.fw.hu/ Best regards! Attila
2006. január 30. 18.49 dátummal Ötvös Attila ezt írta:
Fixed demux_open() error:
+ fixed dvdnav.h http://dcxx.fw.hu/ Best regards! Attila
I fixed and updated dvdnav patch with current CVS. http://dcxx.fw.hu/ Best regards! Attila
On Mon, Jan 30, 2006 at 06:49:26PM +0100, Ötvös Attila wrote:
Fixed demux_open() error:
BTW, it's easier if you directly link to http://dcxx.fw.hu/mplayer/ or even http://dcxx.fw.hu/mplayer/20060130/mplayer-dvdnav-patch.tar.gz Diego
2006. január 30. 20.21 dátummal Diego Biurrun ezt írta:
BTW, it's easier if you directly link to
or even
http://dcxx.fw.hu/mplayer/20060130/mplayer-dvdnav-patch.tar.gz
Thanks! I don't tell but I think this :-) (My regulation of the webcaster: The service mustn't be operationed from server that without page download the service can be requisitioned from other webcaster.) Best regards! Attila
On Monday, 30 January 2006 at 21:21, Ötvös Attila wrote:
2006. január 30. 20.21 dátummal Diego Biurrun ezt írta:
BTW, it's easier if you directly link to
or even
http://dcxx.fw.hu/mplayer/20060130/mplayer-dvdnav-patch.tar.gz
Thanks!
I don't tell but I think this :-)
(My regulation of the webcaster: The service mustn't be operationed from server that without page download the service can be requisitioned from other webcaster.)
I use adblock, so I don't see their stupid ads anyway. ;) I'm sure we could arrange for your patch to be hosted on Mike's multimedia.cx for the time being, right, Diego? Regards, R. -- MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/ There should be a science of discontent. People need hard times and oppression to develop psychic muscles. -- from "Collected Sayings of Muad'Dib" by the Princess Irulan
Ötvös Attila wrote:
Hi All.
I am created a patch mplayer and gmplayer to using dvd menu.
Implemented: - still frame menu (partially) - spu menu buttons (partially) - can be used mouse with menu selection (partially) - simple light box menu button (new OSDTYPE) - time length of vts domain stream - can be selection the subtitle language with "vobsub_lang" command ('j') - can be dvd menu trought set audio and subtitle languages - new menu item in gmplayer (in gtk menu) - can be set dvd menu languages
The patch is big (185 kbyte), hence donwload this about link:
http://members.chello.hu/dc/mplayer/
(I am sorry to say that my English knowledge isn't good.)
Best regards!
Attila
Hi, I gave a quick look at libdvdnav.patch and navmplayer.patch, mainly hoping to restore support for dvdnav:// stream. IMO, In their current form those patch can't be applied, these are my reasons: - why did you patch so extensively libmpdvdkit2? if it can't live with the current libdvdnav you had better change configure so that support for dvdnav be mutually exclusive with dvdread|mpdvdkit, otherwise libmpdvdkit2 will be impossible to read and to fix or keep in sync. If the reason is different explain it, please - the changes in demuxer.c in demuxer.c can't go in (recently we had a hard time modularizing and cleaning it); you had better implement those functionalities as a demuxer_ctrl() - I won't pronounce on the code in mplayer.c and in the files involved in decoding subs for obvious reasons :) Bye, Nico
2005. december 30. 13.42 dátummal Nico Sabbi ezt írta:
Hi, I gave a quick look at libdvdnav.patch and navmplayer.patch, mainly hoping to restore support for dvdnav:// stream. IMO, In their current form those patch can't be applied, these are my reasons: - why did you patch so extensively libmpdvdkit2? if it can't live with the current libdvdnav you had better change configure so that support for dvdnav be mutually exclusive with dvdread|mpdvdkit, otherwise libmpdvdkit2 will be impossible to read and to fix or keep in sync. If the reason is different explain it, please
- the changes in demuxer.c in demuxer.c can't go in (recently we had a hard time modularizing and cleaning it); you had better implement those functionalities as a demuxer_ctrl()
- I won't pronounce on the code in mplayer.c and in the files involved in decoding subs for obvious reasons :)
Bye,
Nico
I created several private DVD by menu and I wanted to try out (before writing), but the mplayer couldn't be worked by dvdnav:// stream. So I created simple patch with mplayer. Later I fixed on it so that the mplayer could use the majority of DVD buyed too. Because of these the plan wasn't manly during making of the patch, only it happened. I can follow hard the development orientation of the mplayer because of my little english knowledge. My pleasuse I expect whatever prosposal, so that the dvdnav patch will be better. New patch: libdvdnav & dvdnav_stream were packed in the stream_dvdnav (so that cab be used: --disable-mpdvdkit2 options) http://members.chello.hu/dc/mplayer/ (I am sorry to say that my English knowledge isn't good.) Best regards! Attila
I fixed init/uninit vo and updated dvdnav patch with current CVS. http://dcxx.fw.hu/ Best regards! Attila
On Sat, Feb 04, 2006 at 06:31:42PM +0100, Ötvös Attila wrote:
I fixed init/uninit vo and updated dvdnav patch with current CVS.
Hmm, with gmplayer I still get flickering Windows with the Rush Hour DVD.. Somehow this DVD seems to be a good testcase. Sound is still missing from the initial intro before the menu starts up. This worked with an older revision of your patch. Furthermore once you have selected one menu item, CPU utilization climbs up to 100%. SPU colors are still off, but you already know that. I've put a part of the VOB files on my FTP server: ftp://sandman.homedns.org/diego/video_ts/ Check them out, you'll be able to reproduce the problems, just pass the '-dvd-device /path/to/directory' option to mplayer. Diego
On Sun, Feb 05, 2006 at 03:53:48PM +0100, Diego Biurrun wrote:
I've put a part of the VOB files on my FTP server:
ftp://sandman.homedns.org/diego/video_ts/
Sorry, the correct URL is ftp://sandman.homedns.org/diego/rush_hour/ Diego
2006. február 5. 15.53 dátummal Diego Biurrun ezt írta:
Hmm, with gmplayer I still get flickering Windows with the Rush Hour DVD..
Somehow this DVD seems to be a good testcase. Sound is still missing from the initial intro before the menu starts up. This worked with an older revision of your patch. Furthermore once you have selected one menu item, CPU utilization climbs up to 100%. SPU colors are still off, but you already know that.
I fixed the audio problem. I didn't see the mentioned "get flickering windows". If the problem shows with this patch then I would like to ask you to write the problem in more detail (What kind of vo did you use?) I would like to ask helo to SPU color. I think the spudec_process_data() only works with BW mode now. I should be pleased to see ideas or proposals where I shall start. I am looking forward to hearing from you. http://dcxx.fw.hu Best regards! Attila
On Mon, Feb 06, 2006 at 12:17:34AM +0100, Ötvös Attila wrote:
2006. február 5. 15.53 dátummal Diego Biurrun ezt írta:
Hmm, with gmplayer I still get flickering Windows with the Rush Hour DVD..
Somehow this DVD seems to be a good testcase. Sound is still missing from the initial intro before the menu starts up. This worked with an older revision of your patch. Furthermore once you have selected one menu item, CPU utilization climbs up to 100%. SPU colors are still off, but you already know that.
I fixed the audio problem.
Wonderful, it works for me as well now.
I didn't see the mentioned "get flickering windows". If the problem shows with this patch then I would like to ask you to write the problem in more detail (What kind of vo did you use?)
OK, try the following steps to reproduce: gmplayer -dvd-device /path/to/rush_hour/ dvdnav:// The copyright warning flickers while the movie window disappears and reappears. I found out this is window manager specific. It happens with wmii (which I use currently), but goes away when I try with XFce. What also happens - both with mplayer and gmplayer - is that the console gets spammed with messages like VDec: vo config request - 720 x 480 (preferred colorspace: Unknown) VDec: using Planar YV12 as output csp (no 0) Movie-Aspect is 1.78:1 - prescaling to correct movie aspect. VO: [xv] 720x480 => 854x480 Planar YV12 that go away once the copyright warning stops. Maybe this is related? Diego
On Mon, Feb 06, 2006 at 03:28:27AM +0100, Diego Biurrun wrote:
On Mon, Feb 06, 2006 at 12:17:34AM +0100, Ötvös Attila wrote:
2006. február 5. 15.53 dátummal Diego Biurrun ezt írta:
Hmm, with gmplayer I still get flickering Windows with the Rush Hour DVD..
Somehow this DVD seems to be a good testcase. Sound is still missing from the initial intro before the menu starts up. This worked with an older revision of your patch. Furthermore once you have selected one menu item, CPU utilization climbs up to 100%. SPU colors are still off, but you already know that.
I fixed the audio problem.
Wonderful, it works for me as well now.
I didn't see the mentioned "get flickering windows". If the problem shows with this patch then I would like to ask you to write the problem in more detail (What kind of vo did you use?)
OK, try the following steps to reproduce:
gmplayer -dvd-device /path/to/rush_hour/ dvdnav://
The copyright warning flickers while the movie window disappears and reappears. I found out this is window manager specific. It happens with wmii (which I use currently), but goes away when I try with XFce.
What also happens - both with mplayer and gmplayer - is that the console gets spammed with messages like
VDec: vo config request - 720 x 480 (preferred colorspace: Unknown) VDec: using Planar YV12 as output csp (no 0) Movie-Aspect is 1.78:1 - prescaling to correct movie aspect. VO: [xv] 720x480 => 854x480 Planar YV12
that go away once the copyright warning stops. Maybe this is related?
Are you using -fixed-vo? In any case it sounds like this is the problem: reinitializing the vo again and again. We need to do something so the config request gets blocked if the new mode is the same as the old one. Rich
On Sun, Feb 05, 2006 at 09:41:42PM -0500, Rich Felker wrote:
On Mon, Feb 06, 2006 at 03:28:27AM +0100, Diego Biurrun wrote:
OK, try the following steps to reproduce:
gmplayer -dvd-device /path/to/rush_hour/ dvdnav://
The copyright warning flickers while the movie window disappears and reappears. I found out this is window manager specific. It happens with wmii (which I use currently), but goes away when I try with XFce.
What also happens - both with mplayer and gmplayer - is that the console gets spammed with messages like
VDec: vo config request - 720 x 480 (preferred colorspace: Unknown) VDec: using Planar YV12 as output csp (no 0) Movie-Aspect is 1.78:1 - prescaling to correct movie aspect. VO: [xv] 720x480 => 854x480 Planar YV12
that go away once the copyright warning stops. Maybe this is related?
Are you using -fixed-vo? In any case it sounds like this is the problem: reinitializing the vo again and again. We need to do something so the config request gets blocked if the new mode is the same as the old one.
No, I don't use -fixed-vo. Diego
On Mon, Feb 06, 2006 at 04:09:53AM +0100, Diego Biurrun wrote:
On Sun, Feb 05, 2006 at 09:41:42PM -0500, Rich Felker wrote:
On Mon, Feb 06, 2006 at 03:28:27AM +0100, Diego Biurrun wrote:
OK, try the following steps to reproduce:
gmplayer -dvd-device /path/to/rush_hour/ dvdnav://
The copyright warning flickers while the movie window disappears and reappears. I found out this is window manager specific. It happens with wmii (which I use currently), but goes away when I try with XFce.
What also happens - both with mplayer and gmplayer - is that the console gets spammed with messages like
VDec: vo config request - 720 x 480 (preferred colorspace: Unknown) VDec: using Planar YV12 as output csp (no 0) Movie-Aspect is 1.78:1 - prescaling to correct movie aspect. VO: [xv] 720x480 => 854x480 Planar YV12
that go away once the copyright warning stops. Maybe this is related?
Are you using -fixed-vo? In any case it sounds like this is the problem: reinitializing the vo again and again. We need to do something so the config request gets blocked if the new mode is the same as the old one.
No, I don't use -fixed-vo.
Try it and see if the problem goes away. BTW -fixed-vo is recommended to always be used unless you're using a broken old vo driver that crashes with it. Rich
Rich Felker wrote:
On Mon, Feb 06, 2006 at 04:09:53AM +0100, Diego Biurrun wrote:
On Sun, Feb 05, 2006 at 09:41:42PM -0500, Rich Felker wrote:
Are you using -fixed-vo? In any case it sounds like this is the problem: reinitializing the vo again and again. We need to do something so the config request gets blocked if the new mode is the same as the old one.
No, I don't use -fixed-vo.
Try it and see if the problem goes away. BTW -fixed-vo is recommended to always be used unless you're using a broken old vo driver that crashes with it.
To always be used with everything, or just with streams which are supposed to be multiple segments of the same thing? (Also, where is this recommended? I don't see any such note in the docs, and in fact -fixed-vo is described as beta code in the man page.) I have groups of files - music videos and the like - which I like to play back in semi-random order, and if I use -fixed-vo then very frequently when going from one file to another I will either see only part of the image (if the new file had a larger resolution), or see a bright blue background around the video (if the new file had a smaller resolution). Nothing I've done has been able to track down where the blue is coming from, and I've mostly just decided that it's an inherent side effect of using a "fixed" (i.e. invariant) video-out method; -fixed-vo does not appear to be compatible with playing multiple consecutive files with different resolutions. (For the record, in case anyone cares enough for it to matter, the relevant line from my config file is 'vo=xv,sdl,'. I believe I've received the impression that xv is the recommended video-out method...) -- The Wanderer Warning: Simply because I argue an issue does not mean I agree with any side of it. Secrecy is the beginning of tyranny.
On Mon, Feb 06, 2006 at 02:27:08AM -0500, The Wanderer wrote:
Rich Felker wrote:
On Mon, Feb 06, 2006 at 04:09:53AM +0100, Diego Biurrun wrote:
On Sun, Feb 05, 2006 at 09:41:42PM -0500, Rich Felker wrote:
Are you using -fixed-vo? In any case it sounds like this is the problem: reinitializing the vo again and again. We need to do something so the config request gets blocked if the new mode is the same as the old one.
No, I don't use -fixed-vo.
Try it and see if the problem goes away. BTW -fixed-vo is recommended to always be used unless you're using a broken old vo driver that crashes with it.
To always be used with everything, or just with streams which are supposed to be multiple segments of the same thing? (Also, where is this recommended? I don't see any such note in the docs, and in fact -fixed-vo is described as beta code in the man page.)
Always with everything. It prevents annoying things like flicker between multiple files, window being destroyed and recreated, etc.
I have groups of files - music videos and the like - which I like to play back in semi-random order, and if I use -fixed-vo then very frequently when going from one file to another I will either see only part of the image (if the new file had a larger resolution), or see a bright blue background around the video (if the new file had a smaller resolution). Nothing I've done has been able to track down where the blue is coming from, and I've mostly just decided that it's an inherent side effect of using a "fixed" (i.e. invariant) video-out method; -fixed-vo does not appear to be compatible with playing multiple consecutive files with different resolutions.
It's supposed to be. If it's not then this is a bug, and hopefully the co maintainer will fix it if you report it. :)
(For the record, in case anyone cares enough for it to matter, the relevant line from my config file is 'vo=xv,sdl,'. I believe I've received the impression that xv is the recommended video-out method...)
Yes, when mga/vidix isn't available xv is recommended. xv may in some rare cases be even faster if dma is available. Rich
Rich Felker wrote:
On Mon, Feb 06, 2006 at 02:27:08AM -0500, The Wanderer wrote:
Rich Felker wrote:
Try it and see if the problem goes away. BTW -fixed-vo is recommended to always be used unless you're using a broken old vo driver that crashes with it.
To always be used with everything, or just with streams which are supposed to be multiple segments of the same thing? (Also, where is this recommended? I don't see any such note in the docs, and in fact -fixed-vo is described as beta code in the man page.)
Always with everything. It prevents annoying things like flicker between multiple files, window being destroyed and recreated, etc.
Definitely very desirable, if it works right. (I'll note that ISTR that it did work correctly with varying-resolution files at one point, but if so it stopped a long time ago.) Diego just removed the BETA CODE notice from the man page entry; should we add a note there (and possibly another somewhere in the XML docs?) to the effect that the option is always recommended?
I have groups of files - music videos and the like - which I like to play back in semi-random order, and if I use -fixed-vo then very frequently when going from one file to another I will either see only part of the image (if the new file had a larger resolution), or see a bright blue background around the video (if the new file had a smaller resolution). Nothing I've done has been able to track down where the blue is coming from, and I've mostly just decided that it's an inherent side effect of using a "fixed" (i.e. invariant) video-out method; -fixed-vo does not appear to be compatible with playing multiple consecutive files with different resolutions.
(To extend this: even if the files are the *same* resolution, if there was blank space left around the video to fit it within the screen's aspect ratio, then on switching to the second file there will (frequently if not necessarily always) be bright blue where that blank space was. Or I remember encountering this in the past, anyway - I haven't been able to find a pair of files which give the effect now, so I can't confirm it.) (In case it wasn't obvious from the mention of "blue background": this entire problem occurs only when also using -fs. Since that's the only way I ever play multiple files in the same session, it didn't occur to me to mention it before.)
It's supposed to be. If it's not then this is a bug, and hopefully the co maintainer will fix it if you report it. :)
Okay... what exactly should go into this type of bug report? There's no crash, so obviously that type of information is unavailable; the -v output doesn't seem at a glance to contain anything obviously related. How many levels of verbosity (and/or, what types of verbosity) would I be likely to need to get relevant output? -- The Wanderer Warning: Simply because I argue an issue does not mean I agree with any side of it. Secrecy is the beginning of tyranny.
Hi,
Try it and see if the problem goes away. BTW -fixed-vo is recommended to always be used unless you're using a broken old vo driver that crashes with it.
To always be used with everything, or just with streams which are supposed to be multiple segments of the same thing? (Also, where is this recommended? I don't see any such note in the docs, and in fact -fixed-vo is described as beta code in the man page.)
Always with everything. It prevents annoying things like flicker between multiple files, window being destroyed and recreated, etc.
Definitely very desirable, if it works right. (I'll note that ISTR that it did work correctly with varying-resolution files at one point, but if so it stopped a long time ago.)
Diego just removed the BETA CODE notice from the man page entry; should we add a note there (and possibly another somewhere in the XML docs?) to the effect that the option is always recommended?
Actually the code of -fixed-vo was never beta (it's just a few if()'s), but its usage was not recommended for users, until every (important) vo driver are fixed to work correctly with it. It was added by me to help vo driver developers test & fix their drivers for new vo specification... It skips closing and clean-opening driver between files/titles, but it requires special code in the vo driver to detect size changes and handle re-opening (without closing first) differently than the clean open. Afaik most vo still fails to handle this... Maybe it's time to make a brave step - setup shields against users! - and enable it by default, then run to fix all broken vo drivers quickly! Also note that a problem exists with multiple files given on commandline, when -fixed-vo is set for all (in config file or as first parameter) and you set different vo driver for a file, example: mplayer -fixed-vo 1.avi -vo x11 2.avi -vo xv it will either crash, or break, or play 2.avi with vo_x11... i dont remember which, but all bad... so who cares :) A'rpi
2006. február 7. 02.11 dátummal Arpi ezt írta:
It skips closing and clean-opening driver between files/titles, but it requires special code in the vo driver to detect size changes and handle re-opening (without closing first) differently than the clean open.
Despite all my efforts I failed to skip the reopen so far. It needs that after all the cell changes it tries out to initialize the audio_sh until initializing get successful (there is audio). Where do you propose I start out? Best regards! Attila
On Sun, Feb 05, 2006 at 11:11:49PM -0500, Rich Felker wrote:
On Mon, Feb 06, 2006 at 04:09:53AM +0100, Diego Biurrun wrote:
On Sun, Feb 05, 2006 at 09:41:42PM -0500, Rich Felker wrote:
On Mon, Feb 06, 2006 at 03:28:27AM +0100, Diego Biurrun wrote:
OK, try the following steps to reproduce:
gmplayer -dvd-device /path/to/rush_hour/ dvdnav://
The copyright warning flickers while the movie window disappears and reappears. I found out this is window manager specific. It happens with wmii (which I use currently), but goes away when I try with XFce.
What also happens - both with mplayer and gmplayer - is that the console gets spammed with messages like
VDec: vo config request - 720 x 480 (preferred colorspace: Unknown) VDec: using Planar YV12 as output csp (no 0) Movie-Aspect is 1.78:1 - prescaling to correct movie aspect. VO: [xv] 720x480 => 854x480 Planar YV12
that go away once the copyright warning stops. Maybe this is related?
Are you using -fixed-vo? In any case it sounds like this is the problem: reinitializing the vo again and again. We need to do something so the config request gets blocked if the new mode is the same as the old one.
No, I don't use -fixed-vo.
Try it and see if the problem goes away.
No change.
BTW -fixed-vo is recommended to always be used unless you're using a broken old vo driver that crashes with it.
Maybe it's time to remove the BETA-CODE notice next to it in the man page... Diego
2006. február 6. 21.47 dátummal Diego Biurrun ezt írta:
No change. I fixed (I hope so working) and update. I would like to ask you to test the patch if it works.
http://dcxx.fw.hu Best regards! Attila
On Mon, Feb 06, 2006 at 11:01:39PM +0100, Ötvös Attila wrote:
2006. február 6. 21.47 dátummal Diego Biurrun ezt írta:
No change. I fixed (I hope so working) and update. I would like to ask you to test the patch if it works.
The multiple config requests are still there. Now I get flickering and then a gray picture where the copyright notice is supposed to be... Diego
2006. február 7. 00.59 dátummal Diego Biurrun ezt írta:
The multiple config requests are still there.
Now I get flickering and then a gray picture where the copyright notice is supposed to be...
I modify init/uninit vo and I add options for fixed vo and still frame hadler. Try out, please: mplayer dvdnav:// ... -dvdnav-nofixed-vo mplayer dvdnav:// ... -dvdnav-nofixed-vo -dvdnav-realstill mplayer dvdnav:// ... -dvdnav-fixed-vo -dvdnav-realstill Try out with vo_config_request_hack.patch (to only test), please: mplayer dvdnav:// ... -dvdnav-nofixed-vo mplayer dvdnav:// ... -dvdnav-nofixed-vo -dvdnav-realstill mplayer dvdnav:// ... -dvdnav-fixed-vo -dvdnav-realstill I would like to ask you to test the patch and/or hack if it works. http://dcxx.fw.hu Best regards! Attila
On Tue, Feb 07, 2006 at 11:18:44PM +0100, Ötvös Attila wrote:
2006. február 7. 00.59 dátummal Diego Biurrun ezt írta:
The multiple config requests are still there.
Now I get flickering and then a gray picture where the copyright notice is supposed to be...
I modify init/uninit vo and I add options for fixed vo and still frame hadler.
I would like to ask you to test the patch and/or hack if it works.
Your patch fails to compile currently: mplayer.c:3425: error: too few arguments to function 'demux_seek' Also, it does not apply cleanly to CVS anymore: cerebus:~/src/mplayer/vanilla$ patch --dry-run -p0 -i ~/tmp/dvdnav/mplayer-dvdnav-patch/navmplayer.patch patching file libmpdemux/demuxer.h Hunk #4 FAILED at 311. 1 out of 5 hunks FAILED -- saving rejects to file libmpdemux/demuxer.h.rej Please release a new revision of your patch. Thanks Diego
2006. február 8. 12.19 dátummal Diego Biurrun ezt írta:
Please release a new revision of your patch.
I updated with current CVS (overwrite 20060207). + Try out, please: mplayer dvdnav:// -vo x11 Best regards! Attila
On Wed, Feb 08, 2006 at 05:54:29PM +0100, Ötvös Attila wrote:
2006. február 8. 12.19 dátummal Diego Biurrun ezt írta:
Please release a new revision of your patch.
I updated with current CVS (overwrite 20060207).
+ Try out, please:
mplayer dvdnav:// -vo x11
No change, with mplayer the console gets spammed with VDec: vo config request - 720 x 480 (preferred colorspace: Planar YV12) VDec: using Planar YV12 as output csp (no 0) Movie-Aspect is 1.33:1 - prescaling to correct movie aspect. VO: [x11] 720x480 => 720x540 Planar YV12 No accelerated colorspace conversion found VDec: vo config request - 720 x 480 (preferred colorspace: Unknown) VDec: using Planar YV12 as output csp (no 0) Movie-Aspect is 1.78:1 - prescaling to correct movie aspect. VO: [x11] 720x480 => 854x480 Planar YV12 with gmplayer the same happens, but preferred colorspace is always Unknown and the flicker is still present. Diego
2006. február 8. 18.32 dátummal Diego Biurrun ezt írta:
No change, with mplayer the console gets spammed with
Try out, please: dvdnav:// -dr and dvdnav:// -nodouble Best regards! Attila
2006. február 8. 20.10 dátummal Diego Biurrun ezt írta:
No change.
Try out, please: mplayer dvdnav:// ... -dvdnav-nofixed-vo mplayer dvdnav:// ... -dvdnav-nofixed-vo -dvdnav-realstill mplayer dvdnav:// ... -fixed-vo -dvdnav-realstill Try out with vo_config_request_hack.patch (to only test), please: mplayer dvdnav:// ... -dvdnav-nofixed-vo mplayer dvdnav:// ... -dvdnav-nofixed-vo -dvdnav-realstill mplayer dvdnav:// ... -fixed-vo -dvdnav-realstill I would like to ask you to test the patch and/or hack if it works. http://dcxx.fw.hu Best regards! Attila
On Wed, Feb 08, 2006 at 09:42:39PM +0100, Ötvös Attila wrote:
Try out, please:
mplayer dvdnav:// ... -dvdnav-nofixed-vo
No change.
mplayer dvdnav:// ... -dvdnav-nofixed-vo -dvdnav-realstill
Now the vo config request messages only appear about 10 times. gmplayer produces a black image, though, after a bit of flickering.
mplayer dvdnav:// ... -fixed-vo -dvdnav-realstill
dito
Try out with vo_config_request_hack.patch (to only test), please:
mplayer dvdnav:// ... -dvdnav-nofixed-vo
Just the messages with mplayer. Just a little flicker and the messages with gmplayer.
mplayer dvdnav:// ... -dvdnav-nofixed-vo -dvdnav-realstill
Just a little flicker and just a few messages with both mplayer and gmplayer.
mplayer dvdnav:// ... -fixed-vo -dvdnav-realstill
Just a little flicker and just a few messages with both mplayer and gmplayer.
I would like to ask you to test the patch and/or hack if it works.
Done. Diego
I updated patch. http://dcxx.fw.hu/ Try out, please: mplayer dvdnav:// mplayer dvdnav:// -dvdnav-realstill Best regards! Attila
2006. február 9. 11.50 dátummal Diego Biurrun ezt írta:
Now the vo config request messages only appear about 10 times. gmplayer produces a black image, though, after a bit of flickering.
I modify libmpcodecs/vd_libmpeg2.c that fixed message: VDec: vo config request - 720 x 480 (preferred colorspace: Planar YV12) VDec: using Planar YV12 as output csp (no 0) Movie-Aspect is 1.33:1 - prescaling to correct movie aspect. VO: [x11] 720x480 => 720x540 Planar YV12 I modify dvdnav handler in mplayer.c that fixed message (set aspect): VDec: vo config request - 720 x 480 (preferred colorspace: Unknown) VDec: using Planar YV12 as output csp (no 0) Movie-Aspect is 1.78:1 - prescaling to correct movie aspect. VO: [x11] 720x480 => 854x480 Planar YV12 I updated dvdnav patch: http://dcxx.fw.hu/ I would like to ask you to test the patch if it works. Best regards! Attila
On Sat, Feb 11, 2006 at 08:45:28PM +0100, Ötvös Attila wrote:
I updated dvdnav patch:
I would like to ask you to test the patch if it works.
Does anybody have some time to test this further? Diego
On Fri, 17 Feb 2006 09:22:24 +0100 Diego Biurrun <diego@biurrun.de> wrote:
On Sat, Feb 11, 2006 at 08:45:28PM +0100, Ötvös Attila wrote:
I updated dvdnav patch:
I would like to ask you to test the patch if it works.
Does anybody have some time to test this further?
I've been testing it quickly this week (one DVD only, hadn't check with more). The DVD plays well and is switching between channels correctly but I've noticed two problems : - sound issues : when switching to some intro title, i've noticed A/V desynchronization. Or at least the audio was played a way before video appears (which isn't the case on a regular DVD player). To be more specific it's like the sound from title 2 started being played back at the end of title 1. - no DVD button interaction. I've setup my input.conf to handle the DVDNav event keys. Once the DVD is started and during the first intro titles, if I press some of these keys, MPlayer detects an event, but as an intro title, the DVD has no action binded to. Once the DVD has reached the main menu (still frame), MPlayer doesn't handle the DVDNav keys anymore. No more testing besides that, sorry. Ben -- "My life, and by extension everyone else's is meaningless." Bender, Futurama
2006. február 17. 11.21 dátummal Benjamin Zores ezt írta:
- sound issues : when switching to some intro title, i've noticed A/V desynchronization. Or at least the audio was played a way before video appears (which isn't the case on a regular DVD player). To be more specific it's like the sound from title 2 started being played back at the end of title 1. Can you write more from the audio isuess and you can send a dump with -dvdnav-trace to me, please.
- no DVD button interaction. I've setup my input.conf to handle the DVDNav event keys. Once the DVD is started and during the first intro titles, if I press some of these keys, MPlayer detects an event, but as an intro title, the DVD has no action binded to. Once the DVD has reached the main menu (still frame), MPlayer doesn't handle the DVDNav keys anymore.
Fixed and updated with CVS. Best regards! Attila
On Sat, 18 Feb 2006 21:21:42 +0100 Ötvös Attila <oattila@chello.hu> wrote:
2006. február 17. 11.21 dátummal Benjamin Zores ezt írta:
- sound issues : when switching to some intro title, i've noticed A/V desynchronization. Or at least the audio was played a way before video appears (which isn't the case on a regular DVD player). To be more specific it's like the sound from title 2 started being played back at the end of title 1. Can you write more from the audio isuess and you can send a dump with -dvdnav-trace to me, please.
It's ok after all. I've tried with another DVD and it's fine. I guess it was just some of my ripped-off DVD on HDD.
- no DVD button interaction. I've setup my input.conf to handle the DVDNav event keys. Once the DVD is started and during the first intro titles, if I press some of these keys, MPlayer detects an event, but as an intro title, the DVD has no action binded to. Once the DVD has reached the main menu (still frame), MPlayer doesn't handle the DVDNav keys anymore.
Fixed and updated with CVS.
Indeed, I've tested and it works pretty well. There's unfortunately still some bugs. Try uisng the DVD_MENU key to go to the menu screen. If you then it the LEFT/RIGHT/UP/DOWN/OK DVD_NAV buttons, it works perfectly. But if, once in menu, hit some other key (say forward/backward for example) then the LEFT/RIGHT/UP/DOWN/OK DVD_NAV buttons do not work anymore. Hitting down DVD_MENU button again, the keys works again on some DVD but on others, the DVD menu buttons aren't shown anymore. So maybe it can be good to disable events other than DVDNAV related when playing a DVDNAV stream ? Except from that, the patch works pretty well right now. One more remark, is it possible to add some extra DVDNAV event key to support runtime audio/subs switch (as it's currently done with hardware DVD player) ? Ben -- "My life, and by extension everyone else's is meaningless." Bender, Futurama
2006. február 19. 18.59 dátummal Benjamin Zores ezt írta:
Try uisng the DVD_MENU key to go to the menu screen. If you then it the LEFT/RIGHT/UP/DOWN/OK DVD_NAV buttons, it works perfectly. But if, once in menu, hit some other key (say forward/backward for example) then the LEFT/RIGHT/UP/DOWN/OK DVD_NAV buttons do not work anymore.
Hitting down DVD_MENU button again, the keys works again on some DVD but on others, the DVD menu buttons aren't shown anymore. I would like to get to know if the place of the error is in the spu or stream. That is way I ask you to try out:
mplayer dvdnav:// -dvdnav-menutype 2
One more remark, is it possible to add some extra DVDNAV event key to support runtime audio/subs switch (as it's currently done with hardware DVD player) ?
Why? Don't '#' (switch_audio) and 'j' (vobsub_lang) work? Best regards! Attila
On Sun, 19 Feb 2006 20:26:22 +0100 Ötvös Attila <oattila@chello.hu> wrote:
2006. február 19. 18.59 dátummal Benjamin Zores ezt írta:
Try uisng the DVD_MENU key to go to the menu screen. If you then it the LEFT/RIGHT/UP/DOWN/OK DVD_NAV buttons, it works perfectly. But if, once in menu, hit some other key (say forward/backward for example) then the LEFT/RIGHT/UP/DOWN/OK DVD_NAV buttons do not work anymore.
Hitting down DVD_MENU button again, the keys works again on some DVD but on others, the DVD menu buttons aren't shown anymore. I would like to get to know if the place of the error is in the spu or stream. That is way I ask you to try out:
mplayer dvdnav:// -dvdnav-menutype 2
Ok so I did more tests and here are the results : For all tests, I did : - go to main menu with DVDNAV_MENU event. - screenshot - seek (so non DVDNAV event input) - try to input DVDNAV_DOWN event to go to the button below - screenshot. TEST 1 ****** ./mplayer -vo x11 dvdnav:// -dvdnav-menutype 0 Default menu : http://geexbox.org/~ben/menutype-0-before.jpg After seeking : http://geexbox.org/~ben/menutype-0-after.jpg Results : SPU button disappeared, no more DVDnav events handled. TEST 2 ****** ./mplayer -vo x11 dvdnav:// -dvdnav-menutype 1 Default menu : http://geexbox.org/~ben/menutype-1-before.jpg After seeking : http://geexbox.org/~ben/menutype-1-after.jpg Results : Box Buttons always there, still DVDnav events. TEST 3 ****** ./mplayer -vo x11 dvdnav:// -dvdnav-menutype 2 Default menu : http://geexbox.org/~ben/menutype-2-before.jpg After seeking : http://geexbox.org/~ben/menutype-2-after.jpg Results : Box Buttons always there, still DVDnav events but no more SPU. So the problem seems to be with SPU which are hidden and lose of DVDNav events after seeking (or any other event). Hope it helps, otherwise please say so and I'll test more. Ben -- "My life, and by extension everyone else's is meaningless." Bender, Futurama
2006. február 19. 21.48 dátummal Benjamin Zores ezt írta:
On Sun, 19 Feb 2006 20:26:22 +0100
Hitting down DVD_MENU button again, the keys works again on some DVD but on others, the DVD menu buttons aren't shown anymore.
I fixed (I hope so working) and I updated with current CVS and I implemented spudec_draw_scaled() the nav button spu of the resizing. I would like to ask you to test the patch if it works. http://dcxx.fw.hu Best regards! Attila
On Mon, 20 Feb 2006 20:00:04 +0100 Ötvös Attila <oattila@chello.hu> wrote:
2006. február 19. 21.48 dátummal Benjamin Zores ezt írta:
On Sun, 19 Feb 2006 20:26:22 +0100
Hitting down DVD_MENU button again, the keys works again on some DVD but on others, the DVD menu buttons aren't shown anymore.
I fixed (I hope so working) and I updated with current CVS and I implemented spudec_draw_scaled() the nav button spu of the resizing. I would like to ask you to test the patch if it works.
It works as expected now. SPU buttons do no more disappear even if you seek (or anything else) in the stream. Great job. Ben -- "My life, and by extension everyone else's is meaningless." Bender, Futurama
I fixed the other streamN of spu button but the "dual layer" spu wasn't implemented. I updated with current CVS. http://dcxx.fw.hu/ Best regards! Attila
On Thu, 23 Feb 2006 21:04:01 +0100 Ötvös Attila <oattila@chello.hu> wrote:
I fixed the other streamN of spu button but the "dual layer" spu wasn't implemented. I updated with current CVS.
By the way, I had a deeper look at the patch itself today. In fact I've did a customized (with your patch) version of GeeXboX Live-CD (so if by the way someone's here want to test this patch quickly with or without dev skill, just ask for the URL). I'm making some of our users test it in order to provide you more and more feedback. But when doing this I've found that you've done many changes to MPlayer (changed the prototypes of strem_open or demux_open, don't remember which ..) but especially you've removed libpostprocess build ! Is there any special reason to do that, because : - it fails to build/link without it (with --enable-libavcodec at least) : i thought it was MPlayer's CVS but it's introduced by your patch. - you have no reason to do that as it works pretty fine with it - it's anyway non acceptable. Besides that, I know that the patch is far from being complete and support all DVDs but maybe some MPlayer developer can start having a deeper look at it. Some parts probably can be commited and we anyhow to do it pieces by pieces if we want DVDNav support to be restored some day (and it begans to be hard to port patch each time as there are already a huge amount of code and changes). Ben -- "My life, and by extension everyone else's is meaningless." Bender, Futurama
2006. február 23. 21.20 dátummal Benjamin Zores ezt írta:
But when doing this I've found that you've done many changes to MPlayer (changed the prototypes of strem_open or demux_open, don't remember which ..) but especially you've removed libpostprocess build !
Is there any special reason to do that, because : - it fails to build/link without it (with --enable-libavcodec at least) : i thought it was MPlayer's CVS but it's introduced by your patch. - you have no reason to do that as it works pretty fine with it - it's anyway non acceptable.
I am sorry! I forgotten remove the modify of CVS (from 20060223 to 20060220) lines in patch. I fixed this and remove bad patch in my web sides: http://dcxx.fw.hu/ Best regards! Attila
2006. február 5. 15.53 dátummal Diego Biurrun ezt írta:
Hmm, with gmplayer I still get flickering Windows with the Rush Hour DVD..
I think so managed to find an error like "flickering" windows: mplayer mf:///test/test.jpg -loop 10 -mf fps=10:type=jpeg -vo xv No error: mplayer mf:///test/test.jpg -loop 10 -mf fps=10:type=jpeg -vo x11 Best regards! Attila
Hi All. Implemented color spu button (partially!!! only xv, yuv12 mode!!!) and updated with CVS. http://dcxx.fw.hu/ Best regards! Attila
Hi All. Color spu menu button implemented: RGB/BGR format: rgb15, rgb16, rgb24, rgb32, bgr15, bgr16, bgr24, bgr32 YUV format: yuv12, i420, iyuv (partially) VO: dfbmga, dga, directx, fbdev, fbdev2, gl2, sdl, svga, tdfxfb, vesa, x11, xv, yuv4mpeg Tested: sdl, x11, xv Not implemented: in the spudec_draw_scaled() the nav color button spu of the resizing I updated with CVS. http://dcxx.fw.hu/ Best regards! Attila
On Fri, Mar 03, 2006 at 11:08:02PM +0100, Ötvös Attila wrote:
Hi All.
Color spu menu button implemented:
RGB/BGR format: rgb15, rgb16, rgb24, rgb32, bgr15, bgr16, bgr24, bgr32 YUV format: yuv12, i420, iyuv (partially) VO: dfbmga, dga, directx, fbdev, fbdev2, gl2, sdl, svga, tdfxfb, vesa, x11, xv, yuv4mpeg Tested: sdl, x11, xv
Not implemented: in the spudec_draw_scaled() the nav color button spu of the resizing
I updated with CVS.
Doesn't compile with cvs, demux_seek in mplayer.c needs more params. Also, in code you added, please remove trailing whitespace... - ods15
2006. március 4. 17.18 dátummal Oded Shimon ezt írta:
Doesn't compile with cvs, demux_seek in mplayer.c needs more params.
I created the patch with 2006.03.03 21:51 CVS. I implemented the scaled nav color button spu of the resizing and updated with CVS. http://dcxx.fw.hu/ Best regards! Attila
Hi All! Implemented: "part" spu button (eg: packet->start_col > 0) cut spu button (eg: spu nibble draw line > spu button area width) color button in vosub_vidix.c (only non interleaced mode), but I don't tested. Fixed: spu button visible buffer overflow bug in spudec_draw_scaled_yuv() buffer overflow bug in spudec_process_data() compare bug in vo_vesa.c compare bug in vo_sdl.c And updated patch with current CVS. Best regards! Attila
2006. március 5. 16.58 dátummal Ötvös Attila ezt írta: Hi All! Fixed sh_video bug if sh_video is NULL. http://dcxx.fw.hu/ Best regards! Attila
On Monday, 06 March 2006 at 22:48, Ötvös Attila wrote:
2006. március 5. 16.58 dátummal Ötvös Attila ezt írta: Hi All!
Fixed sh_video bug if sh_video is NULL.
Tested with current CVS. Mostly ok, but the highlighted menu button text ends up at the bottom of the screen. I get "DVDNAV: title out of range" error when opening all DVDs and "DVDNAV stream seek error: New position not yet determined (0)" when clicking Play in the menu with one particular DVD. It's worth noting that aspect ration changes are handled gracefully. Thanks, and keep up the good work. R. -- MPlayer developer and RPMs maintainer: http://rpm.greysector.net/mplayer/ There should be a science of discontent. People need hard times and oppression to develop psychic muscles. -- from "Collected Sayings of Muad'Dib" by the Princess Irulan
2006. március 12. 01.35 dátummal Dominik 'Rathann' Mierzejewski ezt írta:
Tested with current CVS. Mostly ok, but the highlighted menu button text ends up at the bottom of the screen. I get "DVDNAV: title out of range" error when opening all DVDs and "DVDNAV stream seek error: New position not yet determined (0)" when clicking Play in the menu with one particular DVD.
Can you send me an dump with -dvdnav-trace, please. Best regards! Attila
Hi All! Fixed sh_video bug if sh_video is NULL. http://dcxx.fw.hu/ Best regards! Attila
Hi All! I drop out reopen but now demuxer_update_time_length() don't work :(. Implemented "hot add" audio codec and fixed change video resulotion in vf.c (if change bellow resulotion) and clean dvdnav handler in mplayer.c. I updated with current CVS: http://dcxx.fw.hu/ Best regards! Attila
2006. március 12. 16.08 dátummal Ötvös Attila ezt írta: Hi All!
I drop out reopen but now demuxer_update_time_length() don't work :(. Implemented "hot add" audio codec and fixed change video resulotion in vf.c (if change bellow resulotion) and clean dvdnav handler in mplayer.c.
I created new patch: 2006.03.12 new version: Fixed "hot add" audio and resolution change. I implemented update time length. I updated with current CVS: http://dcxx.fw.hu/ Best regards! Attila
Hi All! I modify: "force dvd menu" optional (default disable) -If not spu then display simple box- I updated with current CVS: http://dcxx.fw.hu/ Best regards! Attila
Hi All! I fixed vo_directx and fixed audio delay to the cell change event and update with current CVS. http://dcxx.fw.hu/ I would be very pleased if someone wrote down down your experiences so that I would fixed them (you maybe share the positives experiences with me). Have anybody tried out the mplayer spu button with vo vidix yet? Best regards! Attila
Hi ?tv?s Attila! On 2006.03.24 at 20:03:47 +0100, ?tv?s Attila wrote next:
I fixed vo_directx and fixed audio delay to the cell change event and update with current CVS.
I would be very pleased if someone wrote down down your experiences so that I would fixed them (you maybe share the positives experiences with me). Have anybody tried out the mplayer spu button with vo vidix yet?
So it's ready for testing already? I mean, I can download it, patch mplayer, run ten my favorite dvds and report everything that doesn't work as expected to you, or there is no point in doing this yet because you know of things it doesn't support and you are working on it? Anyway, I can test xvidix and gl, but I don't use gl2 and xv doesn't work for me, so what should I compare it with? What video driver is the most feature-complete besides xv? -- Vladimir
2006. március 24. 20.19 dátummal Vladimir Mosgalin ezt írta: Hi Vladimir Mosgalin!
So it's ready for testing already? I mean, I can download it, patch mplayer, run ten my favorite dvds and report everything that doesn't work as expected to you, or there is no point in doing this yet because you know of things it doesn't support and you are working on it?
I try out all the my dvd and works. I search such dvd which don't work or problematic with my patch.
Anyway, I can test xvidix and gl, but I don't use gl2 and xv doesn't work for me, so what should I compare it with?
You view so that if correct color spu button in dvdnav menu.
What video driver is the most feature-complete besides xv?
I implemented color spu button: dfbmga, dga, directx, fbdev, fbdev2, gl2, sdl, svga, tdfxfb, vesa, x11, xv, yuv4mpeg, vosub_vidix I tested: sdl, x11, xv, directx Best regards! Attila
Hi ?tv?s Attila! On 2006.03.24 at 20:40:29 +0100, ?tv?s Attila wrote next:
So it's ready for testing already? I mean, I can download it, patch mplayer, run ten my favorite dvds and report everything that doesn't work as expected to you, or there is no point in doing this yet because you know of things it doesn't support and you are working on it?
I try out all the my dvd and works. I search such dvd which don't work or problematic with my patch.
OK, so here are the first impressions. 1) It doesn't apply cleanly against current cvs, I had to hack it a bit... 2) navigation doesn't work. Or I don't understand what should I do to get it to work. When I click left/right/middle mouse button, it just pauses/switches osd/switches fullscreen, as usual 3) with -vo gl, mplayer crashes whenever it tries to draw OSD 4) Color spu buttons work er.. strange. Say, there are several white boxes with grey text, when I put mouse cursor over it in xine, text becomes pink. In mplayer with -vo xvidix, text is always grey. With -vo x11, text is pink in the first box /always/ and is always grey in every other. Since -vo x11 sucks, gl crashes and xvidix doesn't work, I try -vo gl2 and voila.. the same as x11, but text is blue! Funny eh? 5) Well, since I don't understand what else can I do, I haven't tried choosing anything or some other disc. Maybe gl troubles are related to the fact that I changed code a bit in order to apply it against cvs, I don't know. -- Vladimir
2006. március 24. 22.26 dátummal Vladimir Mosgalin ezt írta: Hi Vladimir Mosgalin!
OK, so here are the first impressions. 1) It doesn't apply cleanly against current cvs, I had to hack it a bit... 2) navigation doesn't work. Or I don't understand what should I do to get it to work. When I click left/right/middle mouse button, it just pauses/switches osd/switches fullscreen, as usual The mplayer can't use mouse in console mode (mouse only works with gmplayer). The default navigation keys: 'K' : up 'J' : down 'H' : left 'L' : right 'M' : go main menu 'S' : activate menu item
3) with -vo gl, mplayer crashes whenever it tries to draw OSD Thanks, I will check but I didn't modify vo_gl.c (???).
4) Color spu buttons work er.. strange. Say, there are several white boxes with grey text, when I put mouse cursor over it in xine, text becomes pink. In mplayer with -vo xvidix, text is always grey. With -vo x11, text is pink in the first box /always/ and is always grey in every other. Since -vo x11 sucks, gl crashes and xvidix doesn't work, I try -vo gl2 and voila.. the same as x11, but text is blue! Funny eh? I think that RGB and BGR mode invert in gl2 that is way text is blue instead of pink. I will check vo_gl2.c.
5) Well, since I don't understand what else can I do, I haven't tried choosing anything or some other disc.
Maybe gl troubles are related to the fact that I changed code a bit in order to apply it against cvs, I don't know. What should you have changed?
Best regards! Attila
Hi ?tv?s Attila! On 2006.03.24 at 23:12:06 +0100, ?tv?s Attila wrote next:
OK, so here are the first impressions. 1) It doesn't apply cleanly against current cvs, I had to hack it a bit... 2) navigation doesn't work. Or I don't understand what should I do to get it to work. When I click left/right/middle mouse button, it just pauses/switches osd/switches fullscreen, as usual The mplayer can't use mouse in console mode (mouse only works with gmplayer). The default navigation keys:
So only gui users will get full dvd support? Those lucky bastards! Any hope on the situation's improvement?
3) with -vo gl, mplayer crashes whenever it tries to draw OSD Thanks, I will check but I didn't modify vo_gl.c (???).
Well..
4) Color spu buttons work er.. strange. Say, there are several white boxes with grey text, when I put mouse cursor over it in xine, text becomes pink. In mplayer with -vo xvidix, text is always grey. With -vo x11, text is pink in the first box /always/ and is always grey in every other. Since -vo x11 sucks, gl crashes and xvidix doesn't work, I try -vo gl2 and voila.. the same as x11, but text is blue! Funny eh? I think that RGB and BGR mode invert in gl2 that is way text is blue instead of pink. I will check vo_gl2.c.
Maybe, but it doesn't explain the very similar bug in xvidix, and there should be no rgb vs bgr stuff in it.
5) Well, since I don't understand what else can I do, I haven't tried choosing anything or some other disc.
Maybe gl troubles are related to the fact that I changed code a bit in order to apply it against cvs, I don't know. What should you have changed?
..hey. You do that. I mean, correct patch against current cvs. I removed global_sub_quiet_osd_hack = 1 line and did some cosmetic changes. -- Vladimir
2006. március 24. 23.42 dátummal Vladimir Mosgalin ezt írta: Hi Vladimir Mosgalin! > Hi ?tv?s Attila! > > > The mplayer can't use mouse in console mode (mouse only works with > > gmplayer). The default navigation keys: > > So only gui users will get full dvd support? Those lucky bastards! Any > hope on the situation's improvement? Two thinks require to the full dvd support: - get window size - get mouse positon in window > > I think that RGB and BGR mode invert in gl2 that is way text is blue > > instead of pink. I will check vo_gl2.c. > > Maybe, but it doesn't explain the very similar bug in xvidix, and there > should be no rgb vs bgr stuff in it. > Maybe. I will look. > > What should you have changed? > > ..hey. You do that. I mean, correct patch against current cvs. I removed > global_sub_quiet_osd_hack = 1 > line and did some cosmetic changes. Thanks. Best regards! Attila
2006. március 24. 20.19 dátummal Vladimir Mosgalin ezt írta:
So it's ready for testing already? I mean, I can download it, patch mplayer, run ten my favorite dvds and report everything that doesn't work as expected to you, or there is no point in doing this yet because you know of things it doesn't support and you are working on it?
I sorry, forgot one bug: If different movie (scaled) size and window size don't correct get mouse positioning with gmplayer. Best regards! Attila
Hi ?tv?s Attila! On 2006.03.24 at 21:02:43 +0100, ?tv?s Attila wrote next:
2006. m?rcius 24. 20.19 d?tummal Vladimir Mosgalin ezt ?rta:
So it's ready for testing already? I mean, I can download it, patch mplayer, run ten my favorite dvds and report everything that doesn't work as expected to you, or there is no point in doing this yet because you know of things it doesn't support and you are working on it?
I sorry, forgot one bug:
If different movie (scaled) size and window size don't correct get mouse positioning with gmplayer.
Err.. I don't get it. The patch works only with gmplayer? I don't compile mplayer with gui lately, it always was quite useless and became simply broken after gtk2 hack kicked it. -- Vladimir
2006. március 24. 21.04 dátummal Vladimir Mosgalin ezt írta:
I don't get it. The patch works only with gmplayer? I don't compile mplayer with gui lately, it always was quite useless and became simply broken after gtk2 hack kicked it.
No. The patch works mplayer console mode but can't use mouse ('K' up ,'J' down ,'H' left ,'L' right ,'M' main menu ,'S' select). Best regards! Attila
Hi ?tv?s Attila! On 2006.03.24 at 22:06:07 +0100, ?tv?s Attila wrote next:
No. The patch works mplayer console mode but can't use mouse ('K' up ,'J' down ,'H' left ,'L' right ,'M' main menu ,'S' select).
Wow, it really works! Nice. At least choosing audio and subtitle languages and picking up episodes works. However, colors are still wrong. Two more details. I said that text is grey with xvidix. Looks like I was wrong. I see blue-colored area (should have been pink) above the real text. Like, in the middle between text and top of the window there is a blue areola which should have actually be around the text. Looks like you are writing correct bytes into the wrong memory location and even in the wrong chroma plane. However, with some buttons look even more strange. I see random green and blue bars around the screen upon selecting them.. when it should have been the same pink areola. And another small bug: when I called menu from the movie with -vo x11, I can see the pink areola instantly, while it should have been seen only after the buttons actually appeared. (and I can't even navigate yet, "DVDNAV navigation error: New position not yet determined.") It surely looks strange and doesn't happen when menu is played for the first time and even when I force menu restart in the middle of the menu. With -vo xvidix, I can see that both chroma and luma parts of text areola behave like this (since luma is always in the correct place and chroma always isn't). Also, when I said "it works with -vo gl2", I forgot to mention that it actually doesn't.. Well it does with simple "gl2", but the real point of gl modes right now is using hardware yuv conversion, like gl2:yuv=1 for nvidia cards and yuv=3 for ati cards. I just get "Color SPU does not support this vo!" message in -vo gl2:yuv=3 mode. -- Vladimir
2006. március 24. 22.53 dátummal Vladimir Mosgalin ezt írta:
Hi ?tv?s Attila!
On 2006.03.24 at 22:06:07 +0100, ?tv?s Attila wrote next:
No. The patch works mplayer console mode but can't use mouse ('K' up ,'J' down ,'H' left ,'L' right ,'M' main menu ,'S' select).
Wow, it really works! Nice. At least choosing audio and subtitle languages and picking up episodes works.
However, colors are still wrong. Two more details.
I said that text is grey with xvidix. Looks like I was wrong. I see blue-colored area (should have been pink) above the real text. Like, in the middle between text and top of the window there is a blue areola which should have actually be around the text. Looks like you are writing correct bytes into the wrong memory location and even in the wrong chroma plane.
However, with some buttons look even more strange. I see random green and blue bars around the screen upon selecting them.. when it should have been the same pink areola.
And another small bug: when I called menu from the movie with -vo x11, I can see the pink areola instantly, while it should have been seen only after the buttons actually appeared. (and I can't even navigate yet, "DVDNAV navigation error: New position not yet determined.") It surely looks strange and doesn't happen when menu is played for the first time and even when I force menu restart in the middle of the menu.
With -vo xvidix, I can see that both chroma and luma parts of text areola behave like this (since luma is always in the correct place and chroma always isn't).
Also, when I said "it works with -vo gl2", I forgot to mention that it actually doesn't.. Well it does with simple "gl2", but the real point of gl modes right now is using hardware yuv conversion, like gl2:yuv=1 for nvidia cards and yuv=3 for ati cards. I just get "Color SPU does not support this vo!" message in -vo gl2:yuv=3 mode.
I implemented yuy2 with xvidix(vobsub_vidix, directx, sdl, xv), I corrected spu color: fbdev, fbdev2, gl2 and I updated with CVS. http://dcxx.fw.hu/ Best regards! Attila
2006. március 24. 22.53 dátummal Vladimir Mosgalin ezt írta:
Hi ?tv?s Attila!
On 2006.03.24 at 22:06:07 +0100, ?tv?s Attila wrote next:
No. The patch works mplayer console mode but can't use mouse ('K' up ,'J' down ,'H' left ,'L' right ,'M' main menu ,'S' select).
Wow, it really works! Nice. At least choosing audio and subtitle languages and picking up episodes works.
However, colors are still wrong. Two more details.
I said that text is grey with xvidix. Looks like I was wrong. I see blue-colored area (should have been pink) above the real text. Like, in the middle between text and top of the window there is a blue areola which should have actually be around the text. Looks like you are writing correct bytes into the wrong memory location and even in the wrong chroma plane.
However, with some buttons look even more strange. I see random green and blue bars around the screen upon selecting them.. when it should have been the same pink areola.
And another small bug: when I called menu from the movie with -vo x11, I can see the pink areola instantly, while it should have been seen only after the buttons actually appeared. (and I can't even navigate yet, "DVDNAV navigation error: New position not yet determined.") It surely looks strange and doesn't happen when menu is played for the first time and even when I force menu restart in the middle of the menu.
With -vo xvidix, I can see that both chroma and luma parts of text areola behave like this (since luma is always in the correct place and chroma always isn't).
Also, when I said "it works with -vo gl2", I forgot to mention that it actually doesn't.. Well it does with simple "gl2", but the real point of gl modes right now is using hardware yuv conversion, like gl2:yuv=1 for nvidia cards and yuv=3 for ati cards. I just get "Color SPU does not support this vo!" message in -vo gl2:yuv=3 mode. Hi Vladimir Mosgalin!
I fixed (I hope so working) go to menu from movie and I updated with current CVS. (I fixed menu color with prev patch) I would like to ask you to test the patch if it works (menu & button color). http://dcxx.fw.hu Best regards! Attila
Hi ?tv?s Attila! On 2006.04.04 at 00:21:05 +0200, ?tv?s Attila wrote next:
I said that text is grey with xvidix. Looks like I was wrong. I see blue-colored area (should have been pink) above the real text. Like, in the middle between text and top of the window there is a blue areola which should have actually be around the text. Looks like you are writing correct bytes into the wrong memory location and even in the wrong chroma plane.
However, with some buttons look even more strange. I see random green and blue bars around the screen upon selecting them.. when it should have been the same pink areola.
And another small bug: when I called menu from the movie with -vo x11, I can see the pink areola instantly, while it should have been seen only after the buttons actually appeared. (and I can't even navigate yet, "DVDNAV navigation error: New position not yet determined.") It surely looks strange and doesn't happen when menu is played for the first time and even when I force menu restart in the middle of the menu.
With -vo xvidix, I can see that both chroma and luma parts of text areola behave like this (since luma is always in the correct place and chroma always isn't).
Also, when I said "it works with -vo gl2", I forgot to mention that it actually doesn't.. Well it does with simple "gl2", but the real point of gl modes right now is using hardware yuv conversion, like gl2:yuv=1 for nvidia cards and yuv=3 for ati cards. I just get "Color SPU does not support this vo!" message in -vo gl2:yuv=3 mode. Hi Vladimir Mosgalin!
I fixed (I hope so working) go to menu from movie and I updated with current CVS. (I fixed menu color with prev patch) I would like to ask you to test the patch if it works (menu & button color).
I just checked the last version, and you know, all the bugs I described still present.. I.e. no "spu colors" with gl2:yuv= targets, the same color bugs with xvidix, and the pre-glow of menu elements when going from movie to menu ("spu coloring" displayed before actual menu appears). Additionally, some things are behaving wrong. I tested two dvds this time, "Mean Girls" and "IJ and the last crusade". On first, you should be able to choose audio or subtitles from the main menu, but on choosing "subtitles" button menu doesn't change at all. Colored cursor, however, represents new invisible menu now, and you can navigate through it. The interesting thing is that you can choose "audio" button, it works, and you can go to "subtitles" menu from there too. It's displayed correctly this way! The problem with IJ dvd (probably present with any disc in the series, since menus are the same. Note that I have PAL release, but I guess NTSC is almost the same, besides lower resolution) is that animation isn't displayed when choosing "set up" or "scene selection" buttons. Instead, new menu is displayed immediately but 2 sec or so slowdown is experienced before you can actually choose anything. When playing in xine, it playbacks several seconds of animation and then displays menu, slowdown also present, but it's not that long, less than second. -- Vladimir
Hi All. I modifed this: - Mute audio in cell/vts change event - Code cleaned - Update with CVS http://dcxx.fw.hu/ Best regards! Attila
Hi All I fixed -alang/-slang option with dvdnav and remove some debug code and update with CVS. http://dcxx.fw.hu/ Best regards! Attila
Hi All I fixed draw_alpha in menu.c and cosmetics draw_alpha functions and remove maxapatcs, maxvpacks in demux_open and update with CVS. http://dcxx.fw.hu/ Best regards! Attila
Hi All I implemented the activation event of the menu button showing (change color) and updated with CVS. I created patch (navdoc.patch) to mplayer man (en) but please check! (I am sorry to say that my English knowledge isn't good) I want to known if I should do something. http://dcxx.fw.hu/ Best regards! Attila
On Tuesday, 11 April 2006 at 20:35, Ötvös Attila wrote:
Hi All
I implemented the activation event of the menu button showing (change color) and updated with CVS.
I created patch (navdoc.patch) to mplayer man (en) but please check! (I am sorry to say that my English knowledge isn't good)
I want to known if I should do something.
You're producing updated version faster than anyone can test them. ;) Great work, I'll try to test the latest one soon again. Regards, R. -- MPlayer developer and RPMs maintainer: http://rpm.greysector.net/mplayer/ There should be a science of discontent. People need hard times and oppression to develop psychic muscles. -- from "Collected Sayings of Muad'Dib" by the Princess Irulan
Ötvös Attila wrote:
Hi All
I implemented the activation event of the menu button showing (change color) and updated with CVS.
I created patch (navdoc.patch) to mplayer man (en) but please check! (I am sorry to say that my English knowledge isn't good)
I want to known if I should do something.
Best regards! Attila
Hi, I reviewed the parts of your dvdnav patch relative to the stream and mux layer. First of all: you added a directory with a scary name -libmpdvdnav-, that contains a modified version of libdvdnav. IMO this not acceptable; I wish that you could make your code work with the standard libdvdnav (importing still another projtect in mplayer is a serious problem: the sources tarball would grow even more and no one would fix/maintain it). Second: you added a second dvdnav stream. This is wrong, because there's no reason to keep the old one lying around unused. You should patch the old one instead. Consequently all the blocks of code #ifdef-ed MPDVDNAV should not exist anymore. Attached are two patches that you should take as starting point: configure2.diff is self-explaining, demux2.diff is what is left of your changes in libmpdemux/ after I removed what I consider unacceptable. Let's see part of it: Index: demux_mpg.c =================================================================== RCS file: /cvsroot/mplayer/main/libmpdemux/demux_mpg.c,v retrieving revision 1.82 diff -u -r1.82 demux_mpg.c --- demux_mpg.c 3 May 2006 18:18:25 -0000 1.82 +++ demux_mpg.c 6 May 2006 16:14:47 -0000 @@ -754,6 +754,7 @@ int i; if(sh_audio && !d_audio->eof && d_video->pts && d_audio->pts){ float a_pts=d_audio->pts; + if((float)sh_audio->i_bps==0.0f) break; why this ?? a_pts+=(ds_tell_pts(d_audio)-sh_audio->a_in_buffer_len)/(float)sh_audio->i_bps; if(d_video->pts>a_pts){ skip_audio_frame(sh_audio); // sync audio @@ -860,6 +861,24 @@ *((int*)arg) = demuxer->audio->id; return DEMUXER_CTRL_OK; + case DEMUXER_CTRL_SET_TIME_PTS: { + if (demuxer->movi_end==0) + { + mpg_d->final_pts = 0.0; + mpg_d->has_valid_timestamps = 0; + return DEMUXER_CTRL_OK; + } + mpg_d->final_pts=*((float *)arg); + if (mpg_d->final_pts==0.0) + { + mpg_d->final_pts = 0.0; + mpg_d->has_valid_timestamps = 0; + return DEMUXER_CTRL_OK; + } + mpg_d->has_valid_timestamps = 1; + return DEMUXER_CTRL_OK; + } + default: return DEMUXER_CTRL_NOTIMPL; } why do you need to reset the timers and the position? when you change the titleset? If so, you should reset the stream and reopen the demuxer, IMO ----------------------------------------------------------------------------------------------------------- Index: demuxer.c =================================================================== RCS file: /cvsroot/mplayer/main/libmpdemux/demuxer.c,v retrieving revision 1.222 diff -u -r1.222 demuxer.c --- demuxer.c 27 Apr 2006 11:13:21 -0000 1.222 +++ demuxer.c 6 May 2006 16:14:47 -0000 @@ -253,6 +253,13 @@ if (!demux_aid_vid_mismatch) mp_msg(MSGT_IDENTIFY, MSGL_INFO, "ID_VIDEO_ID=%d\n", id); } +#ifdef USE_MPDVDNAV + ((sh_video_t*)demuxer->v_streams[id])->config_lock=0; + ((sh_video_t*)demuxer->v_streams[id])->config_w=0; + ((sh_video_t*)demuxer->v_streams[id])->config_h=0; + ((sh_video_t*)demuxer->v_streams[id])->config_outfmt=0; + ((sh_video_t*)demuxer->v_streams[id])->enable_mpeg2_reset=0; +#endif return demuxer->v_streams[id]; } let alone that MPDVDNAV shouldn't even exist, code like that should never go in the demuxer layer - unacceptable IMO ----------------------------------------------------------------------------------------------------------- in demuxer.h: // -------------- + int max_video_packs; + int max_video_bytes; + int max_audio_packs; + int max_audio_bytes; + int hide_packs_err_mess; // -------------- [...] } demuxer_t; the above members that you want to add are completely useless, IMO. Why are you so scared of the message ("too many packets...") that comes out? Adding a DEMUXER_CTRL to silence it is overkill and in any case you can fix this issue in a second moment. Another thing that I really don't like is the code to manage input events in the stream layer (stream_dvdnav.c), but since libdvdnav seems to work only with events (and for the sake of self-conteinance) this is a secondary problem for the time being. Generally, you should avoid to mix decoder-specific code in the demuxer layer, and try to minimize the impact of your patches on the source. In my opinion you should begin to send a very minimalistic set of patches just to make the basic functionalities work (i.e. beginning with configure and with the necessary changes in the stream layer) and add functionalities on top of them only when the previous round of patches is applied. Reviewing your code is very difficult because it's huge and full of cosmetics, but I'm sure you can make it smaller and still have the same functionalities working. Keep up the good work! Nico
On Tue, 11 Apr 2006 20:35:45 +0200 Ötvös Attila <oattila@chello.hu> wrote:
Hi All
I implemented the activation event of the menu button showing (change color) and updated with CVS.
I created patch (navdoc.patch) to mplayer man (en) but please check! (I am sorry to say that my English knowledge isn't good)
I want to known if I should do something.
I've been tested the patch using Vidix and there are some display issues in this mode (using VESA it works as a charm). Under vidix (only tested with cvidix though), the SPU layer (when selecting menu buttons) is displayed twice. It means that when you're selecting a button : - the button is selected well with the right color - the selection SPU layer is copied on another part of the screen with wrong color. So basically it still works but the display is not that nice. Ben -- "My life, and by extension everyone else's is meaningless." Bender, Futurama
participants (16)
-
Arpi -
Benjamin Zores -
Benjamin Zores -
Diego Biurrun -
Dominik 'Rathann' Mierzejewski -
Guillaume POIRIER -
Hans-Carl Oberdalhoff -
Nico Sabbi -
Oded Shimon -
Paul TT -
Reynaldo H. Verdejo Pinochet -
Rich Felker -
The Wanderer -
Vladimir Mosgalin -
Ötvös Attila -
Ötvös Attila