[PATCH] Returned without freeing storage "cddb_info"
Hi, The attached patch addresses the following resource leak detected by Covertity's checker: CID: 154 Checker: RESOURCE_LEAK (help) File: main/libmpdemux/cdda.c Function: open_cdda Description: Returned without freeing storage "cddb_info" Do you think it's okay? Guillaume -- Reinventing the wheel certainly is annoying, but as long as all other wheels are square... Reimar Döffinger
Hi, On Sun, Mar 12, 2006 at 03:24:25PM +0100, Guillaume POIRIER wrote:
The attached patch addresses the following resource leak detected by Covertity's checker:
CID: 154 Checker: RESOURCE_LEAK (help) File: main/libmpdemux/cdda.c Function: open_cdda Description: Returned without freeing storage "cddb_info"
Do you think it's okay?
I think so, though I prefer the "goto fail" approach as it helps to avoid making the same error again when e.g. adding a new abort condition Greetings, Reimar Döffinger
Hi, On Sun, Mar 12, 2006 at 03:24:25PM +0100, Guillaume POIRIER wrote:
The attached patch addresses the following resource leak detected by Covertity's checker:
CID: 154 Checker: RESOURCE_LEAK (help) File: main/libmpdemux/cdda.c Function: open_cdda Description: Returned without freeing storage "cddb_info"
Do you think it's okay?
So, go ahead and apply it. And don't forget to fix the same problem a few lines down around line 220. Greetings, Reimar Döffinger
Hi, On 4/16/06, Reimar Döffinger <Reimar.Doeffinger@stud.uni-karlsruhe.de> wrote:
Hi, On Sun, Mar 12, 2006 at 03:24:25PM +0100, Guillaume POIRIER wrote:
The attached patch addresses the following resource leak detected by Covertity's checker:
CID: 154 Checker: RESOURCE_LEAK (help) File: main/libmpdemux/cdda.c Function: open_cdda Description: Returned without freeing storage "cddb_info"
Do you think it's okay?
So, go ahead and apply it. And don't forget to fix the same problem a few lines down around line 220.
applied. Guillaume -- I am disillusioned enough to know that no man's opinion on any subject is worth a damn unless backed up with enough genuine information to make him really know what he's talking about. -- H. P. Lovecraft (about the flamewars on FFmpeg and MPlayer-dev mailing lists) http://www.brainyquote.com/quotes/quotes/h/hplovecr278144.html
participants (2)
-
Guillaume POIRIER -
Reimar Döffinger