[PATCH] Added audio format s32le and s32be for pulseaudio output
Hello, mplayer would not play some wav files using s32le audio format when I ouputted them to pulseaudio (-ao pulse). Looking at the code, I could see that this format (and the big endian as well) was missing. See patch below. Tested it with mplayer SVN 26278 on Ubuntu Hardy, pulseaudio 0.9.9, net-streaming to pulseaudio server running on Debian Sid. Cheers! J. <patch> --- libao2/ao_pulse.c 2008-03-26 19:06:20.000000000 +0100 +++ libao2/ao_pulse.c.new 2008-03-26 18:48:53.000000000 +0100 @@ -121,6 +121,8 @@ {AF_FORMAT_FLOAT_BE, PA_SAMPLE_FLOAT32BE}, {AF_FORMAT_MU_LAW, PA_SAMPLE_ULAW}, {AF_FORMAT_A_LAW, PA_SAMPLE_ALAW}, + {AF_FORMAT_S32_LE, PA_SAMPLE_S32LE}, + {AF_FORMAT_S32_BE, PA_SAMPLE_S32BE}, {AF_FORMAT_UNKNOWN, 0} }; </patch> ____________________________________________________________________________________ Never miss a thing. Make Yahoo your home page. http://www.yahoo.com/r/hs
Hello, On Wed, Mar 26, 2008 at 12:43:09PM -0700, James Warden wrote:
mplayer would not play some wav files using s32le audio format when I ouputted them to pulseaudio (-ao pulse). Looking at the code, I could see that this format (and the big endian as well) was missing. See patch below.
This is not the real issue, the real issue was that ao_pulse did not tell MPlayer to convert to a format it supports but instead failed. With e.g. -af format=s16le it would have played. Your patch e.g. still leaves S8 format as unsupported. I fixed the real problem and applied your patch as well, thanks and sorry for the delay. Greetings, Reimar Döffinger
participants (2)
-
James Warden -
Reimar Döffinger